revert RSpec/BeEq changes and disable

Author: modosc

Diff for: .rubocop.yml

@@ -131,6 +131,9 @@ Rails/RakeEnvironment:
 Rails/SkipsModelValidations:
   Enabled: false
 
+RSpec/BeEq:
+  Enabled: false
+
 # This cop does not seem to work in rubocop-rspec 1.28.0
 RSpec/DescribeClass:
   Enabled: false

Diff for: spec/controllers/articles_controller_spec.rb

@@ -10,19 +10,19 @@
       after { PaperTrail.enabled = false }
 
       it "returns true" do
-        expect(PaperTrail.enabled?).to be(true)
+        expect(PaperTrail.enabled?).to eq(true)
         post :create, params: { article: { title: "Doh", content: FFaker::Lorem.sentence } }
         expect(assigns(:article)).not_to be_nil
-        expect(PaperTrail.request.enabled?).to be(true)
+        expect(PaperTrail.request.enabled?).to eq(true)
         expect(assigns(:article).versions.length).to eq(1)
       end
     end
 
     context "when PaperTrail.enabled? == false" do
       it "returns false" do
-        expect(PaperTrail.enabled?).to be(false)
+        expect(PaperTrail.enabled?).to eq(false)
         post :create, params: { article: { title: "Doh", content: FFaker::Lorem.sentence } }
-        expect(PaperTrail.request.enabled?).to be(false)
+        expect(PaperTrail.request.enabled?).to eq(false)
         expect(assigns(:article).versions.length).to eq(0)
       end
     end

Diff for: spec/controllers/widgets_controller_spec.rb

@@ -21,7 +21,7 @@
       it "controller metadata methods should get evaluated" do
         request.env["HTTP_USER_AGENT"] = "User-Agent"
         post :create, params: { widget: { name: "Flugel" } }
-        expect(PaperTrail.request.enabled?).to be(true)
+        expect(PaperTrail.request.enabled?).to eq(true)
         expect(PaperTrail.request.whodunnit).to(eq(153))
         expect(PaperTrail.request.controller_info.present?).to(be(true))
         expect(PaperTrail.request.controller_info.key?(:ip)).to(be(true))
@@ -34,7 +34,7 @@
         request.env["HTTP_USER_AGENT"] = "Disable User-Agent"
         post :create, params: { widget: { name: "Flugel" } }
         expect(assigns(:widget).versions.length).to(eq(0))
-        expect(PaperTrail.request.enabled?).to be(false)
+        expect(PaperTrail.request.enabled?).to eq(false)
         expect(PaperTrail.request.whodunnit).to be_nil
         expect(PaperTrail.request.controller_info).to eq({})
       end

Diff for: spec/models/animal_spec.rb

@@ -10,7 +10,7 @@
 
   describe "#descends_from_active_record?" do
     it "returns true, meaning that Animal is not an STI subclass" do
-      expect(described_class.descends_from_active_record?).to be(true)
+      expect(described_class.descends_from_active_record?).to eq(true)
     end
   end
 

Diff for: spec/models/cat_spec.rb

@@ -5,7 +5,7 @@
 RSpec.describe Cat, versioning: true do
   describe "#descends_from_active_record?" do
     it "returns false, meaning that Cat is an STI subclass" do
-      expect(described_class.descends_from_active_record?).to be(false)
+      expect(described_class.descends_from_active_record?).to eq(false)
     end
   end
 end

Diff for: spec/models/person_spec.rb

@@ -75,7 +75,7 @@
         person.assign_attributes(time_zone: "Pacific Time (US & Canada)")
         person.save!
         len = person.versions.last.object_changes.length
-        expect(len < 118).to be(true)
+        expect(len < 118).to eq(true)
       end
 
       it "version.object attribute should have stored value from serializer" do

Diff for: spec/models/plant_spec.rb

@@ -10,7 +10,7 @@
 
   describe "#descends_from_active_record?" do
     it "returns true, meaning that Animal is not an STI subclass" do
-      expect(described_class.descends_from_active_record?).to be(true)
+      expect(described_class.descends_from_active_record?).to eq(true)
     end
   end
 

Diff for: spec/paper_trail/cleaner_spec.rb

@@ -62,7 +62,7 @@ module PaperTrail
           expect(animal.versions.first.created_at.to_date).to(eq(date))
           # Why use `equal?` here instead of something less strict?
           # Doesn't `to_date` always produce a new date object?
-          expect(date.equal?(animal.versions.last.created_at.to_date)).to be(false)
+          expect(date.equal?(animal.versions.last.created_at.to_date)).to eq(false)
         end
       end
 

Diff for: spec/paper_trail/events/base_spec.rb

@@ -10,7 +10,7 @@ module Events
           it "returns true" do
             g = Gadget.new(created_at: Time.current)
             event = described_class.new(g, false)
-            expect(event.changed_notably?).to be(true)
+            expect(event.changed_notably?).to eq(true)
           end
         end
 
@@ -19,14 +19,14 @@ module Events
             gadget = Gadget.create!(created_at: Time.current)
             gadget.name = "Wrench"
             event = described_class.new(gadget, false)
-            expect(event.changed_notably?).to be(true)
+            expect(event.changed_notably?).to eq(true)
           end
 
           it "does not acknowledge ignored attr (brand)" do
             gadget = Gadget.create!(created_at: Time.current)
             gadget.brand = "Acme"
             event = described_class.new(gadget, false)
-            expect(event.changed_notably?).to be(false)
+            expect(event.changed_notably?).to eq(false)
           end
         end
 
@@ -36,15 +36,15 @@ module Events
             gadget.name = "Wrench"
             gadget.updated_at = Time.current
             event = described_class.new(gadget, false)
-            expect(event.changed_notably?).to be(true)
+            expect(event.changed_notably?).to eq(true)
           end
 
           it "does not acknowledge ignored attrs and timestamps only" do
             gadget = Gadget.create!(created_at: Time.current)
             gadget.brand = "Acme"
             gadget.updated_at = Time.current
             event = described_class.new(gadget, false)
-            expect(event.changed_notably?).to be(false)
+            expect(event.changed_notably?).to eq(false)
           end
         end
       end

Diff for: spec/paper_trail/request_spec.rb

@@ -6,7 +6,7 @@ module PaperTrail
   ::RSpec.describe(Request, versioning: true) do
     describe ".enabled_for_model?" do
       it "returns true" do
-        expect(PaperTrail.request.enabled_for_model?(Widget)).to be(true)
+        expect(PaperTrail.request.enabled_for_model?(Widget)).to eq(true)
       end
     end
 
@@ -16,9 +16,9 @@ module PaperTrail
       end
 
       it "sets enabled_for_model? to false" do
-        expect(PaperTrail.request.enabled_for_model?(Widget)).to be(true)
+        expect(PaperTrail.request.enabled_for_model?(Widget)).to eq(true)
         PaperTrail.request.disable_model(Widget)
-        expect(PaperTrail.request.enabled_for_model?(Widget)).to be(false)
+        expect(PaperTrail.request.enabled_for_model?(Widget)).to eq(false)
       end
     end
 
@@ -29,15 +29,15 @@ module PaperTrail
 
       it "sets enabled_for_model? to true" do
         PaperTrail.request.enabled_for_model(Widget, false)
-        expect(PaperTrail.request.enabled_for_model?(Widget)).to be(false)
+        expect(PaperTrail.request.enabled_for_model?(Widget)).to eq(false)
         PaperTrail.request.enabled_for_model(Widget, true)
-        expect(PaperTrail.request.enabled_for_model?(Widget)).to be(true)
+        expect(PaperTrail.request.enabled_for_model?(Widget)).to eq(true)
       end
     end
 
     describe ".enabled?" do
       it "returns true" do
-        expect(PaperTrail.request.enabled?).to be(true)
+        expect(PaperTrail.request.enabled?).to eq(true)
       end
     end
 
@@ -48,9 +48,9 @@ module PaperTrail
 
       it "sets enabled? to true" do
         PaperTrail.request.enabled = true
-        expect(PaperTrail.request.enabled?).to be(true)
+        expect(PaperTrail.request.enabled?).to eq(true)
         PaperTrail.request.enabled = false
-        expect(PaperTrail.request.enabled?).to be(false)
+        expect(PaperTrail.request.enabled?).to eq(false)
       end
     end
 
@@ -78,9 +78,9 @@ module PaperTrail
 
       it "sets enabled_for_model? to true" do
         PaperTrail.request.disable_model(Widget)
-        expect(PaperTrail.request.enabled_for_model?(Widget)).to be(false)
+        expect(PaperTrail.request.enabled_for_model?(Widget)).to eq(false)
         PaperTrail.request.enable_model(Widget)
-        expect(PaperTrail.request.enabled_for_model?(Widget)).to be(true)
+        expect(PaperTrail.request.enabled_for_model?(Widget)).to eq(true)
       end
     end
 

Diff for: spec/paper_trail_spec.rb

@@ -11,15 +11,15 @@
 
   describe "#config", versioning: true do
     it "allows for config values to be set" do
-      expect(described_class.config.enabled).to be(true)
+      expect(described_class.config.enabled).to eq(true)
       described_class.config.enabled = false
-      expect(described_class.config.enabled).to be(false)
+      expect(described_class.config.enabled).to eq(false)
     end
 
     it "accepts blocks and yield the config instance" do
-      expect(described_class.config.enabled).to be(true)
+      expect(described_class.config.enabled).to eq(true)
       described_class.config { |c| c.enabled = false }
-      expect(described_class.config.enabled).to be(false)
+      expect(described_class.config.enabled).to eq(false)
     end
   end
 
@@ -46,7 +46,7 @@
 
     it "affects all threads" do
       Thread.new { described_class.enabled = false }.join
-      expect(described_class.enabled?).to be(false)
+      expect(described_class.enabled?).to eq(false)
     end
   end