Skip to content

Commit aa09b89

Browse files
committed
autofix RSpec/MetadataStyle
1 parent 101f7cd commit aa09b89

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

54 files changed

+82
-89
lines changed

Diff for: .rubocop_todo.yml

+1-8
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,11 @@
11
# This configuration was generated by
22
# `rubocop --auto-gen-config`
3-
# on 2025-04-04 23:07:22 UTC using RuboCop version 1.75.1.
3+
# on 2025-04-04 23:09:43 UTC using RuboCop version 1.75.1.
44
# The point is for the user to remove these configuration records
55
# one by one as the offenses are removed from the code base.
66
# Note that changes in the inspected code, or installation of new
77
# versions of RuboCop, may require this file to be generated again.
88

9-
# Offense count: 81
10-
# This cop supports safe autocorrection (--autocorrect).
11-
# Configuration parameters: EnforcedStyle.
12-
# SupportedStyles: hash, symbol
13-
RSpec/MetadataStyle:
14-
Enabled: false
15-
169
# Offense count: 1
1710
# This cop supports unsafe autocorrection (--autocorrect-all).
1811
Rails/ActiveSupportOnLoad:

Diff for: spec/controllers/widgets_controller_spec.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
require "spec_helper"
44

5-
RSpec.describe WidgetsController, versioning: true do
5+
RSpec.describe WidgetsController, :versioning do
66
before { request.env["REMOTE_ADDR"] = "127.0.0.1" }
77

88
after { RequestStore.store[:paper_trail] = nil }

Diff for: spec/models/animal_spec.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
require "spec_helper"
44

5-
RSpec.describe Animal, versioning: true do
5+
RSpec.describe Animal, :versioning do
66
it "baseline test setup" do
77
expect(described_class.new).to be_versioned
88
expect(described_class.inheritance_column).to eq("species")

Diff for: spec/models/article_spec.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
require "spec_helper"
44

5-
RSpec.describe Article, versioning: true do
5+
RSpec.describe Article, :versioning do
66
describe ".create" do
77
it "also creates a version record" do
88
expect { described_class.create }.to(

Diff for: spec/models/book_spec.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
require "spec_helper"
44

5-
RSpec.describe Book, versioning: true do
5+
RSpec.describe Book, :versioning do
66
context "with :has_many :through" do
77
it "store version on source <<" do
88
book = described_class.create(title: "War and Peace")

Diff for: spec/models/boolit_spec.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
require "spec_helper"
44
require "support/custom_json_serializer"
55

6-
RSpec.describe Boolit, versioning: true do
6+
RSpec.describe Boolit, :versioning do
77
let(:boolit) { described_class.create! }
88

99
before { boolit.update!(name: FFaker::Name.name) }

Diff for: spec/models/callback_modifier_spec.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
require "spec_helper"
44

5-
RSpec.describe CallbackModifier, versioning: true do
5+
RSpec.describe CallbackModifier, :versioning do
66
describe "paper_trail_on_destroy" do
77
it "adds :destroy to paper_trail_options[:on]" do
88
modifier = NoArgDestroyModifier.create!(some_content: FFaker::Lorem.sentence)

Diff for: spec/models/car_spec.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,15 @@
55
RSpec.describe Car do
66
it { is_expected.to be_versioned }
77

8-
describe "changeset", versioning: true do
8+
describe "changeset", :versioning do
99
it "has the expected keys (see issue 738)" do
1010
car = described_class.create!(name: "Alice")
1111
car.update(name: "Bob")
1212
assert_includes car.versions.last.changeset.keys, "name"
1313
end
1414
end
1515

16-
describe "attributes and accessors", versioning: true do
16+
describe "attributes and accessors", :versioning do
1717
it "reifies attributes that are not AR attributes" do
1818
car = described_class.create name: "Pinto", color: "green"
1919
car.update color: "yellow"

Diff for: spec/models/cat_spec.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
require "spec_helper"
44

5-
RSpec.describe Cat, versioning: true do
5+
RSpec.describe Cat, :versioning do
66
describe "#descends_from_active_record?" do
77
it "returns false, meaning that Cat is an STI subclass" do
88
expect(described_class.descends_from_active_record?).to eq(false)

Diff for: spec/models/custom_primary_key_record_spec.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
it { is_expected.to be_versioned }
77

88
describe "#versions" do
9-
it "returns instances of CustomPrimaryKeyRecordVersion", versioning: true do
9+
it "returns instances of CustomPrimaryKeyRecordVersion", :versioning do
1010
custom_primary_key_record = described_class.create!
1111
custom_primary_key_record.update!(name: "bob")
1212
version = custom_primary_key_record.versions.last

Diff for: spec/models/document_spec.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
require "spec_helper"
44

5-
RSpec.describe Document, versioning: true do
5+
RSpec.describe Document, :versioning do
66
describe "have_a_version_with matcher" do
77
it "works with custom versions association" do
88
document = described_class.create!(name: "Foo")

Diff for: spec/models/family/celebrity_family_spec.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
require "spec_helper"
44

55
module Family
6-
RSpec.describe CelebrityFamily, versioning: true do
6+
RSpec.describe CelebrityFamily, :versioning do
77
describe "#joins" do
88
it "works on an STI model" do
99
described_class.create!

Diff for: spec/models/foo_widget_spec.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
require "spec_helper"
44
require "support/performance_helpers"
55

6-
RSpec.describe(FooWidget, versioning: true) do
6+
RSpec.describe(FooWidget, :versioning) do
77
context "with a subclass" do
88
let(:foo) { described_class.create }
99

Diff for: spec/models/fruit_spec.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
require "spec_helper"
44

55
if ENV["DB"] == "postgres" && JsonVersion.table_exists?
6-
RSpec.describe Fruit, versioning: true do
6+
RSpec.describe Fruit, :versioning do
77
describe "have_a_version_with_changes matcher" do
88
it "works with Fruit because Fruit uses JsonVersion" do
99
# As of PT 9.0.0, with_version_changes only supports json(b) columns,
@@ -17,7 +17,7 @@
1717
end
1818
end
1919

20-
describe "queries of versions", versioning: true do
20+
describe "queries of versions", :versioning do
2121
let!(:fruit) { described_class.create(name: "Apple", mass: 1, color: "green") }
2222

2323
before do

Diff for: spec/models/gadget_spec.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
it { is_expected.to be_versioned }
99

10-
describe "updates", versioning: true do
10+
describe "updates", :versioning do
1111
it "generates a version for updates" do
1212
expect { gadget.update_attribute(:name, "Hammer") }.to(change { gadget.versions.size }.by(1))
1313
end

Diff for: spec/models/gizmo_spec.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
require "spec_helper"
44
require "support/performance_helpers"
55

6-
RSpec.describe Gizmo, versioning: true do
6+
RSpec.describe Gizmo, :versioning do
77
context "with a persisted record" do
88
it "does not use the gizmo `updated_at` as the version's `created_at`" do
99
gizmo = described_class.create(name: "Fred", created_at: 1.day.ago)

Diff for: spec/models/joined_version_spec.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
require "spec_helper"
44

5-
RSpec.describe JoinedVersion, versioning: true do
5+
RSpec.describe JoinedVersion, :versioning do
66
let(:widget) { Widget.create!(name: FFaker::Name.name) }
77
let(:version) { described_class.first }
88

Diff for: spec/models/json_version_spec.rb

+3-3
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
# The `json_versions` table tests postgres' `json` data type. So, that
66
# table is only created when testing against postgres.
77
if JsonVersion.table_exists?
8-
RSpec.describe JsonVersion, versioning: true do
8+
RSpec.describe JsonVersion, :versioning do
99
it "includes the VersionConcern module" do
1010
expect(described_class).to include(PaperTrail::VersionConcern)
1111
end
@@ -30,7 +30,7 @@
3030
end
3131
end
3232

33-
context "with valid arguments", versioning: true do
33+
context "with valid arguments", :versioning do
3434
it "locates versions according to their `object` contents" do
3535
fruit = Fruit.create!(name: "apple")
3636
expect(fruit.versions.length).to eq(1)
@@ -72,7 +72,7 @@
7272
end
7373
end
7474

75-
context "with valid arguments", versioning: true do
75+
context "with valid arguments", :versioning do
7676
it "finds versions according to their `object_changes` contents" do
7777
fruit = Fruit.create!(name: "apple")
7878
fruit.update!(name: "banana", color: "red")

Diff for: spec/models/kitchen/banana_spec.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ module Kitchen
77
it { is_expected.to be_versioned }
88

99
describe "#versions" do
10-
it "returns instances of Kitchen::BananaVersion", versioning: true do
10+
it "returns instances of Kitchen::BananaVersion", :versioning do
1111
banana = described_class.create!
1212
expect(banana.versions.first).to be_a(Kitchen::BananaVersion)
1313
end

Diff for: spec/models/legacy_widget_spec.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
require "spec_helper"
44

5-
RSpec.describe LegacyWidget, versioning: true do
5+
RSpec.describe LegacyWidget, :versioning do
66
describe "#custom_version" do
77
it "knows which version it came from" do
88
widget = described_class.create(name: "foo", version: 2)

Diff for: spec/models/management_spec.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
require "spec_helper"
44

5-
RSpec.describe(Management, versioning: true) do
5+
RSpec.describe(Management, :versioning) do
66
it "utilises the base_class for STI classes having no type column" do
77
expect(described_class.inheritance_column).to eq("type")
88
expect(described_class.columns.map(&:name)).not_to include("type")

Diff for: spec/models/no_object_spec.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
require "spec_helper"
44

5-
RSpec.describe NoObject, versioning: true do
5+
RSpec.describe NoObject, :versioning do
66
it "still creates version records" do
77
n = described_class.create!(letter: "A")
88
a = n.versions.last.attributes

Diff for: spec/models/not_on_update_spec.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
require "spec_helper"
44

55
RSpec.describe NotOnUpdate do
6-
describe "#save_with_version", versioning: true do
6+
describe "#save_with_version", :versioning do
77
let!(:record) { described_class.create! }
88

99
it "creates a version, regardless" do

Diff for: spec/models/on/create_spec.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
require_dependency "on/create"
55

66
module On
7-
RSpec.describe Create, versioning: true do
7+
RSpec.describe Create, :versioning do
88
describe "#versions" do
99
it "only have a version for the create event" do
1010
record = described_class.create(name: "Alice")

Diff for: spec/models/on/destroy_spec.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
require_dependency "on/destroy"
55

66
module On
7-
RSpec.describe Destroy, versioning: true do
7+
RSpec.describe Destroy, :versioning do
88
describe "#versions" do
99
it "only creates one version record, for the destroy event" do
1010
record = described_class.create(name: "Alice")

Diff for: spec/models/on/empty_array_spec.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
require_dependency "on/empty_array"
55

66
module On
7-
RSpec.describe EmptyArray, versioning: true do
7+
RSpec.describe EmptyArray, :versioning do
88
describe "#create" do
99
it "does not create any version records" do
1010
record = described_class.create(name: "Alice")

Diff for: spec/models/on/touch_spec.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
require_dependency "on/create"
55

66
module On
7-
RSpec.describe Touch, versioning: true do
7+
RSpec.describe Touch, :versioning do
88
describe "#create" do
99
it "does not create a version" do
1010
record = described_class.create(name: "Alice")

Diff for: spec/models/on/update_spec.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
require_dependency "on/update"
55

66
module On
7-
RSpec.describe Update, versioning: true do
7+
RSpec.describe Update, :versioning do
88
describe "#versions" do
99
it "only creates one version record, for the update event" do
1010
record = described_class.create(name: "Alice")

Diff for: spec/models/order_spec.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
require "spec_helper"
44

5-
RSpec.describe Order, versioning: true do
5+
RSpec.describe Order, :versioning do
66
context "when the record destroyed" do
77
it "creates a version record for association" do
88
customer = Customer.create!

Diff for: spec/models/person_spec.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
#
77
# - has a dozen associations of various types
88
# - has a custom serializer, TimeZoneSerializer, for its `time_zone` attribute
9-
RSpec.describe Person, versioning: true do
9+
RSpec.describe Person, :versioning do
1010
describe "#time_zone" do
1111
it "returns an ActiveSupport::TimeZone" do
1212
person = described_class.new(time_zone: "Samoa")

Diff for: spec/models/pet_spec.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
require "spec_helper"
44
require "rails/generators"
55

6-
RSpec.describe Pet, versioning: true do
6+
RSpec.describe Pet, :versioning do
77
it "baseline test setup" do
88
expect(described_class.new).to be_versioned
99
end

Diff for: spec/models/plant_spec.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
require "spec_helper"
44

5-
RSpec.describe Plant, versioning: true do
5+
RSpec.describe Plant, :versioning do
66
it "baseline test setup" do
77
expect(described_class.new).to be_versioned
88
expect(described_class.inheritance_column).to eq("species")

Diff for: spec/models/post_spec.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
require "spec_helper"
44

55
# The `Post` model uses a custom version class, `PostVersion`
6-
RSpec.describe Post, versioning: true do
6+
RSpec.describe Post, :versioning do
77
it "inserts records into the correct table, post_versions" do
88
post = described_class.create
99
expect(PostVersion.count).to(eq(1))

Diff for: spec/models/skipper_spec.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22

33
require "spec_helper"
44

5-
RSpec.describe Skipper, versioning: true do
5+
RSpec.describe Skipper, :versioning do
66
it { is_expected.to be_versioned }
77

8-
describe "#update!", versioning: true do
8+
describe "#update!", :versioning do
99
context "when updating a skipped attribute" do
1010
let(:t1) { Time.zone.local(2015, 7, 15, 20, 34, 0) }
1111
let(:t2) { Time.zone.local(2015, 7, 15, 20, 34, 30) }

Diff for: spec/models/song_spec.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
require "spec_helper"
44

5-
RSpec.describe(Song, versioning: true) do
5+
RSpec.describe(Song, :versioning) do
66
describe "#joins" do
77
it "sets event to 'create' when a new record is created" do
88
described_class.create!

Diff for: spec/models/thing_spec.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
require "spec_helper"
44

55
RSpec.describe Thing do
6-
describe "#versions", versioning: true do
6+
describe "#versions", :versioning do
77
let(:thing) { described_class.create! }
88

99
it "applies the scope option" do

Diff for: spec/models/translation_spec.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
require "spec_helper"
44

5-
RSpec.describe Translation, versioning: true do
5+
RSpec.describe Translation, :versioning do
66
context "with non-US translations" do
77
it "not change the number of versions" do
88
described_class.create!(headline: "Headline")

Diff for: spec/models/vegetable_spec.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
if ENV["DB"] == "postgres" && JsonbVersion.table_exists?
77
RSpec.describe Vegetable do
8-
describe "queries of versions", versioning: true do
8+
describe "queries of versions", :versioning do
99
let!(:vegetable) { described_class.create(name: "Veggie", mass: 1, color: "green") }
1010

1111
before do

0 commit comments

Comments
 (0)