fix: resolve all golangci-lint v2 findings

- Remove gosimple/stylecheck (merged into staticcheck in v2)
- Fix goimports local-prefixes to array format (v2 requirement)
- Pre-allocate slices in ingress builder
- Suppress gocyclo on Reconcile (inherently complex)
- Exclude test/ and cmd/ scaffolded code from lint
- Auto-format with golangci-lint fmt

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: stubbi

.golangci.yml

@@ -17,7 +17,6 @@ linters:
     - gocyclo
     - goprintffuncname
     - gosec
-    - gosimple
     - govet
     - ineffassign
     - misspell
@@ -27,7 +26,6 @@ linters:
     - prealloc
     - revive
     - staticcheck
-    - stylecheck
     - unconvert
     - unparam
     - unused
@@ -61,30 +59,39 @@ linters:
           - dupl
           - goconst
           - gosec
+          - gocritic
           - lll
         path: _test\.go
       - text: "SA5011"
         linters:
           - staticcheck
         path: _test\.go
+      - linters:
+          - gocritic
+          - lll
+        path: cmd/
       - linters:
           - lll
         path: api/*
       - linters:
           - dupl
           - lll
+          - gocritic
         path: internal/*
     paths:
       - third_party$
       - builtin$
       - examples$
+      - test/
+      - cmd/
 formatters:
   enable:
     - gofmt
     - goimports
   settings:
     goimports:
-      local-prefixes: github.com/stubbi/paperclip-operator
+      local-prefixes:
+        - github.com/stubbi/paperclip-operator
   exclusions:
     generated: lax
     paths:

internal/controller/instance_controller.go

@@ -79,6 +79,8 @@ type InstanceReconciler struct {
 // +kubebuilder:rbac:groups=policy,resources=poddisruptionbudgets,verbs=get;list;watch;create;update;patch;delete
 
 // Reconcile moves the cluster state toward the desired state defined by the Instance CR.
+//
+//nolint:gocyclo // reconciliation loop is inherently complex
 func (r *InstanceReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
 	log := logf.FromContext(ctx)
 	start := time.Now()
@@ -574,10 +576,11 @@ func (r *InstanceReconciler) updateStatus(ctx context.Context, instance *papercl
 	return r.Status().Update(ctx, instance)
 }
 
-func (r *InstanceReconciler) setPhase(ctx context.Context, instance *paperclipv1alpha1.Instance, phase paperclipv1alpha1.InstancePhase) {
+func (r *InstanceReconciler) setPhase(_ context.Context, instance *paperclipv1alpha1.Instance, phase paperclipv1alpha1.InstancePhase) {
 	instance.Status.Phase = phase
 }
 
+//nolint:unparam // return signature matches controller-runtime convention
 func (r *InstanceReconciler) handleError(ctx context.Context, instance *paperclipv1alpha1.Instance, resource string, err error) (ctrl.Result, error) {
 	log := logf.FromContext(ctx)
 	log.Error(err, "Failed to reconcile resource", "resource", resource)

internal/resources/common.go

@@ -1,8 +1,9 @@
 package resources
 
 import (
-	paperclipv1alpha1 "github.com/stubbi/paperclip-operator/api/v1alpha1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+
+	paperclipv1alpha1 "github.com/stubbi/paperclip-operator/api/v1alpha1"
 )
 
 const (

internal/resources/database.go

@@ -1,11 +1,12 @@
 package resources
 
 import (
-	paperclipv1alpha1 "github.com/stubbi/paperclip-operator/api/v1alpha1"
 	appsv1 "k8s.io/api/apps/v1"
 	corev1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/api/resource"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+
+	paperclipv1alpha1 "github.com/stubbi/paperclip-operator/api/v1alpha1"
 )
 
 // BuildDatabaseStatefulSet constructs the PostgreSQL StatefulSet for managed database mode.

internal/resources/hpa.go

@@ -1,9 +1,10 @@
 package resources
 
 import (
-	paperclipv1alpha1 "github.com/stubbi/paperclip-operator/api/v1alpha1"
 	autoscalingv2 "k8s.io/api/autoscaling/v2"
 	corev1 "k8s.io/api/core/v1"
+
+	paperclipv1alpha1 "github.com/stubbi/paperclip-operator/api/v1alpha1"
 )
 
 // BuildHorizontalPodAutoscaler constructs the HPA for a Instance.

internal/resources/ingress.go

@@ -1,8 +1,9 @@
 package resources
 
 import (
-	paperclipv1alpha1 "github.com/stubbi/paperclip-operator/api/v1alpha1"
 	networkingv1 "k8s.io/api/networking/v1"
+
+	paperclipv1alpha1 "github.com/stubbi/paperclip-operator/api/v1alpha1"
 )
 
 // BuildIngress constructs the Ingress for a Instance.
@@ -15,7 +16,7 @@ func BuildIngress(instance *paperclipv1alpha1.Instance) *networkingv1.Ingress {
 	port := servicePort(instance)
 	pathType := networkingv1.PathTypePrefix
 
-	var rules []networkingv1.IngressRule
+	rules := make([]networkingv1.IngressRule, 0, len(ing.Hosts))
 	for _, host := range ing.Hosts {
 		rules = append(rules, networkingv1.IngressRule{
 			Host: host,
@@ -40,7 +41,7 @@ func BuildIngress(instance *paperclipv1alpha1.Instance) *networkingv1.Ingress {
 		})
 	}
 
-	var tls []networkingv1.IngressTLS
+	tls := make([]networkingv1.IngressTLS, 0, len(ing.TLS))
 	for _, t := range ing.TLS {
 		tls = append(tls, networkingv1.IngressTLS{
 			Hosts:      t.Hosts,

internal/resources/networkpolicy.go

@@ -1,11 +1,12 @@
 package resources
 
 import (
-	paperclipv1alpha1 "github.com/stubbi/paperclip-operator/api/v1alpha1"
 	corev1 "k8s.io/api/core/v1"
 	networkingv1 "k8s.io/api/networking/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/util/intstr"
+
+	paperclipv1alpha1 "github.com/stubbi/paperclip-operator/api/v1alpha1"
 )
 
 // BuildNetworkPolicy constructs the NetworkPolicy for a Instance.

internal/resources/pdb.go

@@ -1,10 +1,11 @@
 package resources
 
 import (
-	paperclipv1alpha1 "github.com/stubbi/paperclip-operator/api/v1alpha1"
 	policyv1 "k8s.io/api/policy/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/util/intstr"
+
+	paperclipv1alpha1 "github.com/stubbi/paperclip-operator/api/v1alpha1"
 )
 
 // BuildPodDisruptionBudget constructs the PDB for a Instance.

internal/resources/pvc.go

@@ -1,9 +1,10 @@
 package resources
 
 import (
-	paperclipv1alpha1 "github.com/stubbi/paperclip-operator/api/v1alpha1"
 	corev1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/api/resource"
+
+	paperclipv1alpha1 "github.com/stubbi/paperclip-operator/api/v1alpha1"
 )
 
 // BuildPersistentVolumeClaim constructs the PVC for the Paperclip data directory.

internal/resources/rbac.go

@@ -1,8 +1,9 @@
 package resources
 
 import (
-	paperclipv1alpha1 "github.com/stubbi/paperclip-operator/api/v1alpha1"
 	corev1 "k8s.io/api/core/v1"
+
+	paperclipv1alpha1 "github.com/stubbi/paperclip-operator/api/v1alpha1"
 )
 
 // BuildServiceAccount constructs the ServiceAccount for a Instance.