Skip to content

Commit 270b3d2

Browse files
committed
fix: remove duplicate terminalizeLoginPtyRoute code from publishStreamNotification
Merge artifact: the terminalize block was duplicated inside publishStreamNotification (a sync function). The correct copy already exists in the async terminalizeLoginPtyRoute function above.
1 parent edf67a0 commit 270b3d2

1 file changed

Lines changed: 1 addition & 15 deletions

File tree

server/src/services/plugin-worker-manager.ts

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1552,21 +1552,7 @@ function publishStreamNotification(
15521552
params.event,
15531553
streamEventTypeForMethod(method),
15541554
);
1555-
// A terminalized route reports a null exit code, which the runner treats as a
1556-
// failure.
1557-
settleRouteWait(route, { exitCode: null });
1558-
const confirmed = await closeLoginPtyTerminal(route.hostRouteId);
1559-
if (loginPtyRoute === route) loginPtyRoute = null;
1560-
if (!confirmed) {
1561-
// The worker did not acknowledge the close, so the host cannot prove the
1562-
// terminal is gone. Fail closed: retire the worker before any reuse.
1563-
log.error(
1564-
{ pluginId },
1565-
"login pseudo-terminal close not acknowledged; retiring worker",
1566-
);
1567-
void killProcess();
1568-
}
1569-
}
1555+
}
15701556

15711557
// Route one login pseudo-terminal output notification to the per-session
15721558
// listener. Deliver only while the route is `open` and the notification carries

0 commit comments

Comments
 (0)