fix(cloud onboarding): CEO can hire + clean claude transcript (#244)

fix(cloud onboarding): CEO can hire + clean claude transcript

Author: stubbi

packages/adapters/claude-local/src/ui/parse-stdout.test.ts

@@ -0,0 +1,109 @@
+import { describe, expect, it } from "vitest";
+import { parseClaudeStdoutLine } from "./parse-stdout.js";
+
+const TS = "2026-07-15T20:21:29.280Z";
+
+describe("parseClaudeStdoutLine", () => {
+  it("renders assistant text blocks", () => {
+    const line = JSON.stringify({
+      type: "assistant",
+      message: { role: "assistant", content: [{ type: "text", text: "hello" }] },
+    });
+    expect(parseClaudeStdoutLine(line, TS)).toEqual([{ kind: "assistant", ts: TS, text: "hello" }]);
+  });
+
+  it("renders user tool_result blocks", () => {
+    const line = JSON.stringify({
+      type: "user",
+      message: {
+        role: "user",
+        content: [{ type: "tool_result", tool_use_id: "toolu_1", content: "ok", is_error: false }],
+      },
+    });
+    expect(parseClaudeStdoutLine(line, TS)).toEqual([
+      { kind: "tool_result", ts: TS, toolUseId: "toolu_1", content: "ok", isError: false },
+    ]);
+  });
+
+  it("renders the system init frame", () => {
+    const line = JSON.stringify({
+      type: "system",
+      subtype: "init",
+      model: "claude-sonnet-5",
+      session_id: "c4a56dd0",
+    });
+    expect(parseClaudeStdoutLine(line, TS)).toEqual([
+      { kind: "init", ts: TS, model: "claude-sonnet-5", sessionId: "c4a56dd0" },
+    ]);
+  });
+
+  // Regression: these control frames used to fall through to `{ kind: "stdout" }`
+  // and dump raw JSON between the nicely-rendered messages in "nice" mode.
+  it("suppresses rate_limit_event frames", () => {
+    const line = JSON.stringify({
+      type: "rate_limit_event",
+      rate_limit_info: {
+        status: "allowed",
+        resetsAt: 1784153400,
+        rateLimitType: "five_hour",
+        overageStatus: "rejected",
+        overageDisabledReason: "org_level_disabled",
+      },
+    });
+    expect(parseClaudeStdoutLine(line, TS)).toEqual([]);
+  });
+
+  it("suppresses system thinking_tokens streaming deltas", () => {
+    const line = JSON.stringify({
+      type: "system",
+      subtype: "thinking_tokens",
+      estimated_tokens: 50,
+      estimated_tokens_delta: 50,
+      uuid: "34603adf",
+      session_id: "c4a56dd0",
+    });
+    expect(parseClaudeStdoutLine(line, TS)).toEqual([]);
+  });
+
+  it("renders sub-task lifecycle frames as compact system notes, not raw JSON", () => {
+    const started = parseClaudeStdoutLine(
+      JSON.stringify({
+        type: "system",
+        subtype: "task_started",
+        task_id: "b8luq6h49",
+        tool_use_id: "toolu_2",
+        description: "Provision founding engineer",
+      }),
+      TS,
+    );
+    expect(started).toEqual([
+      { kind: "system", ts: TS, text: "task started: Provision founding engineer" },
+    ]);
+
+    const notified = parseClaudeStdoutLine(
+      JSON.stringify({ type: "system", subtype: "task_notification", task_id: "b8luq6h49", status: "completed" }),
+      TS,
+    );
+    expect(notified).toEqual([{ kind: "system", ts: TS, text: "task completed" }]);
+  });
+
+  it("renders other system subtypes as a compact note", () => {
+    const line = JSON.stringify({ type: "system", subtype: "compact_boundary" });
+    expect(parseClaudeStdoutLine(line, TS)).toEqual([{ kind: "system", ts: TS, text: "system: compact_boundary" }]);
+  });
+
+  it("keeps non-JSON bridge lines as stdout", () => {
+    const line = "[paperclip] Claude ACP default unavailable; falling back to Claude CLI.";
+    expect(parseClaudeStdoutLine(line, TS)).toEqual([{ kind: "stdout", ts: TS, text: line }]);
+  });
+
+  it("does not dump unrecognized JSON events as raw stdout", () => {
+    const line = JSON.stringify({ type: "some_future_event", foo: 1 });
+    expect(parseClaudeStdoutLine(line, TS)).toEqual([{ kind: "system", ts: TS, text: "some_future_event" }]);
+  });
+
+  it("drops typeless JSON control objects", () => {
+    const line = JSON.stringify({ status: "allowed", resetsAt: 1784153400 });
+    expect(parseClaudeStdoutLine(line, TS)).toEqual([]);
+  });
+});

packages/adapters/claude-local/src/ui/parse-stdout.ts

@@ -46,15 +46,37 @@ export function parseClaudeStdoutLine(line: string, ts: string): TranscriptEntry
     return parseAcpxStdoutLine(line, ts);
   }
 
-  if (type === "system" && parsed.subtype === "init") {
-    return [
-      {
-        kind: "init",
-        ts,
-        model: typeof parsed.model === "string" ? parsed.model : "unknown",
-        sessionId: typeof parsed.session_id === "string" ? parsed.session_id : "",
-      },
-    ];
+  // Claude Code emits high-frequency control frames alongside the message stream
+  // (rate-limit polls, partial-message token estimates). They carry no transcript
+  // value and, when rendered raw, dump JSON between the nicely-formatted messages.
+  // Suppress them in "nice" mode (raw mode still shows the full log).
+  if (type === "rate_limit_event") return [];
+
+  if (type === "system") {
+    const subtype = typeof parsed.subtype === "string" ? parsed.subtype : "";
+    if (subtype === "init") {
+      return [
+        {
+          kind: "init",
+          ts,
+          model: typeof parsed.model === "string" ? parsed.model : "unknown",
+          sessionId: typeof parsed.session_id === "string" ? parsed.session_id : "",
+        },
+      ];
+    }
+    // Streaming token-estimate deltas are pure noise (one per partial message).
+    if (subtype === "thinking_tokens") return [];
+    // Sub-task lifecycle and any other system event: render a compact one-line
+    // note instead of the raw JSON.
+    if (subtype === "task_started") {
+      const desc = typeof parsed.description === "string" ? parsed.description : "";
+      return [{ kind: "system", ts, text: desc ? `task started: ${desc}` : "task started" }];
+    }
+    if (subtype === "task_notification") {
+      const status = typeof parsed.status === "string" ? parsed.status : "";
+      return [{ kind: "system", ts, text: status ? `task ${status}` : "task update" }];
+    }
+    return [{ kind: "system", ts, text: subtype ? `system: ${subtype}` : "system event" }];
   }
 
   if (type === "assistant") {
@@ -86,7 +108,7 @@ export function parseClaudeStdoutLine(line: string, ts: string): TranscriptEntry
         });
       }
     }
-    return entries.length > 0 ? entries : [{ kind: "stdout", ts, text: line }];
+    return entries.length > 0 ? entries : [];
   }
 
   if (type === "user") {
@@ -118,7 +140,8 @@ export function parseClaudeStdoutLine(line: string, ts: string): TranscriptEntry
       }
     }
     if (entries.length > 0) return entries;
-    // fall through to stdout for user messages without recognized blocks
+    // user message with no recognized blocks: nothing to show in "nice" mode.
+    return [];
   }
 
   if (type === "result") {
@@ -145,5 +168,8 @@ export function parseClaudeStdoutLine(line: string, ts: string): TranscriptEntry
     }];
   }
 
-  return [{ kind: "stdout", ts, text: line }];
+  // Unrecognized JSON event: render a compact note if it is typed, otherwise drop
+  // it. Never dump raw JSON into the "nice" transcript (non-JSON plain-text lines,
+  // e.g. "[paperclip] ..." bridge messages, are handled above as stdout).
+  return type ? [{ kind: "system", ts, text: type }] : [];
 }

ui/src/components/OnboardingWizard.tsx

@@ -136,6 +136,9 @@ function buildMissionFromQuestionnaire(q1: string, q2: string, q3: string, q4: s
 }
 
 const ONBOARDING_STORAGE_KEY = "paperclip-onboarding-state";
+// Skill (by key) that teaches the governance-aware agent-hiring flow. Attached to
+// the onboarding CEO so it can fulfil its seed task of hiring the first engineer.
+const ONBOARDING_CEO_SKILL_KEY = "paperclip-create-agent";
 const DEFAULT_TASK_TITLE = "Hire your first engineer and create a hiring plan";
 const DEFAULT_TASK_DESCRIPTION = `You are the CEO. You set the direction for the company.
 
@@ -815,7 +818,12 @@ export function OnboardingWizard() {
         role: "ceo",
         adapterType,
         adapterConfig: mergeCredentialBindings(buildAdapterConfig(), credentialBindings, credentialSetup),
-        runtimeConfig: buildNewAgentRuntimeConfig()
+        runtimeConfig: buildNewAgentRuntimeConfig(),
+        // The onboarding CEO's seed task is to hire the first engineer. Attach the
+        // create-agent skill so its run session exposes the governance-aware hiring
+        // flow (POST /api/companies/:id/agent-hires); without it the agent does not
+        // know the sanctioned route and hits "Route not allowed" on guessed ones.
+        desiredSkills: [ONBOARDING_CEO_SKILL_KEY],
       });
       if (hire.approval) {
         await approvalsApi.approve(