Skip to content

Commit ae0e7a0

Browse files
stuhoodparadedb-github-bot[bot]
authored andcommitted
Fix Slack mentions by always mentioning at-most the approvers (#41)
Incorporate paradedb/actions#7 to fix Slack mentions by always mentioning at-most the approvers: never `@here`.
1 parent b9429a2 commit ae0e7a0

3 files changed

Lines changed: 4 additions & 3 deletions

File tree

.github/workflows/sync-promote-branch.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ concurrency:
1919

2020
jobs:
2121
call-promote:
22-
uses: paradedb/actions/.github/workflows/reusable-promote.yml@v5
22+
uses: paradedb/actions/.github/workflows/reusable-promote.yml@v7
2323
with:
2424
branch_name: ${{ inputs.branch_name }}
2525
approvers: "philippemnoel,rebasedming,stuhood,mdashti"

.github/workflows/sync-upstream-rebase.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,10 @@ concurrency:
1717

1818
jobs:
1919
call-rebase:
20-
uses: paradedb/actions/.github/workflows/reusable-rebase.yml@v5
20+
uses: paradedb/actions/.github/workflows/reusable-rebase.yml@v7
2121
with:
2222
github_app_client_id: ${{ vars.PARADEDB_GITHUB_APP_CLIENT_ID }}
23+
approvers: "philippemnoel,rebasedming,stuhood,mdashti"
2324
secrets:
2425
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_GITHUB_CHANNEL_WEBHOOK_URL }}
2526
PARADEDB_GITHUB_APP_PRIVATE_KEY: ${{ secrets.PARADEDB_GITHUB_APP_PRIVATE_KEY }}

scripts/sync-upstream.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ export UPSTREAM_BRANCH="main"
1414

1515
# 2. Define the URL to the centralized script
1616
# Using the raw content URL from the central repository
17-
CORE_SCRIPT_URL="https://raw.githubusercontent.com/paradedb/actions/v5/scripts/sync-core.sh"
17+
CORE_SCRIPT_URL="https://raw.githubusercontent.com/paradedb/actions/v7/scripts/sync-core.sh"
1818

1919
# 3. Download and source the core logic as an API
2020
TMP_SCRIPT=$(mktemp)

0 commit comments

Comments
 (0)