Skip to content

fix: Only accept one argument to match - #122

Merged
isaacvando merged 2 commits into
mainfrom
only-accept-single-argument-to-match
Jul 14, 2026
Merged

fix: Only accept one argument to match#122
isaacvando merged 2 commits into
mainfrom
only-accept-single-argument-to-match

Conversation

@isaacvando

Copy link
Copy Markdown
Collaborator

Ticket(s) Closed

  • Closes #

What

It doesn't make sense to pass an array to match. None of the other ORMs do this.

Why

How

Tests

@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.37%. Comparing base (5473ded) to head (6011df1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
- Coverage   90.40%   90.37%   -0.03%     
==========================================
  Files          20       20              
  Lines        2417     2411       -6     
  Branches      776      774       -2     
==========================================
- Hits         2185     2179       -6     
+ Misses        232      190      -42     
- Partials        0       42      +42     
Flag Coverage Δ
rails-paradedb 90.37% <100.00%> (-0.03%) ⬇️
rb3.2 90.65% <100.00%> (-0.03%) ⬇️
rb3.3 90.65% <100.00%> (-0.03%) ⬇️
rb3.4 90.37% <100.00%> (-0.03%) ⬇️
rb4.0 81.87% <100.00%> (-0.05%) ⬇️
rl7.2 90.37% <100.00%> (-0.03%) ⬇️
rl8.1 81.87% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
lib/parade_db/arel/builder.rb 94.18% <100.00%> (-0.04%) ⬇️
lib/parade_db/arel/predications.rb 97.63% <100.00%> (-0.08%) ⬇️
lib/parade_db/search_methods.rb 94.12% <100.00%> (ø)

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@isaacvando
isaacvando merged commit 9e7eb4b into main Jul 14, 2026
15 checks passed
@isaacvando
isaacvando deleted the only-accept-single-argument-to-match branch July 14, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants