Skip to content

feat: Implement function-based tokenizer API - #84

Merged
isaacvando merged 12 commits into
mainfrom
fix-schema-compat
Apr 21, 2026
Merged

feat: Implement function-based tokenizer API#84
isaacvando merged 12 commits into
mainfrom
fix-schema-compat

Conversation

@isaacvando

@isaacvando isaacvando commented Apr 16, 2026

Copy link
Copy Markdown
Collaborator

Ticket(s) Closed

  • Closes #

What

  • Adds a test covering all tokenizer variants explicitly
  • Introduces a function-based tokenizer API for queries and index creation
  • Switches to the same python schema-compat script from the SQLAlchemy repo instead of using a bespoke ruby one.
    • The ruby had some bugs and was letting some symbols through without showing up in the source.

Why

How

Tests

@codecov

codecov Bot commented Apr 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.87179% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.34%. Comparing base (17ec036) to head (c0cb1a2).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/parade_db/migration_helpers.rb 81.81% 2 Missing ⚠️
lib/parade_db/index.rb 92.30% 1 Missing ⚠️
lib/parade_db/tokenizer.rb 98.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
+ Coverage   90.15%   90.34%   +0.19%     
==========================================
  Files          19       20       +1     
  Lines        2396     2403       +7     
  Branches      721      710      -11     
==========================================
+ Hits         2160     2171      +11     
+ Misses        236      232       -4     
Flag Coverage Δ
rails-paradedb 90.34% <94.87%> (+0.19%) ⬆️
rb3.2 90.62% <94.87%> (+0.19%) ⬆️
rb3.3 90.62% <94.87%> (+0.19%) ⬆️
rb3.4 90.34% <94.87%> (+0.19%) ⬆️
rb4.0 90.34% <94.87%> (+0.19%) ⬆️
rl7.2 90.34% <94.87%> (+0.19%) ⬆️
rl8.1 90.34% <94.87%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
lib/parade_db.rb 98.11% <100.00%> (+0.03%) ⬆️
lib/parade_db/arel/builder.rb 94.09% <100.00%> (-1.57%) ⬇️
lib/parade_db/index.rb 89.36% <92.30%> (+6.47%) ⬆️
lib/parade_db/tokenizer.rb 98.00% <98.00%> (ø)
lib/parade_db/migration_helpers.rb 84.60% <81.81%> (-1.14%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@isaacvando
isaacvando marked this pull request as ready for review April 16, 2026 20:13

@philippemnoel philippemnoel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we ignoring this tokenizer?

Comment thread apiignore.json5
Comment thread .github/workflows/schema-compat.yml Outdated
@philippemnoel

Copy link
Copy Markdown
Member

As discussed in Slack, instead of this we should add support for edge_ngram and test all tokenizers

@isaacvando
isaacvando force-pushed the fix-schema-compat branch 2 times, most recently from 01738b7 to 7611770 Compare April 20, 2026 21:32
@isaacvando isaacvando changed the title chore: Fix schema compat feat: Implement function-based tokenizer API Apr 20, 2026
Comment thread .github/workflows/schema-compat.yml Outdated
Comment thread apiignore.json5

@philippemnoel philippemnoel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As d

@isaacvando
isaacvando merged commit fbf476c into main Apr 21, 2026
16 checks passed
@isaacvando
isaacvando deleted the fix-schema-compat branch April 21, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants