feat: Implement function-based tokenizer API - #84
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
==========================================
+ Coverage 90.15% 90.34% +0.19%
==========================================
Files 19 20 +1
Lines 2396 2403 +7
Branches 721 710 -11
==========================================
+ Hits 2160 2171 +11
+ Misses 236 232 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
isaacvando
marked this pull request as ready for review
April 16, 2026 20:13
isaacvando
requested review from
mdashti,
philippemnoel,
rebasedming and
stuhood
as code owners
April 16, 2026 20:13
philippemnoel
requested changes
Apr 16, 2026
philippemnoel
left a comment
Member
There was a problem hiding this comment.
Why are we ignoring this tokenizer?
Member
|
As discussed in Slack, instead of this we should add support for edge_ngram and test all tokenizers |
isaacvando
force-pushed
the
fix-schema-compat
branch
2 times, most recently
from
April 20, 2026 21:32
01738b7 to
7611770
Compare
This reverts commit 2d42fbf.
isaacvando
force-pushed
the
fix-schema-compat
branch
from
April 20, 2026 21:32
7611770 to
b0f0659
Compare
rebasedming
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket(s) Closed
What
Why
How
Tests