Skip to content

Commit ede5993

Browse files
committed
Review feedback
1 parent cc18855 commit ede5993

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

interpreter/golang/golang.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ func Loader(_ interpreter.EbpfHandler, info *interpreter.LoaderInfo) (interprete
7070
// are our best bet.
7171
log.Warnf("version %s unknown; using offsets for latest known Go version %s."+
7272
"If Go traceID integration and other custom labels support is buggy,"+
73-
" try upgrading to the latest version.", goVersion, latestVersion)
73+
" try upgrading to the latest profiler version.", goVersion, latestVersion)
7474
return data{
7575
goVersion: goVersion,
7676
offsets: allOffsets[latestVersion],

interpreter/golang/runtime_data.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,11 @@ import "C"
88
// Consider bumping this whenever a new version of Go is released.
99
var latestVersion = "go1.24"
1010

11+
// Offsets come from DWARF debug information:
12+
// https://github.com/parca-dev/parca-agent/blob/2815ded21704934c/pkg/runtime/golang/golang.go#L85
13+
// However since DWARF information can be stripped we record them here.
14+
// TODO: Should we look for DWARF information to support new versions
15+
// automatically when available?
1116
var allOffsets = map[string]C.GoCustomLabelsOffsets{
1217
"go1.13": {
1318
m_offset: 48,

0 commit comments

Comments
 (0)