Skip to content

Commit ef3a1ef

Browse files
authored
Merge pull request #87 from parca-dev/log-quiet
Make golabels only do debug logging on stripped Go binaries, this is apparently very common
2 parents bb37a8a + 9970d20 commit ef3a1ef

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

interpreter/golabels/tls_amd64.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@ import (
1818
func extractTLSGOffset(f *pfelf.File, path string) (int32, error) {
1919
syms, err := f.ReadSymbols()
2020
if err != nil {
21-
return 0, err
21+
log.Debugf("Failed to find symbols (%v) using default TLSG offset", err)
22+
return -8, nil
2223
}
2324
// Dump of assembler code for function runtime.stackcheck:
2425
// 0x0000000000470080 <+0>: mov %fs:0xfffffffffffffff8,%rax

interpreter/golabels/tls_arm64.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,8 @@ func extractTLSGOffset(f *pfelf.File, path string) (int32, error) {
2929

3030
syms, err := f.ReadSymbols()
3131
if err != nil {
32-
return 0, err
32+
log.Debugf("Failed to find symbols (%v) using default TLSG offset", err)
33+
return 0, nil
3334
}
3435
sym, err := syms.LookupSymbol("runtime.load_g.abi0")
3536
if err != nil {

0 commit comments

Comments
 (0)