Refine parameter binding warnings

Author: pardeike

Lib.GAB.Example/Program.cs

@@ -1,9 +1,9 @@
 using System;
 using System.Linq;
 using System.Threading.Tasks;
-using Lib.GAB;
 using Lib.GAB.Tools;
 using Lib.GAB.Server;
+using GabpApi = Lib.GAB.Gabp;
 
 // Example game/application tools
 public class GameTools
@@ -56,7 +56,7 @@ static async Task Main(string[] args)
         Console.WriteLine("Starting GABP Server Example...");
 
         // Check if we're running under GABS
-        if (Gabp.IsRunningUnderGabs())
+        if (GabpApi.IsRunningUnderGabs())
         {
             Console.WriteLine("\nRunning under GABS - using GABS-aware configuration");
             await RunGabsAwareExample();
@@ -82,7 +82,7 @@ static async Task RunGabsAwareExample()
     {
         // Create server with automatic GABS environment detection
         var gameTools = new GameTools();
-        var server = Gabp.CreateGabsAwareServerWithInstance("Example Game", "1.0.0", gameTools);
+        var server = GabpApi.CreateGabsAwareServerWithInstance("Example Game", "1.0.0", gameTools);
 
         // Register some event channels
         server.Events.RegisterChannel("player/move", "Player movement events");
@@ -132,7 +132,7 @@ static async Task RunTraditionalExample()
     {
         // Create server with tools from a class instance (traditional way)
         var gameTools = new GameTools();
-        var server = Gabp.CreateServerWithInstance("Example Game", "1.0.0", gameTools, port: 0);
+        var server = GabpApi.CreateServerWithInstance("Example Game", "1.0.0", gameTools, port: 0);
 
         // Register some event channels
         server.Events.RegisterChannel("player/move", "Player movement events");
@@ -179,7 +179,7 @@ static async Task RunExternalConfigExample()
 
         // Create server with external configuration
         var gameTools = new GameTools();
-        var server = Gabp.CreateServerWithInstanceAndExternalConfig(
+        var server = GabpApi.CreateServerWithInstanceAndExternalConfig(
             "Example Game", "1.0.0", gameTools, externalPort, externalToken, gameId);
 
         // Register event channels

Lib.GAB.Tests/ToolRegistryTests.cs

@@ -0,0 +1,91 @@
+using System;
+using System.Diagnostics;
+using System.IO;
+using System.Threading.Tasks;
+using Lib.GAB;
+using Lib.GAB.Tools;
+
+namespace Lib.GAB.Tests;
+
+public class ToolRegistryTests
+{
+    private static readonly object TraceLock = new object();
+
+    [Fact]
+    public async Task MatchesParametersCaseInsensitively()
+    {
+        var server = Gabp.CreateSimpleServer("Test App", "1.0.0");
+        server.Tools.RegisterToolsFromInstance(new ParameterBindingTestTools());
+
+        var result = await server.Tools.CallToolAsync("math/add", new { A = 5, B = 3 });
+
+        Assert.Equal(8, result);
+    }
+
+    [Fact]
+    public void CaseInsensitiveMatchesDoNotLogUnrecognizedWarnings()
+    {
+        var server = Gabp.CreateSimpleServer("Test App", "1.0.0");
+        server.Tools.RegisterToolsFromInstance(new ParameterBindingTestTools());
+
+        var traceOutput = CaptureTraceOutput(() =>
+        {
+            var result = server.Tools.CallToolAsync("math/add", new { A = 5, B = 3 }).GetAwaiter().GetResult();
+            Assert.Equal(8, result);
+        });
+
+        Assert.Contains("parameter 'A' matched 'a' via case-insensitive fallback", traceOutput);
+        Assert.Contains("parameter 'B' matched 'b' via case-insensitive fallback", traceOutput);
+        Assert.DoesNotContain("unrecognized parameter 'A'", traceOutput);
+        Assert.DoesNotContain("unrecognized parameter 'B'", traceOutput);
+    }
+
+    [Fact]
+    public void UnknownParametersStillLogWarnings()
+    {
+        var server = Gabp.CreateSimpleServer("Test App", "1.0.0");
+        server.Tools.RegisterToolsFromInstance(new ParameterBindingTestTools());
+
+        var traceOutput = CaptureTraceOutput(() =>
+        {
+            var result = server.Tools.CallToolAsync("math/add", new { a = 5, b = 3, c = 1 }).GetAwaiter().GetResult();
+            Assert.Equal(8, result);
+        });
+
+        Assert.Contains("unrecognized parameter 'c'", traceOutput);
+    }
+
+    private static string CaptureTraceOutput(Action action)
+    {
+        lock (TraceLock)
+        {
+            var previousAutoFlush = Trace.AutoFlush;
+            using var writer = new StringWriter();
+            using var listener = new TextWriterTraceListener(writer);
+            Trace.AutoFlush = true;
+            Trace.Listeners.Add(listener);
+
+            try
+            {
+                action();
+                listener.Flush();
+                return writer.ToString();
+            }
+            finally
+            {
+                Trace.Listeners.Remove(listener);
+                Trace.AutoFlush = previousAutoFlush;
+            }
+        }
+    }
+
+    public class ParameterBindingTestTools
+    {
+        [Tool("math/add", Description = "Add two numbers")]
+        public int Add([ToolParameter(Description = "First number")] int a,
+            [ToolParameter(Description = "Second number")] int b)
+        {
+            return a + b;
+        }
+    }
+}

Lib.GAB/Tools/ToolRegistry.cs

@@ -184,18 +184,23 @@ private object[] ConvertParameters(MethodInfo method, object parameters)
             }
 
             // Warn about unrecognized keys that don't match any method parameter
-            var methodParamNames = new HashSet<string>(methodParams.Select(p => p.Name));
+            var methodParamNames = methodParams.Select(p => p.Name).ToArray();
+            var exactMethodParamNames = new HashSet<string>(methodParamNames, StringComparer.Ordinal);
             foreach (var key in paramDict.Keys)
             {
-                if (!methodParamNames.Contains(key))
+                if (exactMethodParamNames.Contains(key))
                 {
-                    // Find close matches for a helpful warning
-                    var closest = methodParamNames
-                        .Where(n => n.Equals(key, StringComparison.OrdinalIgnoreCase))
-                        .FirstOrDefault();
-                    var hint = closest != null ? $" Did you mean '{closest}'?" : "";
-                    Trace.TraceWarning($"[ToolRegistry] Tool '{method.Name}': unrecognized parameter '{key}'.{hint} Known parameters: [{string.Join(", ", methodParamNames)}]");
+                    continue;
+                }
+
+                var closest = methodParamNames
+                    .FirstOrDefault(n => n.Equals(key, StringComparison.OrdinalIgnoreCase));
+                if (closest != null)
+                {
+                    continue;
                 }
+
+                Trace.TraceWarning($"[ToolRegistry] Tool '{method.Name}': unrecognized parameter '{key}'. Known parameters: [{string.Join(", ", methodParamNames)}]");
             }
 
             for (int i = 0; i < methodParams.Length; i++)