Release chunk buffer regardless of submit outcome

Move chunk.bytes = null into a finally so a failed submission also
releases its 2 MiB. Today the buffer is only freed on success; on
failure (stall, retry, abort) it stays alive via the closure, pinning
memory for the lifetime of the upload. The payload is re-streamed
from disk on the next attempt, so dropping the in-memory copy is
always safe.

Author: sevenmachines

packages/cli/src/bulletin/store.ts

@@ -788,26 +788,34 @@ export async function storeChunkedFileToBulletin(
           submitChunk: async (chunk) => {
             const nonce = waveNonces.get(chunk.index)!;
 
-            await storeContentOnBulletin({
-              rpc: parameters.rpc,
-              signer: parameters.signer,
-              contentBytes: chunk.bytes,
-              contentCid: chunk.cid,
-              codecValue: CODEC.RAW,
-              hashCodeValue: HASH.SHA2_256,
-              nonce,
-              client: activeClient,
-              waitForFinalization,
-            });
-
-            manifestState.completedBlocks.set(chunk.index, {
-              index: chunk.index,
-              cid: chunk.cid,
-              length: chunk.length,
-            });
-
-            completedChunks += 1;
-            parameters.onProgress?.(chunk.index + 1, totalChunks, "stored");
+            try {
+              await storeContentOnBulletin({
+                rpc: parameters.rpc,
+                signer: parameters.signer,
+                contentBytes: chunk.bytes,
+                contentCid: chunk.cid,
+                codecValue: CODEC.RAW,
+                hashCodeValue: HASH.SHA2_256,
+                nonce,
+                client: activeClient,
+                waitForFinalization,
+              });
+
+              manifestState.completedBlocks.set(chunk.index, {
+                index: chunk.index,
+                cid: chunk.cid,
+                length: chunk.length,
+              });
+
+              completedChunks += 1;
+              parameters.onProgress?.(chunk.index + 1, totalChunks, "stored");
+            } finally {
+              // Release the chunk's 2 MiB Buffer regardless of outcome. On
+              // success it is already persisted; on failure it must not pin
+              // memory while the caller decides whether to retry — the
+              // payload is re-streamed from disk on the next attempt.
+              chunk.bytes = null as unknown as Uint8Array;
+            }
           },
         });