protocol: Ensure the transport manager is informed about closed

connections

Signed-off-by: Alexandru Vasile <[email protected]>

Author: lexnv

src/protocol/protocol_set.rs

@@ -418,19 +418,31 @@ impl ProtocolSet {
             })
             .collect::<FuturesUnordered<_>>();
 
+        // Capture the first error that occurs while reporting to protocols.
+        let mut protocol_error = None;
         while !futures.is_empty() {
-            if let Some(Err(error)) = futures.next().await {
-                return Err(error.into());
+            if let Some(Err(err)) = futures.next().await {
+                if protocol_error.is_none() {
+                    protocol_error = Some(err.into());
+                }
             }
         }
 
+        // Ensure the manager receives the connection closed event. Otherwise, the
+        // manager will think the connection is still open, while the underlying
+        // protocols and raw connection are closed.
         self.mgr_tx
             .send(TransportManagerEvent::ConnectionClosed {
                 peer,
                 connection: connection_id,
             })
-            .await
-            .map_err(From::from)
+            .await?;
+
+        // If any protocol report failed, return that error now
+        match protocol_error {
+            Some(e) => Err(e),
+            None => Ok(()),
+        }
     }
 }