Skip to content

transport: Consider removing the negotiate step from transport trait #498

@lexnv

Description

@lexnv

pub(crate) trait Transport: Stream + Unpin + Send {
/// Dial `address` and negotiate connection.
fn dial(&mut self, connection_id: ConnectionId, address: Multiaddr) -> crate::Result<()>;
/// Accept negotiated connection.
fn accept(&mut self, connection_id: ConnectionId) -> crate::Result<()>;
/// Accept pending connection.
fn accept_pending(&mut self, connection_id: ConnectionId) -> crate::Result<()>;
/// Reject pending connection.
fn reject_pending(&mut self, connection_id: ConnectionId) -> crate::Result<()>;
/// Reject negotiated connection.
fn reject(&mut self, connection_id: ConnectionId) -> crate::Result<()>;
/// Attempt to open connection to remote peer over one or more addresses.
fn open(&mut self, connection_id: ConnectionId, addresses: Vec<Multiaddr>)
-> crate::Result<()>;
/// Negotiate opened connection.
fn negotiate(&mut self, connection_id: ConnectionId) -> crate::Result<()>;
/// Cancel opening connections.
///
/// This is a no-op for connections that have already succeeded/canceled.
fn cancel(&mut self, connection_id: ConnectionId);
}

Extracted from:
#495 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions