fix(e2e): set DEPLOY_TAG so bulletin-deploy spans are tagged as E2E traffic (#128)

The E2E runner already set DOT_TAG for playground-CLI's own Sentry telemetry
but never set DEPLOY_TAG, so bulletin-deploy's deploy-pipeline spans landed in
production telemetry untagged. Use an e2e-cli-* prefix to distinguish
playground-CLI E2E from bulletin-deploy's own E2E suite (which uses bare e2e-*
tags). Respects any explicit DEPLOY_TAG override (e.g. the post-release
workflow's e2e-ci-post-release).

Author: EnderOfWorlds007

CLAUDE.md

@@ -49,7 +49,7 @@ These are things that aren't self-evident from reading the code and have bitten
   - `2216067.json` — **Playground CLI Failures** (per-error-type drill-downs).
   - `2216096.json` — **Playground CLI E2E Health** (inverse filter, `cli.tag:e2e-*`).
 - **Workflow:** run `./sentry/backup-dashboards.sh` BEFORE any change. Use `./sentry/patch-dashboard.py <id> <patch.json>` for surgical edits (supports `replace`, `patch_query`, `set_description` ops) or full widget replacement. Use `./sentry/create-dashboard.py <payload.json>` for new dashboards. Per spec §15f, do NOT include a `projects` field in POST payloads. Per spec §15g, PUT replaces the whole widget list — backup first.
-- **E2E tagging:** every spawn from `e2e/cli/helpers/dot.ts` injects `DOT_TAG=e2e-local` (fallback) and `DOT_TELEMETRY=1`. `tools/e2e-local.sh` overrides that to `e2e-local-{smoke|pr|nightly}` based on the mode argument. CI sets `DOT_TAG=e2e-ci-{pr|nightly|dispatch}` in `.github/workflows/e2e.yml` so production health widgets filter cleanly via `!cli.tag:e2e-*`.
+- **E2E tagging:** every spawn from `e2e/cli/helpers/dot.ts` injects `DOT_TAG=e2e-local` (fallback), `DOT_TELEMETRY=1`, and `DEPLOY_TAG=e2e-cli-local` (derived from `DOT_TAG` with an `e2e-cli-` prefix). `tools/e2e-local.sh` overrides `DOT_TAG` to `e2e-local-{smoke|pr|nightly}`, which makes `DEPLOY_TAG` become `e2e-cli-local-{smoke|pr|nightly}`. CI sets `DOT_TAG=e2e-ci-{pr|nightly|dispatch}`, making `DEPLOY_TAG=e2e-cli-ci-{pr|nightly|dispatch}`. The `e2e-cli-` prefix on `DEPLOY_TAG` distinguishes playground-CLI E2E traffic from bulletin-deploy's own E2E suite (which uses bare `e2e-*` tags) in bulletin-deploy's telemetry dashboards. Production health widgets filter cleanly via `!cli.tag:e2e-*` (playground-CLI's Sentry) and `!deploy.tag:e2e-*` (bulletin-deploy's Sentry).
 - **SAD% propagation** is verified by a regression test in `src/telemetry.test.ts` ("SAD% propagation through transaction envelope"). It confirms `captureWarning` flips `cli.sad="true"` on the root transaction. If that test fails, the SAD% dashboard widget on Dashboard 1 will silently degrade to a duplicate of the unexpected-failure rate.
 
 ## E2E Tests

e2e/cli/helpers/dot.ts

@@ -66,8 +66,15 @@ export async function dotWithSuri(
 // ── Internal ────────────────────────────────────────────────────────────────
 
 async function run(args: string[], options?: DotOptions): Promise<DotResult> {
+	const dotTag = process.env.DOT_TAG ?? "e2e-local";
 	const env: Record<string, string> = {
-		DOT_TAG: process.env.DOT_TAG ?? "e2e-local",
+		DOT_TAG: dotTag,
+		// Forward a bulletin-deploy telemetry tag so deploy-pipeline spans are
+		// tagged as playground-CLI E2E traffic (e2e-cli-*) rather than real-user
+		// traffic. The e2e-cli- prefix distinguishes us from bulletin-deploy's own
+		// E2E suite, which uses bare e2e-* tags. Respect any explicit DEPLOY_TAG
+		// override (e.g. e2e-ci-post-release set by the post-release workflow).
+		DEPLOY_TAG: process.env.DEPLOY_TAG ?? "e2e-cli-" + dotTag.replace(/^e2e-/, ""),
 		DOT_TELEMETRY: process.env.DOT_TELEMETRY ?? "1",
 		...options?.env,
 	};