Fix NoCurrency

Author: raymondkfcheung

pallets/common/src/lib.rs

@@ -19,7 +19,10 @@ use codec::{Decode, Encode};
 use polkadot_sdk_frame::{
 	deps::frame_support,
 	prelude::{
-		fungible::{Dust, Inspect, InspectHold, Mutate, MutateHold, Unbalanced, UnbalancedHold},
+		fungible::{
+			hold::DoneSlash, Balanced, BalancedHold, Dust, Inspect, InspectHold, Mutate,
+			MutateHold, Unbalanced, UnbalancedHold,
+		},
 		DepositConsequence, DispatchError, DispatchResult, Fortitude, Preservation, Provenance,
 		WithdrawConsequence, Zero,
 	},
@@ -40,10 +43,31 @@ pub struct NoCurrency<AccountId, HoldReason = ()>(
 	core::marker::PhantomData<(AccountId, HoldReason)>,
 );
 
+impl<AccountId, HoldReason> Balanced<AccountId> for NoCurrency<AccountId, HoldReason>
+where
+	HoldReason: Encode + Decode + TypeInfo + 'static,
+{
+	type OnDropDebt = ();
+	type OnDropCredit = ();
+}
+
+impl<AccountId, HoldReason> BalancedHold<AccountId> for NoCurrency<AccountId, HoldReason> where
+	HoldReason: Encode + Decode + TypeInfo + 'static
+{
+}
+
+impl<AccountId, HoldReason, Balance> DoneSlash<HoldReason, AccountId, Balance>
+	for NoCurrency<AccountId, HoldReason>
+where
+	Balance: Sized,
+	HoldReason: Encode + Decode + TypeInfo + 'static,
+{
+}
+
 impl<AccountId, HoldReason: Encode + Decode + TypeInfo + 'static> Inspect<AccountId>
 	for NoCurrency<AccountId, HoldReason>
 {
-	type Balance = u128;
+	type Balance = u64;
 
 	fn total_issuance() -> Self::Balance {
 		Zero::zero()

pallets/transaction-storage/src/mock.rs

@@ -18,8 +18,8 @@
 //! Test environment for transaction-storage pallet.
 
 use crate::{
-	self as pallet_transaction_storage, TransactionStorageProof,
-	DEFAULT_MAX_BLOCK_TRANSACTIONS, DEFAULT_MAX_TRANSACTION_SIZE,
+	self as pallet_transaction_storage, TransactionStorageProof, DEFAULT_MAX_BLOCK_TRANSACTIONS,
+	DEFAULT_MAX_TRANSACTION_SIZE,
 };
 use pallets_common::NoCurrency;
 use polkadot_sdk_frame::{prelude::*, runtime::prelude::*, testing_prelude::*};
@@ -54,7 +54,7 @@ parameter_types! {
 impl pallet_transaction_storage::Config for Test {
 	type RuntimeEvent = RuntimeEvent;
 	type RuntimeCall = RuntimeCall;
-	type Currency = NoCurrency<RuntimeHoldReason>;
+	type Currency = NoCurrency<Self::AccountId, RuntimeHoldReason>;
 	type RuntimeHoldReason = RuntimeHoldReason;
 	type WeightInfo = ();
 	type MaxBlockTransactions = ConstU32<{ DEFAULT_MAX_BLOCK_TRANSACTIONS }>;

runtime/src/lib.rs

@@ -346,7 +346,7 @@ impl pallet_sudo::Config for Runtime {
 impl pallet_transaction_storage::Config for Runtime {
 	type RuntimeEvent = RuntimeEvent;
 	type RuntimeCall = RuntimeCall;
-	type Currency = NoCurrency<RuntimeHoldReason>;
+	type Currency = NoCurrency<Self::AccountId, RuntimeHoldReason>;
 	type RuntimeHoldReason = RuntimeHoldReason;
 	type WeightInfo = pallet_transaction_storage::weights::SubstrateWeight<Runtime>;
 	type MaxBlockTransactions = ConstU32<512>;

runtimes/bulletin-polkadot/src/lib.rs

@@ -344,7 +344,7 @@ impl pallet_timestamp::Config for Runtime {
 impl pallet_transaction_storage::Config for Runtime {
 	type RuntimeEvent = RuntimeEvent;
 	type RuntimeCall = RuntimeCall;
-	type Currency = NoCurrency<RuntimeHoldReason>;
+	type Currency = NoCurrency<Self::AccountId, RuntimeHoldReason>;
 	type RuntimeHoldReason = RuntimeHoldReason;
 	type WeightInfo = weights::pallet_transaction_storage::WeightInfo<Runtime>;
 	type MaxBlockTransactions = ConstU32<512>;

runtimes/bulletin-westend/src/storage.rs

@@ -44,7 +44,7 @@ parameter_types! {
 impl pallet_transaction_storage::Config for Runtime {
 	type RuntimeEvent = RuntimeEvent;
 	type RuntimeCall = RuntimeCall;
-	type Currency = NoCurrency<RuntimeHoldReason>;
+	type Currency = NoCurrency<Self::AccountId, RuntimeHoldReason>;
 	type RuntimeHoldReason = RuntimeHoldReason;
 	type WeightInfo = crate::weights::pallet_transaction_storage::WeightInfo<Runtime>;
 	type MaxBlockTransactions = crate::ConstU32<512>;