Improved claude.md (#191)

* added Claude Code reviewer to Bulletin repo

* simplified setup

* added id-token: write

* Update CLAUDE.md

Co-authored-by: Francisco Aguirre <[email protected]>

* Update CLAUDE.md

Co-authored-by: Francisco Aguirre <[email protected]>

* reverted claude code review bot

---------

Co-authored-by: Francisco Aguirre <[email protected]>

Author: x3c41a

.claude/commands/review-pr.md

@@ -0,0 +1,28 @@
+Review pull request #$ARGUMENTS
+
+Fetch the PR diff and details using `gh pr view` and `gh pr diff`, then analyze for:
+
+1. **Code Quality**
+   - Rust idioms and Polkadot SDK patterns
+   - Error handling and unwrap usage
+   - Code clarity and maintainability
+
+2. **Security**
+   - Unsafe code blocks
+   - Input validation
+   - Access control in pallets
+
+3. **Performance**
+   - Weight/benchmark implications
+   - Storage access patterns
+   - Unnecessary allocations
+
+4. **Testing**
+   - Test coverage for new code
+   - Edge cases handled
+
+5. **Breaking Changes**
+   - API compatibility
+   - Migration requirements
+
+Provide specific feedback with file paths and line numbers.

CLAUDE.md

@@ -153,3 +153,54 @@ The Polkadot SDK provides:
 - IPFS idle connection timeout: 1 hour
 - Node supports litep2p/Bitswap
 - Solochain validators need BABE and GRANDPA session keys
+
+## Code Review Guidelines (Parity Standards)
+
+These guidelines are used by the Claude Code review bot and should be followed by all contributors.
+
+### Rust Code Quality
+
+- **Error Handling**: Use `Result` types with meaningful error enums. Avoid `unwrap()` and `expect()` in production code; they are acceptable in tests.
+- **Arithmetic Safety**: Use `checked_*`, `saturating_*`, or `wrapping_*` arithmetic to prevent overflow. Never use raw arithmetic operators on user-provided values.
+- **Naming**: Follow Rust naming conventions (snake_case for functions/variables, CamelCase for types).
+- **Complexity**: Prefer simple, readable code. Avoid over-engineering and premature abstractions.
+
+### FRAME Pallet Standards
+
+- **Storage**: Use appropriate storage types (`StorageValue`, `StorageMap`, `StorageDoubleMap`, `CountedStorageMap`).
+- **Events**: Emit events for all state changes that external observers need to track.
+- **Errors**: Define descriptive error types in the pallet's `Error` enum.
+- **Weights**: All extrinsics must have accurate weight annotations. Update benchmarks when logic changes.
+- **Origins**: Use the principle of least privilege for origin checks.
+- **Hooks**: Be cautious with `on_initialize` and `on_finalize`; they affect block production time in solochains and can brick parachains. Never panic or do unbounded iteration in them. Always benchmark them properly.
+
+### Security Considerations
+
+- **No Panics in Runtime**: Runtime code must never panic. Use defensive programming.
+- **Bounded Collections**: Use `BoundedVec`, `BoundedBTreeMap` etc. to prevent unbounded storage growth.
+- **Input Validation**: Validate all user inputs at the entry point.
+- **Storage Deposits**: Consider requiring deposits for user-created storage items that are returned once the item is cleared.
+
+### Testing Requirements
+
+- **Unit Tests**: All new functionality requires unit tests.
+- **Edge Cases**: Test boundary conditions, error paths, and malicious inputs.
+- **Integration Tests**: Complex features should have integration tests using `sp-io::TestExternalities`.
+- **Benchmark Tests**: Features affecting weights should have benchmark tests.
+
+### PR Requirements
+
+- **Single Responsibility**: Each PR should address one concern.
+- **Tests Pass**: All CI checks must pass (`cargo test`, `cargo clippy`, `cargo fmt`).
+- **No Warnings**: Code should compile without warnings.
+- **Documentation**: Public APIs require rustdoc comments.
+
+### Using the Claude Review Bot
+
+The repository has a Claude Code review bot that automatically reviews PRs. You can also interact with it:
+
+- **@claude** - Mention in any comment to ask questions or request help
+- **Assign to claude[bot]** - Assign an issue to have Claude analyze and propose solutions
+- **Label with `claude`** - Add the `claude` label to an issue for Claude to investigate
+
+The bot enforces these guidelines and provides actionable feedback with fix suggestions.

examples/api.js

@@ -83,7 +83,7 @@ export const TX_MODE_IN_BLOCK = "in-block";
 export const TX_MODE_FINALIZED_BLOCK = "finalized-block";
 export const TX_MODE_IN_POOL = "in-tx-pool";
 
-const DEFAULT_TX_TIMEOUT_MS = 60_000; // 60 seconds or 10 blocks
+const DEFAULT_TX_TIMEOUT_MS = 120_000; // 120 seconds or 20 blocks
 
 const TX_MODE_CONFIG = {
     [TX_MODE_IN_BLOCK]: {