Merge branch 'main' into ak-add-polkadot-parachain-2

Author: franciscoaguirre

.claude/commands/review-pr.md

@@ -0,0 +1,28 @@
+Review pull request #$ARGUMENTS
+
+Fetch the PR diff and details using `gh pr view` and `gh pr diff`, then analyze for:
+
+1. **Code Quality**
+   - Rust idioms and Polkadot SDK patterns
+   - Error handling and unwrap usage
+   - Code clarity and maintainability
+
+2. **Security**
+   - Unsafe code blocks
+   - Input validation
+   - Access control in pallets
+
+3. **Performance**
+   - Weight/benchmark implications
+   - Storage access patterns
+   - Unnecessary allocations
+
+4. **Testing**
+   - Test coverage for new code
+   - Edge cases handled
+
+5. **Breaking Changes**
+   - API compatibility
+   - Migration requirements
+
+Provide specific feedback with file paths and line numbers.

.github/workflows/check.yml

@@ -146,4 +146,9 @@ jobs:
         run: |
           cargo test -p bulletin-westend-runtime
 
+      - name: Run (Westend) XCM integration tests
+        run: |
+          unset SKIP_WASM_BUILD
+          cargo test -p bulletin-westend-integration-tests
+
       # TODO: check benchmarks

.github/workflows/integration-test.yml

@@ -19,6 +19,7 @@ concurrency:
 env:
   NODE_VERSION: 22
   POLKADOT_SDK_VERSION: polkadot-stable2512
+  POLKADOT_SDK_COMMIT: 81a3af9830ea8b6ff64b066b73b04bb3b675add5
   POLKADOT_SDK_BIN_DIR: ${{ github.workspace }}/.polkadot-sdk-bin
   ZOMBIENET_VERSION: v1.3.138
   ZOMBIENET_BIN_DIR: ${{ github.workspace }}/.zombienet-bin
@@ -52,7 +53,7 @@ jobs:
         id: polkadot-sdk-cache
         with:
           path: ${{ env.POLKADOT_SDK_BIN_DIR }}
-          key: polkadot-sdk-${{ env.POLKADOT_SDK_VERSION }}-binaries
+          key: polkadot-sdk-${{ env.POLKADOT_SDK_VERSION }}-${{ env.POLKADOT_SDK_COMMIT }}-binaries
       # Download and extract binaries if cache missed
       - name: Download Polkadot SDK binaries
         if: steps.polkadot-sdk-cache.outputs.cache-hit != 'true'
@@ -70,7 +71,7 @@ jobs:
           # TODO: remove when released: https://github.com/paritytech/polkadot-sdk/pull/10662
           git clone https://github.com/paritytech/polkadot-sdk.git
           cd polkadot-sdk
-          git reset --hard b2bcb74b13f1a1e082f701e3e05ce1be44d16790
+          git reset --hard $POLKADOT_SDK_COMMIT
           cargo build -p polkadot-omni-node -r
           cd ..
           cp polkadot-sdk/target/release/polkadot-omni-node .
@@ -139,7 +140,7 @@ jobs:
         id: polkadot-sdk-cache
         with:
           path: ${{ env.POLKADOT_SDK_BIN_DIR }}
-          key: polkadot-sdk-${{ env.POLKADOT_SDK_VERSION }}-binaries
+          key: polkadot-sdk-${{ env.POLKADOT_SDK_VERSION }}-${{ env.POLKADOT_SDK_COMMIT }}-binaries
       - name: Cache Zombienet
         uses: actions/cache@v3
         id: zombienet-cache
@@ -181,6 +182,10 @@ jobs:
         working-directory: examples
         run: just run-test-store-big-data "${{ env.TEST_DIR }}"
 
+      - name: Test authorize-preimage-and-store (Westend parachain)
+        working-directory: examples
+        run: just run-test-authorize-preimage-and-store "${{ env.TEST_DIR }}"
+
       - name: Stop services (Westend parachain)
         if: always()
         working-directory: examples
@@ -212,6 +217,10 @@ jobs:
         working-directory: examples
         run: just run-test-store-big-data "${{ env.TEST_DIR }}"
 
+      - name: Test authorize-preimage-and-store (Polkadot solochain)
+        working-directory: examples
+        run: just run-test-authorize-preimage-and-store "${{ env.TEST_DIR }}"
+
       - name: Stop services (Polkadot solochain)
         if: always()
         working-directory: examples

.github/workflows/release.yml

@@ -17,6 +17,9 @@ jobs:
           - name: bulletin-westend
             package: bulletin-westend-runtime
             path: runtimes/bulletin-westend
+          - name: bulletin-paseo
+            package: bulletin-westend-runtime
+            path: runtimes/bulletin-westend
           - name: bulletin-polkadot
             package: bulletin-polkadot-runtime
             path: runtimes/bulletin-polkadot

.gitignore

@@ -19,6 +19,5 @@ package-lock.json
 .papi/
 
 # Local test files
-examples/retrieved_picture.*
 kubo/
 zombienet-*

CLAUDE.md

@@ -48,6 +48,8 @@ cargo clippy --all-targets --all-features --workspace -- -D warnings
 
 # Format check
 cargo +nightly fmt --all -- --check
+taplo format --config .config/taplo.toml
+zepter run --config .config/zepter.yaml
 ```
 
 ## Run Commands
@@ -153,3 +155,55 @@ The Polkadot SDK provides:
 - IPFS idle connection timeout: 1 hour
 - Node supports litep2p/Bitswap
 - Solochain validators need BABE and GRANDPA session keys
+
+## Code Review Guidelines (Parity Standards)
+
+These guidelines are used by the Claude Code review bot and should be followed by all contributors.
+
+### Rust Code Quality
+
+- **Error Handling**: Use `Result` types with meaningful error enums. Avoid `unwrap()` and `expect()` in production code; they are acceptable in tests.
+- **Arithmetic Safety**: Use `checked_*`, `saturating_*`, or `wrapping_*` arithmetic to prevent overflow. Never use raw arithmetic operators on user-provided values.
+- **Naming**: Follow Rust naming conventions (snake_case for functions/variables, CamelCase for types).
+- **Complexity**: Prefer simple, readable code. Avoid over-engineering and premature abstractions.
+- **No useless comments**: Comments should mostly explain **why** things are done, not **how**, the code should be readable enough to explain the how.
+
+### FRAME Pallet Standards
+
+- **Storage**: Use appropriate storage types (`StorageValue`, `StorageMap`, `StorageDoubleMap`, `CountedStorageMap`).
+- **Events**: Emit events for all state changes that external observers need to track.
+- **Errors**: Define descriptive error types in the pallet's `Error` enum.
+- **Weights**: All extrinsics must have accurate weight annotations. Update benchmarks when logic changes.
+- **Origins**: Use the principle of least privilege for origin checks.
+- **Hooks**: Be cautious with `on_initialize` and `on_finalize`; they affect block production time in solochains and can brick parachains. Never panic or do unbounded iteration in them. Always benchmark them properly.
+
+### Security Considerations
+
+- **No Panics in Runtime**: Runtime code must never panic. Use defensive programming.
+- **Bounded Collections**: Use `BoundedVec`, `BoundedBTreeMap` etc. to prevent unbounded storage growth.
+- **Input Validation**: Validate all user inputs at the entry point.
+- **Storage Deposits**: Consider requiring deposits for user-created storage items that are returned once the item is cleared.
+
+### Testing Requirements
+
+- **Unit Tests**: All new functionality requires unit tests.
+- **Edge Cases**: Test boundary conditions, error paths, and malicious inputs.
+- **Integration Tests**: Complex features should have integration tests using `sp-io::TestExternalities`.
+- **Benchmark Tests**: Features affecting weights should have benchmark tests.
+
+### PR Requirements
+
+- **Single Responsibility**: Each PR should address one concern.
+- **Tests Pass**: All CI checks must pass (`cargo test`, `cargo clippy`, `cargo fmt`).
+- **No Warnings**: Code should compile without warnings.
+- **Documentation**: Public APIs require rustdoc comments.
+
+### Using the Claude Review Bot
+
+The repository has a Claude Code review bot that automatically reviews PRs. You can also interact with it:
+
+- **@claude** - Mention in any comment to ask questions or request help
+- **Assign to claude[bot]** - Assign an issue to have Claude analyze and propose solutions
+- **Label with `claude`** - Add the `claude` label to an issue for Claude to investigate
+
+The bot enforces these guidelines and provides actionable feedback with fix suggestions.