Skip to content

Commit e404dc4

Browse files
committed
Refactor justfile: extract scripts, improve process tracking, organize logs
- Extract setup-westend-prerequisites to separate shell script - Use PID files for safe process cleanup (avoid killing unrelated processes) - Move all logs to ZOMBIENET_DIR for better organization - Use justfile_directory() for cleaner path resolution - Fix zombienet PID capture by avoiding subshells - Move verification logic into bulletin-solo-zombienet-start
1 parent 7da6f9c commit e404dc4

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

examples/justfile

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -116,17 +116,21 @@ bulletin-solo-zombienet-start runtime="bulletin-polkadot-runtime":
116116

117117
# Run zombienet from root directory so relative paths in config work correctly
118118
mkdir -p {{ ZOMBIENET_DIR }}
119-
(cd "$ROOT_DIR" && POLKADOT_BINARY_PATH=$POLKADOT_BINARY_PATH \
119+
cd "$ROOT_DIR"
120+
POLKADOT_BINARY_PATH=$POLKADOT_BINARY_PATH \
120121
POLKADOT_PARACHAIN_BINARY_PATH=$POLKADOT_PARACHAIN_BINARY_PATH \
121-
$ZOMBIENET_BIN -p native spawn --dir {{ ZOMBIENET_DIR }} "$ROOT_DIR/zombienet/bulletin-westend-local.toml" > {{ ZOMBIENET_DIR }}/zombienet.log 2>&1) &
122+
$ZOMBIENET_BIN -p native spawn --dir {{ ZOMBIENET_DIR }} "$ROOT_DIR/zombienet/bulletin-westend-local.toml" > {{ ZOMBIENET_DIR }}/zombienet.log 2>&1 &
123+
cd -
122124
else # bulletin-polkadot-runtime
123125
echo " Setting up Polkadot runtime..."
124126
ROOT_DIR="{{ justfile_directory() }}/.."
125127
# Build the node binary (which will build the runtime as a dependency)
126128
cargo build --release -p polkadot-bulletin-chain
127129
mkdir -p {{ ZOMBIENET_DIR }}
128-
(cd "$ROOT_DIR" && POLKADOT_BULLETIN_BINARY_PATH="$ROOT_DIR/target/release/polkadot-bulletin-chain" \
129-
$ZOMBIENET_BIN -p native spawn --dir {{ ZOMBIENET_DIR }} "$ROOT_DIR/zombienet/bulletin-polkadot-local.toml" > {{ ZOMBIENET_DIR }}/zombienet.log 2>&1) &
130+
cd "$ROOT_DIR"
131+
POLKADOT_BULLETIN_BINARY_PATH="$ROOT_DIR/target/release/polkadot-bulletin-chain" \
132+
$ZOMBIENET_BIN -p native spawn --dir {{ ZOMBIENET_DIR }} "$ROOT_DIR/zombienet/bulletin-polkadot-local.toml" > {{ ZOMBIENET_DIR }}/zombienet.log 2>&1 &
133+
cd -
130134
fi
131135
ZOMBIENET_PID=$!
132136
echo $ZOMBIENET_PID > {{ PID_DIR }}/zombienet.pid

0 commit comments

Comments
 (0)