More nits #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

bkontur merged 39 commits into parametrise_tests from parametrise_tests2

Jan 30, 2026

.github/workflows/integration-test.yml

-Original file line number
+Diff line change
@@ Expand Up / @@ -162,7 +162,7 @@ jobs: @@
           - name: Test store-big-data (Westend parachain)
             working-directory: examples
-            run: just run-test-store-big-data "${{ env.TEST_DIR }}"
+            run: just run-test-store-big-data "${{ env.TEST_DIR }}" "big32"
           - name: Test authorize-preimage-and-store (Westend parachain)
             working-directory: examples
@@ Expand Down Expand Up / @@ -197,7 +197,7 @@ jobs: @@
           - name: Test store-big-data (Polkadot solochain)
             working-directory: examples
-            run: just run-test-store-big-data "${{ env.TEST_DIR }}"
+            run: just run-test-store-big-data "${{ env.TEST_DIR }}" "big32"
           - name: Test authorize-preimage-and-store (Polkadot solochain)
             working-directory: examples
@@ Expand Down @@

examples/README.md

            
                      Original file line number
                      Diff line number
                      Diff line change
                  
    @@ -79,7 +79,7 @@ tar -xvzf kubo_v0.38.1_darwin-arm64.tar.gz
  
    ```shell

    docker pull ipfs/kubo:latest

    docker run -d --name ipfs-node -v ipfs-data:/data/ipfs -p 4001:4001 -p 8080:8080 -p 5001:5001 ipfs/kubo:latest

    docker run -d --name ipfs-node -v ipfs-data:/data/ipfs -p 4011:4011 -p 8283:8283 -p 5011:5011 ipfs/kubo:latest

    docker logs -f ipfs-node

    ```

examples/authorize_and_store_papi.js

            
                      Original file line number
                      Diff line number
                      Diff line change
                  
    @@ -3,7 +3,7 @@ import { createClient } from 'polkadot-api';
  
    import { getWsProvider } from 'polkadot-api/ws-provider';

    import { cryptoWaitReady } from '@polkadot/util-crypto';

    import { authorizeAccount, fetchCid, store, TX_MODE_FINALIZED_BLOCK } from './api.js';

    import { setupKeyringAndSigners } from './common.js';

    import { setupKeyringAndSigners, DEFAULT_IPFS_GATEWAY_URL } from './common.js';

    import { logHeader, logConnection, logSuccess, logError, logTestResult } from './logger.js';

    import { cidFromBytes } from "./cid_dag_metadata.js";

    import { bulletin } from './.papi/descriptors/dist/index.mjs';

    @@ -12,7 +12,7 @@ import { bulletin } from './.papi/descriptors/dist/index.mjs';
  
    const args = process.argv.slice(2);

    const NODE_WS = args[0] || 'ws://localhost:10000';

    const SEED = args[1] || '//Alice';

    const HTTP_IPFS_API = args[2] || 'http://127.0.0.1:8080';

    const HTTP_IPFS_API = args[2] || DEFAULT_IPFS_GATEWAY_URL;

    async function main() {

        await cryptoWaitReady();

examples/authorize_and_store_papi_smoldot.js

            
                      Original file line number
                      Diff line number
                      Diff line change
                  
    @@ -5,7 +5,7 @@ import { createClient } from 'polkadot-api';
  
    import { getSmProvider } from 'polkadot-api/sm-provider';

    import { cryptoWaitReady } from '@polkadot/util-crypto';

    import { authorizeAccount, fetchCid, store } from './api.js';

    import { setupKeyringAndSigners, waitForChainReady } from './common.js';

    import { setupKeyringAndSigners, waitForChainReady, DEFAULT_IPFS_GATEWAY_URL } from './common.js';

    import { logHeader, logConfig, logSuccess, logError, logTestResult } from './logger.js';

    import { cidFromBytes } from "./cid_dag_metadata.js";

    import { bulletin } from './.papi/descriptors/dist/index.mjs';

    @@ -111,7 +111,7 @@ async function main() {
  
        // Optional parachain chainspec path (only needed for parachains)

        const parachainSpecPath = process.argv[3] || null;

        // Optional IPFS API URL

        const HTTP_IPFS_API = process.argv[4] || 'http://127.0.0.1:8080';

        const HTTP_IPFS_API = process.argv[4] || DEFAULT_IPFS_GATEWAY_URL;

        logConfig({

            'Mode': 'Smoldot Light Client',

examples/authorize_preimage_and_store_papi.js

            
                      Original file line number
                      Diff line number
                      Diff line change
                  
    @@ -3,7 +3,7 @@ import { createClient } from 'polkadot-api';
  
    import { getWsProvider } from 'polkadot-api/ws-provider';

    import { cryptoWaitReady } from '@polkadot/util-crypto';

    import { authorizeAccount, authorizePreimage, fetchCid, store, TX_MODE_IN_BLOCK, TX_MODE_FINALIZED_BLOCK } from './api.js';

    import { setupKeyringAndSigners, getContentHash } from './common.js';

    import { setupKeyringAndSigners, getContentHash, DEFAULT_IPFS_GATEWAY_URL } from './common.js';

    import { logHeader, logConnection, logSection, logSuccess, logError, logInfo, logTestResult } from './logger.js';

    import { cidFromBytes } from "./cid_dag_metadata.js";

    import { bulletin } from './.papi/descriptors/dist/index.mjs';

    @@ -12,7 +12,7 @@ import { bulletin } from './.papi/descriptors/dist/index.mjs';
  
    const args = process.argv.slice(2);

    const NODE_WS = args[0] || 'ws://localhost:10000';

    const SEED = args[1] || '//Alice';

    const HTTP_IPFS_API = args[2] || 'http://127.0.0.1:8080';

    const HTTP_IPFS_API = args[2] || DEFAULT_IPFS_GATEWAY_URL;

    /**

     * Run a preimage authorization + store test.

examples/common.js

            
                      Original file line number
                      Diff line number
                      Diff line change
                  
    @@ -6,7 +6,8 @@ import fs from "fs";
  
    import assert from "assert";

    // ---- CONFIG ----

    export const HTTP_IPFS_API = 'http://127.0.0.1:8080';   // Local IPFS HTTP gateway

    export const DEFAULT_IPFS_API_URL = 'http://127.0.0.1:5011';     // IPFS HTTP API (for ipfs-http-client)

    export const DEFAULT_IPFS_GATEWAY_URL = 'http://127.0.0.1:8283'; // IPFS HTTP Gateway (for /ipfs/CID requests)

    export const CHUNK_SIZE = 1 * 1024 * 1024; // 1 MiB

    // -----------------

    @@ -47,7 +48,7 @@ export function newSigner(seed) {
  
     *

     * @param {string} file

     * @param {string} text

     * @param {"small" | "big32" | "big64"} size

     * @param {"small" | "big32" | "big64" | "big96"} size

     */

    export function generateTextImage(file, text, size = "small") {

        console.log(`Generating ${size} image with text: ${text} to the file: ${file}...`);

    @@ -77,6 +78,15 @@ export function generateTextImage(file, text, size = "small") {
  
                noise: 50,

                targetBytes: 65 * 1024 * 1024,

            },

            // ~96 MiB

            big96: {

                width: 9000,

                height: 6500,

                quality: 0.95,

                shapes: 1000,

                noise: 50,

                targetBytes: 98 * 1024 * 1024,

            },

        };

        const cfg = presets[size];

    @@ -117,7 +127,7 @@ export function generateTextImage(file, text, size = "small") {
  
        // 🔧 Big images: tune quality to hit target size

        let imageBytes;

        if ((size === "big32" || size === "big64") && cfg.targetBytes) {

        if ((size === "big32" || size === "big64" || size === "big96") && cfg.targetBytes) {

            let quality = cfg.quality;

            do {

    @@ -271,7 +281,7 @@ export function toHex(bytes) {
  
    //         console.error("Unknown command:", command);

    //         console.error("Usage:");

    //         console.error(

    //             '  node common.js generateTextImage "TEXT" [small|big32|big64]'

    //             '  node common.js generateTextImage "TEXT" [small|big32|big64|big96]'

    //         );

    //         process.exit(1);

    // }

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

More nits #209

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Uh oh!

Uh oh!