get rid of transmute from instructions/arithmetic/i256.rs

0xRVE · 0xRVE · commit 04da5f55207d · 2026-01-27T22:32:15.000+01:00
diff --git a/substrate/frame/revive/src/vm/evm/instructions/arithmetic/i256.rs b/substrate/frame/revive/src/vm/evm/instructions/arithmetic/i256.rs
@@ -27,7 +27,6 @@ pub enum Sign {
 	Minus = -1,
 	/// Zero value sign
 	Zero = 0,
-	#[allow(dead_code)] // "constructed" with `mem::transmute` in `i256_sign` below
 	/// Positive value sign
 	Plus = 1,
 }
@@ -43,9 +42,10 @@ const FLIPH_BITMASK_U64: u64 = 0x7FFF_FFFF_FFFF_FFFF;
 pub fn i256_sign(val: &U256) -> Sign {
 	if val.bit(255) {
 		Sign::Minus
+	} else if val.is_zero() {
+		Sign::Zero
 	} else {
-		// SAFETY: false == 0 == Zero, true == 1 == Plus
-		unsafe { core::mem::transmute::<bool, Sign>(!val.is_zero()) }
+		Sign::Plus
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,6 @@ pub enum Sign {`
`27`	`27`	`Minus = -1,`
`28`	`28`	`/// Zero value sign`
`29`	`29`	`Zero = 0,`
`30`		- #[allow(dead_code)] // "constructed" with `mem::transmute` in `i256_sign` below
`31`	`30`	`/// Positive value sign`
`32`	`31`	`Plus = 1,`
`33`	`32`	`}`
`@@ -43,9 +42,10 @@ const FLIPH_BITMASK_U64: u64 = 0x7FFF_FFFF_FFFF_FFFF;`
`43`	`42`	`pub fn i256_sign(val: &U256) -> Sign {`
`44`	`43`	`if val.bit(255) {`
`45`	`44`	`Sign::Minus`
	`45`	`+ } else if val.is_zero() {`
	`46`	`+ Sign::Zero`
`46`	`47`	`} else {`
`47`		`- // SAFETY: false == 0 == Zero, true == 1 == Plus`
`48`		`- unsafe { core::mem::transmute::<bool, Sign>(!val.is_zero()) }`
	`48`	`+ Sign::Plus`
`49`	`49`	`}`
`50`	`50`	`}`
`51`	`51`