fix lint

Author: pgherveou

substrate/frame/revive/rpc/examples/deploy.rs

@@ -39,7 +39,7 @@ async fn main() -> anyhow::Result<()> {
 	println!("\n\n=== Deploying contract ===\n\n");
 
 	let nonce = client.get_transaction_count(account.address(), BlockTag::Latest.into()).await?;
-	let tx = TransactionBuilder::new(&client)
+	let tx = TransactionBuilder::new(client.clone())
 		.value(5_000_000_000_000u128.into())
 		.input(input)
 		.send()
@@ -65,7 +65,7 @@ async fn main() -> anyhow::Result<()> {
 	}
 
 	println!("\n\n=== Calling contract ===\n\n");
-	let tx = TransactionBuilder::new(&client)
+	let tx = TransactionBuilder::new(client.clone())
 		.value(U256::from(1_000_000u32))
 		.to(contract_address)
 		.send()

substrate/frame/revive/rpc/examples/eth-rpc-tester.rs

@@ -141,7 +141,7 @@ async fn test_eth_rpc(rpc_url: &str) -> anyhow::Result<()> {
 	println!("-  balance: {balance:?}");
 
 	println!("\n\n=== Deploying dummy contract ===\n\n");
-	let tx = TransactionBuilder::new(&client).input(input).send().await?;
+	let tx = TransactionBuilder::new(client.clone()).input(input).send().await?;
 
 	println!("Hash: {:?}", tx.hash());
 	println!("Waiting for receipt...");
@@ -156,7 +156,7 @@ async fn test_eth_rpc(rpc_url: &str) -> anyhow::Result<()> {
 	println!("- Address:      {contract_address:?}");
 
 	println!("\n\n=== Calling dummy contract ===\n\n");
-	let tx = TransactionBuilder::new(&client).to(contract_address).send().await?;
+	let tx = TransactionBuilder::new(client.clone()).to(contract_address).send().await?;
 
 	println!("Hash: {:?}", tx.hash());
 	println!("Waiting for receipt...");

substrate/frame/revive/rpc/examples/transfer.rs

@@ -39,7 +39,7 @@ async fn main() -> anyhow::Result<()> {
 	print_balance().await?;
 	println!("\n\n=== Transferring  ===\n\n");
 
-	let tx = TransactionBuilder::new(&client)
+	let tx = TransactionBuilder::new(client.clone())
 		.signer(alith)
 		.value(value)
 		.to(ethan.address())

substrate/frame/revive/rpc/examples/tx-types.rs

@@ -35,7 +35,7 @@ async fn main() -> anyhow::Result<()> {
 	] {
 		println!("\n\n=== TransactionType {tx_type:?}  ===\n\n",);
 
-		let tx = TransactionBuilder::new(&client)
+		let tx = TransactionBuilder::new(client.clone())
 			.signer(alith.clone())
 			.value(value)
 			.to(ethan.address())

substrate/frame/revive/rpc/src/example.rs

@@ -88,9 +88,9 @@ impl<Client: EthRpcClient + Sync + Send> SubmittedTransaction<Client> {
 }
 
 impl<Client: EthRpcClient + Send + Sync> TransactionBuilder<Client> {
-	pub fn new(client: &Arc<Client>) -> Self {
+	pub fn new(client: Arc<Client>) -> Self {
 		Self {
-			client: Arc::clone(client),
+			client,
 			signer: Account::default(),
 			value: U256::zero(),
 			input: Bytes::default(),

substrate/frame/revive/rpc/src/tests.rs

@@ -132,7 +132,7 @@ async fn prepare_evm_transactions<Client: EthRpcClient + Sync + Send>(
 	let mut transactions = Vec::new();
 	for i in (0..count).rev() {
 		let nonce = start_nonce.saturating_add(U256::from(i as u64));
-		let tx_builder = TransactionBuilder::new(client)
+		let tx_builder = TransactionBuilder::new(Arc::clone(client))
 			.signer(signer.clone())
 			.nonce(nonce)
 			.value(amount)
@@ -309,7 +309,11 @@ async fn test_transfer(client: Arc<WsClient>) -> anyhow::Result<()> {
 	let initial_balance = client.get_balance(ethan.address(), BlockTag::Latest.into()).await?;
 
 	let value = 1_000_000_000_000_000_000_000u128.into();
-	let tx = TransactionBuilder::new(&client).value(value).to(ethan.address()).send().await?;
+	let tx = TransactionBuilder::new(client.clone())
+		.value(value)
+		.to(ethan.address())
+		.send()
+		.await?;
 
 	let receipt = tx.wait_for_receipt().await?;
 	assert_eq!(
@@ -335,7 +339,11 @@ async fn test_deploy_and_call(client: Arc<WsClient>) -> anyhow::Result<()> {
 	let ethan = Account::from(subxt_signer::eth::dev::ethan());
 	let initial_balance = client.get_balance(ethan.address(), BlockTag::Latest.into()).await?;
 	let value = 1_000_000_000_000_000_000_000u128.into();
-	let tx = TransactionBuilder::new(&client).value(value).to(ethan.address()).send().await?;
+	let tx = TransactionBuilder::new(client.clone())
+		.value(value)
+		.to(ethan.address())
+		.send()
+		.await?;
 
 	let receipt = tx.wait_for_receipt().await?;
 	assert_eq!(
@@ -358,7 +366,7 @@ async fn test_deploy_and_call(client: Arc<WsClient>) -> anyhow::Result<()> {
 	let (bytes, _) = pallet_revive_fixtures::compile_module("dummy")?;
 	let input = bytes.into_iter().chain(data.clone()).collect::<Vec<u8>>();
 	let nonce = client.get_transaction_count(account.address(), BlockTag::Latest.into()).await?;
-	let tx = TransactionBuilder::new(&client).value(value).input(input).send().await?;
+	let tx = TransactionBuilder::new(client.clone()).value(value).input(input).send().await?;
 	let receipt = tx.wait_for_receipt().await?;
 	let contract_address = create1(&account.address(), nonce.try_into().unwrap());
 	assert_eq!(
@@ -379,7 +387,7 @@ async fn test_deploy_and_call(client: Arc<WsClient>) -> anyhow::Result<()> {
 	);
 
 	// Call contract
-	let tx = TransactionBuilder::new(&client)
+	let tx = TransactionBuilder::new(client.clone())
 		.value(value)
 		.to(contract_address)
 		.send()
@@ -397,7 +405,7 @@ async fn test_deploy_and_call(client: Arc<WsClient>) -> anyhow::Result<()> {
 
 	// Balance transfer to contract
 	let initial_balance = client.get_balance(contract_address, BlockTag::Latest.into()).await?;
-	let tx = TransactionBuilder::new(&client)
+	let tx = TransactionBuilder::new(client.clone())
 		.value(value)
 		.to(contract_address)
 		.send()
@@ -448,7 +456,7 @@ async fn test_runtime_api_dry_run_addr_works(client: Arc<WsClient>) -> anyhow::R
 async fn test_invalid_transaction(client: Arc<WsClient>) -> anyhow::Result<()> {
 	let ethan = Account::from(subxt_signer::eth::dev::ethan());
 
-	let err = TransactionBuilder::new(&client)
+	let err = TransactionBuilder::new(client.clone())
 		.value(U256::from(1_000_000_000_000u128))
 		.to(ethan.address())
 		.mutate(|tx| match tx {
@@ -492,7 +500,7 @@ async fn test_evm_blocks_should_match(client: Arc<WsClient>) -> anyhow::Result<(
 	// Deploy a contract to have some interesting blocks
 	let (bytes, _) = pallet_revive_fixtures::compile_module("dummy")?;
 	let value = U256::from(5_000_000_000_000u128);
-	let tx = TransactionBuilder::new(&client)
+	let tx = TransactionBuilder::new(client.clone())
 		.value(value)
 		.input(bytes.to_vec())
 		.send()
@@ -536,7 +544,7 @@ async fn test_evm_blocks_hydrated_should_match(client: Arc<WsClient>) -> anyhow:
 	let value = U256::from(5_000_000_000_000u128);
 	let signer = Account::default();
 	let signer_copy = Account::default();
-	let tx = TransactionBuilder::new(&client)
+	let tx = TransactionBuilder::new(client.clone())
 		.value(value)
 		.signer(signer)
 		.input(bytes.to_vec())
@@ -589,7 +597,7 @@ async fn test_block_hash_for_tag_with_proper_ethereum_block_hash_works(
 	// Deploy a transaction to create a block with transactions
 	let (bytes, _) = pallet_revive_fixtures::compile_module("dummy")?;
 	let value = U256::from(5_000_000_000_000u128);
-	let tx = TransactionBuilder::new(&client)
+	let tx = TransactionBuilder::new(client.clone())
 		.value(value)
 		.input(bytes.to_vec())
 		.send()
@@ -764,7 +772,7 @@ async fn test_runtime_pallets_address_upload_code(client: Arc<WsClient>) -> anyh
 	let encoded_call = node_client.tx().call_data(&upload_call)?;
 
 	// Step 2: Send the encoded call to RUNTIME_PALLETS_ADDR
-	let tx = TransactionBuilder::new(&client)
+	let tx = TransactionBuilder::new(client.clone())
 		.signer(signer.clone())
 		.to(pallet_revive::RUNTIME_PALLETS_ADDR)
 		.input(encoded_call.clone())
@@ -803,12 +811,12 @@ async fn test_fibonacci_large_value_runs_out_of_gas(client: Arc<WsClient>) -> an
 
 	let account = Account::default();
 	let nonce = client.get_transaction_count(account.address(), BlockTag::Latest.into()).await?;
-	let tx = TransactionBuilder::new(&client).input(bytes.to_vec()).send().await?;
+	let tx = TransactionBuilder::new(client.clone()).input(bytes.to_vec()).send().await?;
 	let receipt = tx.wait_for_receipt().await?;
 	let contract_address = create1(&account.address(), nonce.try_into().unwrap());
 	assert_eq!(Some(contract_address), receipt.contract_address);
 
-	let result = TransactionBuilder::new(&client)
+	let result = TransactionBuilder::new(client.clone())
 		.to(contract_address)
 		.input(Fibonacci::fibCall { n: 100u64 }.abi_encode())
 		.eth_call()