More review comments

Author: sigurpol

cumulus/parachains/runtimes/assets/asset-hub-westend/tests/tests.rs

@@ -2094,31 +2094,31 @@ fn session_keys_are_compatible_between_ah_and_rc() {
 #[test]
 fn burn_redirects_to_dap_buffer() {
 	ExtBuilder::<Runtime>::default().build().execute_with(|| {
-			let user: AccountId = BOB.into();
-			let initial_balance = 100 * UNITS;
-			let burn_amount = 10 * UNITS;
+		let user: AccountId = BOB.into();
+		let initial_balance = 100 * UNITS;
+		let burn_amount = 10 * UNITS;
 
-			// Given: user has initial balance and DAP buffer exists with ED.
-			assert_ok!(Balances::mint_into(&user, initial_balance));
+		// Given: user has initial balance and DAP buffer exists with ED.
+		assert_ok!(Balances::mint_into(&user, initial_balance));
 
-			let dap_buffer = Dap::buffer_account();
-			let initial_dap_balance = Balances::free_balance(&dap_buffer);
-			let initial_issuance = Balances::total_issuance();
-			let initial_active_issuance = Balances::active_issuance();
+		let dap_buffer = Dap::buffer_account();
+		let initial_dap_balance = Balances::free_balance(&dap_buffer);
+		let initial_issuance = Balances::total_issuance();
+		let initial_active_issuance = Balances::active_issuance();
 
-			// When: user burns some tokens.
-			assert_ok!(Balances::burn(RuntimeOrigin::signed(user.clone()), burn_amount, false));
+		// When: user burns some tokens.
+		assert_ok!(Balances::burn(RuntimeOrigin::signed(user.clone()), burn_amount, false));
 
-			// Then: DAP buffer receives the burned amount.
-			assert_eq!(Balances::free_balance(&dap_buffer), initial_dap_balance + burn_amount);
+		// Then: DAP buffer receives the burned amount.
+		assert_eq!(Balances::free_balance(&dap_buffer), initial_dap_balance + burn_amount);
 
-			// And: user's balance is reduced.
-			assert_eq!(Balances::free_balance(&user), initial_balance - burn_amount);
+		// And: user's balance is reduced.
+		assert_eq!(Balances::free_balance(&user), initial_balance - burn_amount);
 
-			// And: total issuance is unchanged (funds redirected, not destroyed).
-			assert_eq!(Balances::total_issuance(), initial_issuance);
+		// And: total issuance is unchanged (funds redirected, not destroyed).
+		assert_eq!(Balances::total_issuance(), initial_issuance);
 
-			// And: active issuance is reduced (funds deactivated, excluded from governance).
-			assert_eq!(Balances::active_issuance(), initial_active_issuance - burn_amount);
-		});
+		// And: active issuance is reduced (funds deactivated, excluded from governance).
+		assert_eq!(Balances::active_issuance(), initial_active_issuance - burn_amount);
+	});
 }

cumulus/parachains/runtimes/bridge-hubs/bridge-hub-westend/src/lib.rs

@@ -48,7 +48,7 @@ use sp_runtime::{
 	generic, impl_opaque_keys,
 	traits::Block as BlockT,
 	transaction_validity::{TransactionSource, TransactionValidity},
-	ApplyExtrinsicResult,
+	ApplyExtrinsicResult, Percent,
 };
 
 use sp_session::OpaqueGeneratedSessionKeys;
@@ -363,8 +363,8 @@ impl pallet_balances::Config for Runtime {
 parameter_types! {
 	/// Relay Chain `TransactionByteFee` / 10
 	pub const TransactionByteFee: Balance = MILLICENTS;
-	/// Percentage of fees to send to DAP satellite (0 = all to staking pot, 100 = all to DAP).
-	pub const DapSatelliteFeePercent: u32 = 0;
+	/// Percentage of fees to send to DAP satellite. 0% = all to staking pot.
+	pub const DapSatelliteFeePercent: Percent = Percent::from_percent(0);
 }
 
 /// Fee handler that splits fees between DAP satellite and staking pot.

cumulus/parachains/runtimes/collectives/collectives-westend/src/lib.rs

@@ -62,7 +62,7 @@ use sp_runtime::{
 	generic, impl_opaque_keys,
 	traits::{AccountIdConversion, BlakeTwo256, Block as BlockT},
 	transaction_validity::{TransactionSource, TransactionValidity},
-	ApplyExtrinsicResult, Perbill,
+	ApplyExtrinsicResult, Perbill, Percent,
 };
 
 #[cfg(feature = "std")]
@@ -240,7 +240,7 @@ impl pallet_balances::Config for Runtime {
 parameter_types! {
 	/// Relay Chain `TransactionByteFee` / 10
 	pub const TransactionByteFee: Balance = MILLICENTS;
-	pub const DapSatelliteFeePercent: u32 = 0;
+	pub const DapSatelliteFeePercent: Percent = Percent::from_percent(0);
 }
 
 type DealWithFeesSatellite =

cumulus/parachains/runtimes/coretime/coretime-westend/src/lib.rs

@@ -71,7 +71,7 @@ use sp_runtime::{
 	generic, impl_opaque_keys,
 	traits::{BlakeTwo256, Block as BlockT, BlockNumberProvider},
 	transaction_validity::{TransactionSource, TransactionValidity},
-	ApplyExtrinsicResult, Debug, DispatchError, MultiAddress, Perbill,
+	ApplyExtrinsicResult, Debug, DispatchError, MultiAddress, Perbill, Percent,
 };
 use sp_session::OpaqueGeneratedSessionKeys;
 #[cfg(feature = "std")]
@@ -275,8 +275,8 @@ impl pallet_balances::Config for Runtime {
 parameter_types! {
 	/// Relay Chain `TransactionByteFee` / 10
 	pub const TransactionByteFee: Balance = MILLICENTS;
-	/// Percentage of fees to send to DAP satellite (0-100). Currently 0% - all fees go to collators.
-	pub const DapSatelliteFeePercent: u32 = 0;
+	/// Percentage of fees to send to DAP satellite. Currently 0% - all fees go to collators.
+	pub const DapSatelliteFeePercent: Percent = Percent::from_percent(0);
 }
 
 pub type DealWithFeesSatellite =

cumulus/parachains/runtimes/people/people-westend/src/lib.rs

@@ -64,7 +64,7 @@ use sp_runtime::{
 	transaction_validity::{TransactionSource, TransactionValidity},
 	ApplyExtrinsicResult,
 };
-pub use sp_runtime::{MultiAddress, Perbill, Permill};
+pub use sp_runtime::{MultiAddress, Perbill, Percent, Permill};
 use sp_statement_store::{
 	runtime_api::{InvalidStatement, StatementSource, ValidStatement},
 	SignatureVerificationResult, Statement,
@@ -251,7 +251,7 @@ impl pallet_balances::Config for Runtime {
 parameter_types! {
 	/// Relay Chain `TransactionByteFee` / 10.
 	pub const TransactionByteFee: Balance = MILLICENTS;
-	pub const DapSatelliteFeePercent: u32 = 0;
+	pub const DapSatelliteFeePercent: Percent = Percent::from_percent(0);
 }
 
 type DealWithFeesSatellite =

polkadot/runtime/westend/src/lib.rs

@@ -480,10 +480,10 @@ parameter_types! {
 	/// This value increases the priority of `Operational` transactions by adding
 	/// a "virtual tip" that's equal to the `OperationalFeeMultiplier * final_fee`.
 	pub const OperationalFeeMultiplier: u8 = 5;
-	/// Percentage of fees that go to DAP satellite (0-100).
+	/// Percentage of fees that go to DAP satellite.
 	/// The remainder goes to block author. Tips always go 100% to author.
 	/// Westend: 0% to DAP (preserving original behavior of 100% to author)
-	pub const DapSatelliteFeePercent: u32 = 0;
+	pub const DapSatelliteFeePercent: Percent = Percent::from_percent(0);
 }
 
 /// Fee handler that splits fees between DAP satellite and block author.

substrate/frame/dap-satellite/src/lib.rs

@@ -79,6 +79,7 @@ use frame_support::{
 	},
 	PalletId,
 };
+use sp_runtime::Percent;
 
 pub use pallet::*;
 
@@ -231,7 +232,7 @@ pub type CreditOf<T> = Credit<<T as frame_system::Config>::AccountId, <T as Conf
 
 /// A configurable fee handler that splits fees between DAP satellite and another destination.
 ///
-/// - `DapPercent`: Percentage of fees (0-100) to send to DAP satellite
+/// - `DapPercent`: Percentage of fees to send to DAP satellite (e.g., `Percent::from_percent(0)`)
 /// - `OtherHandler`: Where to send the remaining fees (e.g., `ToAuthor`, `DealWithFees`)
 ///
 /// Tips always go 100% to `OtherHandler`.
@@ -240,7 +241,7 @@ pub type CreditOf<T> = Credit<<T as frame_system::Config>::AccountId, <T as Conf
 ///
 /// ```ignore
 /// parameter_types! {
-///     pub const DapSatelliteFeePercent: u32 = 0; // 0% to DAP, 100% to staking
+///     pub const DapSatelliteFeePercent: Percent = Percent::from_percent(0); // 0% to DAP
 /// }
 ///
 /// type DealWithFeesSatellite = pallet_dap_satellite::DealWithFeesSplit<
@@ -261,12 +262,12 @@ impl<T, DapPercent, OtherHandler> OnUnbalanced<CreditOf<T>>
 	for DealWithFeesSplit<T, DapPercent, OtherHandler>
 where
 	T: Config,
-	DapPercent: Get<u32>,
+	DapPercent: Get<Percent>,
 	OtherHandler: OnUnbalanced<CreditOf<T>>,
 {
 	fn on_unbalanceds(mut fees_then_tips: impl Iterator<Item = CreditOf<T>>) {
 		if let Some(fees) = fees_then_tips.next() {
-			let dap_percent = DapPercent::get();
+			let dap_percent = DapPercent::get().deconstruct() as u32;
 			let other_percent = 100u32.saturating_sub(dap_percent);
 			let mut split = fees.ration(dap_percent, other_percent);
 			if let Some(tips) = fees_then_tips.next() {

substrate/frame/dap-satellite/src/tests/deal_with_fees_split.rs

@@ -20,6 +20,7 @@
 use crate::{mock::*, CreditOf, DealWithFeesSplit};
 use frame_support::{parameter_types, traits::OnUnbalanced};
 use pallet_balances::Pallet as BalancesPallet;
+use sp_runtime::Percent;
 use std::cell::Cell;
 
 type DapSatellitePallet = crate::Pallet<Test>;
@@ -49,9 +50,9 @@ fn get_other_handler_received() -> u64 {
 }
 
 parameter_types! {
-	pub const ZeroPercent: u32 = 0;
-	pub const FiftyPercent: u32 = 50;
-	pub const HundredPercent: u32 = 100;
+	pub const ZeroPercent: Percent = Percent::from_percent(0);
+	pub const FiftyPercent: Percent = Percent::from_percent(50);
+	pub const HundredPercent: Percent = Percent::from_percent(100);
 }
 
 #[test]