cleanup

Author: 0xRVE

substrate/frame/assets/precompiles/src/migration.rs

@@ -179,20 +179,20 @@ where
 					}
 				},
 				None => {
-					log::warn!(
+					log::error!(
 						target: "runtime::MigrateForeignAssetPrecompileMappings::post_upgrade",
 						"Asset {:?} not migrated",
 						asset_id
 					);
+					return Err(sp_runtime::TryRuntimeError::Other("Asset not migrated"));
 				},
 			}
 		}
 
 		log::info!(
 			target: "runtime::MigrateForeignAssetPrecompileMappings::post_upgrade",
-			"Verified {} out of {} foreign asset mappings",
-			migrated,
-			unmapped_assets.len()
+			"Verified {} foreign asset mappings",
+			migrated
 		);
 
 		Ok(())

substrate/frame/assets/precompiles/src/migration_benchmarks.rs

@@ -27,12 +27,6 @@
 use crate::foreign_assets::pallet::{Config, Pallet};
 use frame_benchmarking::v2::*;
 
-/// Helper trait for benchmarking that creates asset IDs.
-pub trait BenchmarkHelper<AssetId> {
-	/// Create a valid asset ID for benchmarking from a seed.
-	fn create_asset_id(seed: u32) -> AssetId;
-}
-
 #[benchmarks(
 	where
 		T::ForeignAssetId: From<u32>,