removed idempotent

Author: 0xRVE

substrate/frame/assets/precompiles/src/migration.rs

@@ -76,7 +76,6 @@ pub enum MigrationState<A> {
 ///
 /// # Safety
 ///
-/// - Idempotent: Skips assets that already have mappings
 /// - Non-destructive: Does not modify any asset data, only adds mappings
 /// - Sequential indices: Each migrated asset gets the next available index
 pub struct MigrateForeignAssetPrecompileMappings<T, I = (), W = ()>(PhantomData<(T, I, W)>);
@@ -254,16 +253,6 @@ where
 		};
 
 		if let Some(asset_id) = iter.next() {
-			// Check if mapping already exists (idempotent)
-			if pallet::Pallet::<T>::asset_index_of(&asset_id).is_some() {
-				log::debug!(
-					target: "runtime::MigrateForeignAssetPrecompileMappings",
-					"Skipping asset {:?} - mapping already exists",
-					asset_id
-				);
-				return (MigrationState::Asset(asset_id), W::migrate_asset_step_skip());
-			}
-
 			// Insert the bidirectional mapping with a new sequential index
 			match pallet::Pallet::<T>::insert_asset_mapping(&asset_id) {
 				Ok(asset_index) => {

substrate/frame/assets/precompiles/src/migration_tests.rs

@@ -260,76 +260,6 @@ fn migration_populates_precompile_mappings() {
 	});
 }
 
-/// Test that the migration is idempotent - running it twice produces the same result.
-///
-/// Idempotency is critical: the second run should not modify any existing mappings.
-#[test]
-fn migration_is_idempotent() {
-	new_test_ext().execute_with(|| {
-		let owner = 1u64;
-
-		let asset_location_1 = Location::new(1, [Junction::Parachain(1234)]);
-		let asset_location_2 = Location::new(1, [Junction::Parachain(5678)]);
-
-		pallet_assets::Asset::<Test, ForeignAssetsInstance>::insert(
-			asset_location_1.clone(),
-			create_asset_details(owner),
-		);
-		pallet_assets::Asset::<Test, ForeignAssetsInstance>::insert(
-			asset_location_2.clone(),
-			create_asset_details(owner),
-		);
-
-		// Verify mappings do not exist before migration
-		assert!(
-			pallet::Pallet::<Test>::asset_index_of(&asset_location_1).is_none(),
-			"Mapping 1 should NOT exist before migration"
-		);
-		assert!(
-			pallet::Pallet::<Test>::asset_index_of(&asset_location_2).is_none(),
-			"Mapping 2 should NOT exist before migration"
-		);
-
-		run_migration_to_completion();
-
-		// Get the indices assigned during first run
-		let index_1 = pallet::Pallet::<Test>::asset_index_of(&asset_location_1).unwrap();
-		let index_2 = pallet::Pallet::<Test>::asset_index_of(&asset_location_2).unwrap();
-
-		// Capture complete state after first run
-		let state_after_first = (
-			pallet::Pallet::<Test>::asset_id_of(index_1),
-			pallet::Pallet::<Test>::asset_id_of(index_2),
-			pallet::Pallet::<Test>::asset_index_of(&asset_location_1),
-			pallet::Pallet::<Test>::asset_index_of(&asset_location_2),
-			pallet::Pallet::<Test>::next_asset_index(),
-		);
-
-		// Verify mappings were created correctly after first run
-		assert!(state_after_first.0.is_some(), "Forward mapping 1 should exist after first run");
-		assert!(state_after_first.1.is_some(), "Forward mapping 2 should exist after first run");
-		assert!(state_after_first.2.is_some(), "Reverse mapping 1 should exist after first run");
-		assert!(state_after_first.3.is_some(), "Reverse mapping 2 should exist after first run");
-
-		run_migration_to_completion();
-
-		// Capture complete state after second run
-		let state_after_second = (
-			pallet::Pallet::<Test>::asset_id_of(index_1),
-			pallet::Pallet::<Test>::asset_id_of(index_2),
-			pallet::Pallet::<Test>::asset_index_of(&asset_location_1),
-			pallet::Pallet::<Test>::asset_index_of(&asset_location_2),
-			pallet::Pallet::<Test>::next_asset_index(),
-		);
-
-		// State must be identical after second run
-		assert_eq!(
-			state_after_first, state_after_second,
-			"Idempotency violation: migration modified mappings on second run"
-		);
-	});
-}
-
 /// Test that the migration handles the case with no foreign assets gracefully.
 #[test]
 fn migration_handles_empty_foreign_assets() {