-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Open
Labels
C1-mentorA task where a mentor is available. Please indicate in the issue who the mentor could be.A task where a mentor is available. Please indicate in the issue who the mentor could be.D0-easyCan be fixed primarily by duplicating and adapting code by an intermediate coder.Can be fixed primarily by duplicating and adapting code by an intermediate coder.T1-FRAMEThis PR/Issue is related to core FRAME, the framework.This PR/Issue is related to core FRAME, the framework.T10-testsThis PR/Issue is related to tests.This PR/Issue is related to tests.
Description
The staking tests.rs has about 7k LOC. Most of the tests are nicely organised into modules, consider refactor each mod into a new file for readability.
It may be that the module-less tests alone will be lot of LOC, maybe we should consider breaking those down as well on a separate PR. My suggestion on how to proceed are the following:
First iter/PR:
- Open PR refactoring the current tests into it's own mod folder
/staking/src/tests/ - Refactor mod tests into their own file. e.g. tests under
mod staking_ledgershould be in/staking/src/tests/staking_ledger.rs - Tests without module should end up in
/staking/src/tests/mod.rs
Second iter/PR:
- consider re-org tests in
mod.rsinto relevant submodules
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
C1-mentorA task where a mentor is available. Please indicate in the issue who the mentor could be.A task where a mentor is available. Please indicate in the issue who the mentor could be.D0-easyCan be fixed primarily by duplicating and adapting code by an intermediate coder.Can be fixed primarily by duplicating and adapting code by an intermediate coder.T1-FRAMEThis PR/Issue is related to core FRAME, the framework.This PR/Issue is related to core FRAME, the framework.T10-testsThis PR/Issue is related to tests.This PR/Issue is related to tests.
Type
Projects
Status
✂️ In progress.