Remove RC and local treasury accounts

[sigurpol]

Following comments here and here, we should plan for the following:

• post AHM, local treasury accounts as well as RC treasury accounts should not be used anymore or referenced anywhere
• local DAP satellite accounts should replace all usages (should be covered in Redirect XCM delivery fees to DAP / DAP satellite on Westend chains #11700)
• migration required to move existing funds from the local treasury accounts. To where ? To the local DAP satellites or back to AH's treasury account? TBD

We can actually get rid and drain local / RC treasury accounts after the following has happened (see #11700, #11716 ):

• Transaction fees → DAP satellite (100% on Westend - already configured)
• XCM delivery fees → DAP Satellite (Redirect XCM delivery fees to DAP / DAP satellite on Westend chains #11700 )
• Slashing → DAP Satellite (already done on Westend)
• Dust removal → DAP Satellite (already done on Westend)
• collectives (fellowship, ambassador, alliance) and people identity slash to DAP satellite : this requires DAP: add support for negative imbalance to properly redirect slashed on Polkadot AH's bounties and referenda #11704 to be fixed (PR in review: Add legacy NegativeImbalance support to DAP and DAP satellite #11716)
• Treasury extrinsics on RC→ blocked by PostAhmFilter (already done post AHM)
• Bounties on RC → blocked by PostAhmFilter (already done post AHM)

Some notes:

• I was checking the treasury account on Polkadot RC (e.g. https://polkadot.subscan.io/account/13UVJyLnbVp9RBZYFwFGyDvVd1y27Tt8tkntv6Q7JVPhFsTB?tab=xcm_transfer&chart_tab=time) - my expectation was that it was not meant to be used post AHM but there are still activities there (See also https://github.com/polkadot-fellows/runtimes/blob/kiz-ahm-forcing/pallets/rc-migrator/src/treasury.md). On Westend RC, it seems indeed ☠️ (https://westend.subscan.io/account/13UVJyLnbVp9RBZYFwFGyDvVd1y27Tt8tkntv6Q7JVPhFsTB)
• RelayTreasuryAccountId seems to be used in WaivedLocations to grant the relay treasury free XCM execution

Related twin issue in the runtime: polkadot-fellows/runtimes#1144 - where Polkadot and Kusama solutions will most likely diverge.

[sigurpol]

@muharem do you know if having still activities on Polkadot RC treasury account ( https://polkadot.subscan.io/account/13UVJyLnbVp9RBZYFwFGyDvVd1y27Tt8tkntv6Q7JVPhFsTB?tab=xcm_transfer&chart_tab=time - see crosschain transfers tab) is expected? It doesn't seem to match what we are describing here https://github.com/polkadot-fellows/runtimes/blob/kiz-ahm-forcing/pallets/rc-migrator/src/treasury.md

[muharem]

It seems that treasury account receives the xcm fees here:
https://github.com/polkadot-fellows/runtimes/blob/2f797a2ca9d69d88e6d69f2ff909f3f830a0808d/relay/polkadot/src/xcm_config.rs#L257

also treasury account mentioned as a slash destination in few other places like staking. but most of them / or all not relevant anymore. needs to be double checked.

note that Treasury type implements some OnUnbalanced traits and has account id getter.

[muharem]

Also there is some old scheduled call that transfers USDT and USDC swapped on Hydration to the old Treasury account on AH. This account used to be delivery from the location of the Treasury on RC relative to AH. This is why we have this call here: https://github.com/polkadot-fellows/runtimes/blob/2f797a2ca9d69d88e6d69f2ff909f3f830a0808d/pallets/ah-ops/src/lib.rs#L349

[Ank4n]

also treasury account mentioned as a slash destination in few other places like staking. but most of them / or all not relevant anymore. needs to be double checked.

Staking based slashing config on RC has no effect as there is no slashing anymore on the RC side.

[sigurpol]

It seems that treasury account receives the xcm fees here:
https://github.com/polkadot-fellows/runtimes/blob/2f797a2ca9d69d88e6d69f2ff909f3f830a0808d/relay/polkadot/src/xcm_config.rs#L257

Yes - similarly to #11700 , XCM fees will be redirected to DAP satellite for fellowship runtimes as well (WIP branch polkadot-fellows/runtimes@main...sigurpol:runtimes:sigurpol-xcm-fees-to-dap, didn't want to create the PR yet to leave Oliver all the CI bandwidth for 2.2.0 😄 ) - as part of runtime polkadot-fellows/runtimes#1144

I will cleanup also staking RC stuff - but as Ankan mentioned - that's irrelevant since slashing is handled on AH side

[sigurpol]

Also there is some old scheduled call that transfers USDT and USDC swapped on Hydration to the old Treasury account on AH. This account used to be delivery from the location of the Treasury on RC relative to AH. This is why we have this call here: https://github.com/polkadot-fellows/runtimes/blob/2f797a2ca9d69d88e6d69f2ff909f3f830a0808d/pallets/ah-ops/src/lib.rs#L349

ah nice - TIL 😄 Indeed, I see it being called e.g. https://assethub-polkadot.subscan.io/extrinsic?page=1&time_dimension=date&module_call=%5B%7B%22module%22%3A%22ahops%22%2C%22call%22%3A%22transfer_to_post_migration_treasury%22%7D%5D. Is this old scheduled call on Hydration still active then? If yes, it means we need to keep the old RC treasury account on AH alive for the foreseeable future, correct? But we could remove the old (pre-AHM) treasury account on RC and migrate all funds to DAP satellite / main AH treasury account - after everything has been redirected elsewhere (DAP satellite on RC) so this doesn't interfere with the cleanup of all RC/local treasury accounts everywhere except on AH. See also polkadot-fellows/runtimes#1144 for some Kusama-specific notes.

[muharem]

the call is still active, we can see it here https://assethub-polkadot.subscan.io/account/14xmwinmCEz6oRrFdczHKqHgWNMiCysE2KrA4jXXAAM1Eogk?tab=xcm_transfer

it means we need to keep the old RC treasury account on AH alive for the foreseeable future, correct?

if needed we can move all funds from it whenever we decided (DAP or treasury account). if the call will be still active it will just top up that account again, creating it if it will be removed before.