Use the sdout as a source for chainspec file

Author: activecoder10

crates/node/src/kitchensink.rs

@@ -1,7 +1,6 @@
 use std::{
-    fs,
     fs::create_dir_all,
-    io::{BufRead, Read},
+    io::{BufRead},
     path::PathBuf,
     process::{Child, Command, Stdio},
     sync::atomic::{AtomicU32, Ordering},
@@ -56,26 +55,25 @@ impl KitchensinkNode {
 
     const PROXY_LOG_ENV: &'static str = "info,eth-rpc=debug";
 
-    fn init(&mut self, genesis_path: &str) -> anyhow::Result<&mut Self> {
+    fn init(&mut self, genesis: &str) -> anyhow::Result<&mut Self> {
         create_dir_all(&self.base_directory)?;
 
         let template_chainspec_path = self.base_directory.join(Self::CHAIN_SPEC_JSON_FILE);
 
-        let status = Command::new(&self.substrate_binary)
+        let output = Command::new(&self.substrate_binary)
             .arg("export-chain-spec")
             .arg("--chain")
             .arg("dev")
-            .arg("--output")
-            .arg(&template_chainspec_path)
-            .status()?;
+            .output()?;
 
-        if !status.success() {
-            anyhow::bail!("substrate-node export-chain-spec failed");
+        if !output.status.success() {
+            anyhow::bail!(
+                "substrate-node export-chain-spec failed: {}",
+                String::from_utf8_lossy(&output.stderr)
+            );
         }
 
-        let mut file = std::fs::File::open(&template_chainspec_path)?;
-        let mut content = String::new();
-        file.read_to_string(&mut content)?;
+        let content = String::from_utf8(output.stdout)?;
         let mut chainspec_json: JsonValue = serde_json::from_str(&content)?;
 
         let existing_chainspec_balances =
@@ -97,7 +95,7 @@ impl KitchensinkNode {
                 None
             })
             .collect();
-        let mut eth_balances = self.extract_balance_from_genesis_file(genesis_path)?;
+        let mut eth_balances = self.extract_balance_from_genesis_file(genesis)?;
         merged_balances.append(&mut eth_balances);
 
         chainspec_json["genesis"]["runtimeGenesis"]["patch"]["balances"]["balances"] =
@@ -170,9 +168,8 @@ impl KitchensinkNode {
 
     fn extract_balance_from_genesis_file(
         &self,
-        genesis_path: &str,
+        genesis_str: &str,
     ) -> anyhow::Result<Vec<(String, u128)>> {
-        let genesis_str = fs::read_to_string(genesis_path)?;
         let genesis_json: JsonValue = serde_json::from_str(&genesis_str)?;
         let alloc = genesis_json
             .get("alloc")
@@ -364,7 +361,6 @@ mod tests {
     use temp_dir::TempDir;
 
     use std::fs;
-    use tempfile::tempdir;
 
     use super::KitchensinkNode;
     use crate::{GENESIS_JSON, Node};
@@ -383,8 +379,6 @@ mod tests {
 
     #[test]
     fn test_init_generates_chainspec_with_balances() {
-        // Setup: Write a minimal Geth-style genesis.json
-        let test_genesis_path = std::env::temp_dir().join("test_genesis_file.json");
         let genesis_content = r#"
         {
             "alloc": {
@@ -397,12 +391,12 @@ mod tests {
             }
         }
         "#;
-        fs::write(&test_genesis_path, genesis_content).expect("Failed to write test genesis");
+        
         let mut dummy_node = KitchensinkNode::new(&test_config().0);
 
         // Call `init()`
         dummy_node
-            .init(test_genesis_path.to_str().unwrap())
+            .init(genesis_content)
             .expect("init failed");
 
         // Check that the patched chainspec file was generated
@@ -433,8 +427,6 @@ mod tests {
 
     #[test]
     fn test_parse_genesis_alloc() {
-        let temp_dir = tempdir().unwrap();
-        let genesis_path = temp_dir.path().join("test_genesis_file_eth.json");
 
         // Create test genesis file
         let genesis_json = r#"
@@ -447,12 +439,11 @@ mod tests {
         }
         "#;
 
-        fs::write(&genesis_path, genesis_json).unwrap();
 
         let node = KitchensinkNode::new(&test_config().0);
 
         let result = node
-            .extract_balance_from_genesis_file(genesis_path.to_str().unwrap())
+            .extract_balance_from_genesis_file(genesis_json)
             .unwrap();
 
         let result_map: std::collections::HashMap<_, _> = result.into_iter().collect();
@@ -526,12 +517,8 @@ mod tests {
     fn spawn_works() {
         let (config, _temp_dir) = test_config();
 
-        // Write GENESIS_JSON to a temp file
-        let genesis_path = std::env::temp_dir().join("test_genesis_eth.json");
-        std::fs::write(&genesis_path, GENESIS_JSON).unwrap();
-
         let mut node = KitchensinkNode::new(&config);
-        node.spawn(genesis_path.to_str().unwrap().to_string())
+        node.spawn(GENESIS_JSON.to_string())
             .unwrap();
     }