Make `Geth` against `Geth` differential tests work

[xermicus]

We can have the leader and follower implementations be the same and that should pass for all tests. The code base is close to allowing this, some small things to iron out:

• The nonce is just set to 0 all the time. Either change to query the node or better track it and supply it directly. Adding a method fetch_add_nonce to the NodeInteraction trait which internally tracks it could be an option. However right now the node pool is a simple round-robbin without locking, so there's a chance the nonce is not in sequence. This could also be changed to ensure contiguous nonces.
• Implement some very basic differential verification in the test driver (in simple terms, in fn execute_input assert that both diff structures received from the trace_transaction are equal for every transaction and the receipts contain the same events and output).
• Sometimes the Matter Labs test cases don't explicitly deploy the contract to be tested. In that case, try to deploy it with empty constructor calldata.
• If the calldata contain references to other contract addresses, they need to be looked up. This also means that deployed contracts (at least their addresses) must be inserted into the State deployed_contracts mapping.
• Some tests use callers for which we don't have a private key, need to think about what we can do here (obvious solution seems to just change those tests if they allow it).
• Certain tests require a specific version of the solc compiler. We need a way to detect the version that they require and provide them with that version.
• Certain tests make use of libraries and they require these libraries to be first deployed and then dynamically linked into the contract source code before the contracts are deployed. We need to handle linking.
• There might be problems and missing things I am not aware of which need fixing too.

[activecoder10]

This PR (#25) should fix the first box:

The nonce is just set to 0 all the time. Either change to query the node or better track it and supply it directly. Adding a method fetch_add_nonce to the NodeInteraction trait which internally tracks it could be an option. However right now the node pool is a simple round-robbin without locking, so there's a chance the nonce is not in sequence. This could also be changed to ensure contiguous nonces.

[activecoder10]

This PR (#26) should fix the second box:

Implement some very basic differential verification in the test driver (in simple terms, in fn execute_input assert that both diff structures received from the trace_transaction are equal for every transaction and the receipts contain the same events and output).

[activecoder10]

This PR (#28) should fix the input execution part when executing a transaction

[0xOmarA]

The third item is fixed in #48

[activecoder10]

I have run some Geth vs Geth differential tests for some of the input and I got these results:

Test run: /era-compiler-tests/solidity/complex/array_one_element"

Command run:

RUST_LOG=trace cargo run --release -p revive-dt-core -- \
  --corpus  ml-solidity-complex.json \
  --leader  geth \
  --follower geth  2>&1 | tee eth.log

Results:

2025-07-21T10:01:15.284856Z DEBUG revive_dt_core::driver: State diffs mismatch between leader and follower.
    at crates/core/src/driver/mod.rs:582 on main ThreadId(1)
    in revive_dt_core::driver::Handling input with input_idx: 0
    in revive_dt_core::driver::Handling case with case_name: "first", case_idx: 0
    in revive_dt_core::driver::With solc mode with solc_mode: SolcMode { solc_version: None, solc_optimize: None, llvm_optimizer_settings: [] }
    in revive_dt_core::driver::Handling metadata file
    in retester::Running driver with metadata_file_path: "/projects/era-compiler-tests/solidity/complex/array_one_element/test.json"

  2025-07-21T10:01:15.284884Z TRACE revive_dt_core::driver: Leader - PRE STATE:
    at crates/core/src/driver/mod.rs:382 on main ThreadId(1)
    in revive_dt_core::driver::Handling input with input_idx: 0
    in revive_dt_core::driver::Handling case with case_name: "first", case_idx: 0
    in revive_dt_core::driver::With solc mode with solc_mode: SolcMode { solc_version: None, solc_optimize: None, llvm_optimizer_settings: [] }
    in revive_dt_core::driver::Handling metadata file
    in retester::Running driver with metadata_file_path: "/projects/era-compiler-tests/solidity/complex/array_one_element/test.json"

  2025-07-21T10:01:15.284891Z TRACE revive_dt_core::driver:   [pre] 0x23984cb9f04fe22529676bc4996ec5c6374ceb17
    at crates/core/src/driver/mod.rs:394 on main ThreadId(1)
    in revive_dt_core::driver::Handling input with input_idx: 0
    in revive_dt_core::driver::Handling case with case_name: "first", case_idx: 0
    in revive_dt_core::driver::With solc mode with solc_mode: SolcMode { solc_version: None, solc_optimize: None, llvm_optimizer_settings: [] }
    in revive_dt_core::driver::Handling metadata file
    in retester::Running driver with metadata_file_path: "/projects/era-compiler-tests/solidity/complex/array_one_element/test.json"

  2025-07-21T10:01:15.284896Z TRACE revive_dt_core::driver:   [pre]   balance: 221946
    at crates/core/src/driver/mod.rs:397 on main ThreadId(1)
    in revive_dt_core::driver::Handling input with input_idx: 0
    in revive_dt_core::driver::Handling case with case_name: "first", case_idx: 0
    in revive_dt_core::driver::With solc mode with solc_mode: SolcMode { solc_version: None, solc_optimize: None, llvm_optimizer_settings: [] }
    in revive_dt_core::driver::Handling metadata file
    in retester::Running driver with metadata_file_path: "/projects/era-compiler-tests/solidity/complex/array_one_element/test.json"

  2025-07-21T10:01:15.284903Z TRACE revive_dt_core::driver:   [pre] 0x90f8bf6a479f320ead074411a4b0e7944ea8c9c1
    at crates/core/src/driver/mod.rs:394 on main ThreadId(1)
    in revive_dt_core::driver::Handling input with input_idx: 0
    in revive_dt_core::driver::Handling case with case_name: "first", case_idx: 0
    in revive_dt_core::driver::With solc mode with solc_mode: SolcMode { solc_version: None, solc_optimize: None, llvm_optimizer_settings: [] }
    in revive_dt_core::driver::Handling metadata file
    in retester::Running driver with metadata_file_path: "/projects/era-compiler-tests/solidity/complex/array_one_element/test.json"

  2025-07-21T10:01:15.284905Z TRACE revive_dt_core::driver:   [pre]   balance: 999818881375657910
    at crates/core/src/driver/mod.rs:397 on main ThreadId(1)
    in revive_dt_core::driver::Handling input with input_idx: 0
    in revive_dt_core::driver::Handling case with case_name: "first", case_idx: 0
    in revive_dt_core::driver::With solc mode with solc_mode: SolcMode { solc_version: None, solc_optimize: None, llvm_optimizer_settings: [] }
    in revive_dt_core::driver::Handling metadata file
    in retester::Running driver with metadata_file_path: "/projects/era-compiler-tests/solidity/complex/array_one_element/test.json"

  2025-07-21T10:01:15.284909Z TRACE revive_dt_core::driver:   [pre]   nonce: 2
    at crates/core/src/driver/mod.rs:400 on main ThreadId(1)
    in revive_dt_core::driver::Handling input with input_idx: 0
    in revive_dt_core::driver::Handling case with case_name: "first", case_idx: 0
    in revive_dt_core::driver::With solc mode with solc_mode: SolcMode { solc_version: None, solc_optimize: None, llvm_optimizer_settings: [] }
    in revive_dt_core::driver::Handling metadata file
    in retester::Running driver with metadata_file_path: "/projects/era-compiler-tests/solidity/complex/array_one_element/test.json"

  2025-07-21T10:01:15.284912Z TRACE revive_dt_core::driver: Leader - POST STATE:
    at crates/core/src/driver/mod.rs:387 on main ThreadId(1)
    in revive_dt_core::driver::Handling input with input_idx: 0
    in revive_dt_core::driver::Handling case with case_name: "first", case_idx: 0
    in revive_dt_core::driver::With solc mode with solc_mode: SolcMode { solc_version: None, solc_optimize: None, llvm_optimizer_settings: [] }
    in revive_dt_core::driver::Handling metadata file
    in retester::Running driver with metadata_file_path: "/projects/era-compiler-tests/solidity/complex/array_one_element/test.json"

  2025-07-21T10:01:15.284915Z TRACE revive_dt_core::driver:   [post] 0x23984cb9f04fe22529676bc4996ec5c6374ceb17
    at crates/core/src/driver/mod.rs:394 on main ThreadId(1)
    in revive_dt_core::driver::Handling input with input_idx: 0
    in revive_dt_core::driver::Handling case with case_name: "first", case_idx: 0
    in revive_dt_core::driver::With solc mode with solc_mode: SolcMode { solc_version: None, solc_optimize: None, llvm_optimizer_settings: [] }
    in revive_dt_core::driver::Handling metadata file
    in retester::Running driver with metadata_file_path: "/projects/era-compiler-tests/solidity/complex/array_one_element/test.json"

  2025-07-21T10:01:15.284931Z TRACE revive_dt_core::driver:   [post]   balance: 246943
    at crates/core/src/driver/mod.rs:397 on main ThreadId(1)
    in revive_dt_core::driver::Handling input with input_idx: 0
    in revive_dt_core::driver::Handling case with case_name: "first", case_idx: 0
    in revive_dt_core::driver::With solc mode with solc_mode: SolcMode { solc_version: None, solc_optimize: None, llvm_optimizer_settings: [] }
    in revive_dt_core::driver::Handling metadata file
    in retester::Running driver with metadata_file_path: "/projects/era-compiler-tests/solidity/complex/array_one_element/test.json"

  2025-07-21T10:01:15.284934Z TRACE revive_dt_core::driver:   [post] 0x90f8bf6a479f320ead074411a4b0e7944ea8c9c1
    at crates/core/src/driver/mod.rs:394 on main ThreadId(1)
    in revive_dt_core::driver::Handling input with input_idx: 0
    in revive_dt_core::driver::Handling case with case_name: "first", case_idx: 0
    in revive_dt_core::driver::With solc mode with solc_mode: SolcMode { solc_version: None, solc_optimize: None, llvm_optimizer_settings: [] }
    in revive_dt_core::driver::Handling metadata file
    in retester::Running driver with metadata_file_path: "/projects/era-compiler-tests/solidity/complex/array_one_element/test.json"

  2025-07-21T10:01:15.284937Z TRACE revive_dt_core::driver:   [post]   balance: 999802135090878259
    at crates/core/src/driver/mod.rs:397 on main ThreadId(1)
    in revive_dt_core::driver::Handling input with input_idx: 0
    in revive_dt_core::driver::Handling case with case_name: "first", case_idx: 0
    in revive_dt_core::driver::With solc mode with solc_mode: SolcMode { solc_version: None, solc_optimize: None, llvm_optimizer_settings: [] }
    in revive_dt_core::driver::Handling metadata file
    in retester::Running driver with metadata_file_path: "/projects/era-compiler-tests/solidity/complex/array_one_element/test.json"

  2025-07-21T10:01:15.284940Z TRACE revive_dt_core::driver:   [post]   nonce: 3
    at crates/core/src/driver/mod.rs:400 on main ThreadId(1)
    in revive_dt_core::driver::Handling input with input_idx: 0
    in revive_dt_core::driver::Handling case with case_name: "first", case_idx: 0
    in revive_dt_core::driver::With solc mode with solc_mode: SolcMode { solc_version: None, solc_optimize: None, llvm_optimizer_settings: [] }
    in revive_dt_core::driver::Handling metadata file
    in retester::Running driver with metadata_file_path: "/projects/era-compiler-tests/solidity/complex/array_one_element/test.json"

  2025-07-21T10:01:15.284944Z TRACE revive_dt_core::driver: Follower - PRE STATE:
    at crates/core/src/driver/mod.rs:382 on main ThreadId(1)
    in revive_dt_core::driver::Handling input with input_idx: 0
    in revive_dt_core::driver::Handling case with case_name: "first", case_idx: 0
    in revive_dt_core::driver::With solc mode with solc_mode: SolcMode { solc_version: None, solc_optimize: None, llvm_optimizer_settings: [] }
    in revive_dt_core::driver::Handling metadata file
    in retester::Running driver with metadata_file_path: "/projects/era-compiler-tests/solidity/complex/array_one_element/test.json"

  2025-07-21T10:01:15.284946Z TRACE revive_dt_core::driver:   [pre] 0x294f480d158349298149693c4e2c9e916b0782ec
    at crates/core/src/driver/mod.rs:394 on main ThreadId(1)
    in revive_dt_core::driver::Handling input with input_idx: 0
    in revive_dt_core::driver::Handling case with case_name: "first", case_idx: 0
    in revive_dt_core::driver::With solc mode with solc_mode: SolcMode { solc_version: None, solc_optimize: None, llvm_optimizer_settings: [] }
    in revive_dt_core::driver::Handling metadata file
    in retester::Running driver with metadata_file_path: "/projects/era-compiler-tests/solidity/complex/array_one_element/test.json"

  2025-07-21T10:01:15.284949Z TRACE revive_dt_core::driver:   [pre]   balance: 221946
    at crates/core/src/driver/mod.rs:397 on main ThreadId(1)
    in revive_dt_core::driver::Handling input with input_idx: 0
    in revive_dt_core::driver::Handling case with case_name: "first", case_idx: 0
    in revive_dt_core::driver::With solc mode with solc_mode: SolcMode { solc_version: None, solc_optimize: None, llvm_optimizer_settings: [] }
    in revive_dt_core::driver::Handling metadata file
    in retester::Running driver with metadata_file_path: "/projects/era-compiler-tests/solidity/complex/array_one_element/test.json"

  2025-07-21T10:01:15.284952Z TRACE revive_dt_core::driver:   [pre] 0x90f8bf6a479f320ead074411a4b0e7944ea8c9c1
    at crates/core/src/driver/mod.rs:394 on main ThreadId(1)
    in revive_dt_core::driver::Handling input with input_idx: 0
    in revive_dt_core::driver::Handling case with case_name: "first", case_idx: 0
    in revive_dt_core::driver::With solc mode with solc_mode: SolcMode { solc_version: None, solc_optimize: None, llvm_optimizer_settings: [] }
    in revive_dt_core::driver::Handling metadata file
    in retester::Running driver with metadata_file_path: "/projects/era-compiler-tests/solidity/complex/array_one_element/test.json"

  2025-07-21T10:01:15.284955Z TRACE revive_dt_core::driver:   [pre]   balance: 999818881375657910
    at crates/core/src/driver/mod.rs:397 on main ThreadId(1)
    in revive_dt_core::driver::Handling input with input_idx: 0
    in revive_dt_core::driver::Handling case with case_name: "first", case_idx: 0
    in revive_dt_core::driver::With solc mode with solc_mode: SolcMode { solc_version: None, solc_optimize: None, llvm_optimizer_settings: [] }
    in revive_dt_core::driver::Handling metadata file
    in retester::Running driver with metadata_file_path: "/projects/era-compiler-tests/solidity/complex/array_one_element/test.json"

  2025-07-21T10:01:15.284958Z TRACE revive_dt_core::driver:   [pre]   nonce: 2
    at crates/core/src/driver/mod.rs:400 on main ThreadId(1)
    in revive_dt_core::driver::Handling input with input_idx: 0
    in revive_dt_core::driver::Handling case with case_name: "first", case_idx: 0
    in revive_dt_core::driver::With solc mode with solc_mode: SolcMode { solc_version: None, solc_optimize: None, llvm_optimizer_settings: [] }
    in revive_dt_core::driver::Handling metadata file
    in retester::Running driver with metadata_file_path: "/projects/era-compiler-tests/solidity/complex/array_one_element/test.json"

  2025-07-21T10:01:15.284961Z TRACE revive_dt_core::driver: Follower - POST STATE:
    at crates/core/src/driver/mod.rs:387 on main ThreadId(1)
    in revive_dt_core::driver::Handling input with input_idx: 0
    in revive_dt_core::driver::Handling case with case_name: "first", case_idx: 0
    in revive_dt_core::driver::With solc mode with solc_mode: SolcMode { solc_version: None, solc_optimize: None, llvm_optimizer_settings: [] }
    in revive_dt_core::driver::Handling metadata file
    in retester::Running driver with metadata_file_path: "/projects/era-compiler-tests/solidity/complex/array_one_element/test.json"

  2025-07-21T10:01:15.284964Z TRACE revive_dt_core::driver:   [post] 0x294f480d158349298149693c4e2c9e916b0782ec
    at crates/core/src/driver/mod.rs:394 on main ThreadId(1)
    in revive_dt_core::driver::Handling input with input_idx: 0
    in revive_dt_core::driver::Handling case with case_name: "first", case_idx: 0
    in revive_dt_core::driver::With solc mode with solc_mode: SolcMode { solc_version: None, solc_optimize: None, llvm_optimizer_settings: [] }
    in revive_dt_core::driver::Handling metadata file
    in retester::Running driver with metadata_file_path: "/projects/era-compiler-tests/solidity/complex/array_one_element/test.json"

  2025-07-21T10:01:15.285010Z TRACE revive_dt_core::driver:   [post]   balance: 246943
    at crates/core/src/driver/mod.rs:397 on main ThreadId(1)
    in revive_dt_core::driver::Handling input with input_idx: 0
    in revive_dt_core::driver::Handling case with case_name: "first", case_idx: 0
    in revive_dt_core::driver::With solc mode with solc_mode: SolcMode { solc_version: None, solc_optimize: None, llvm_optimizer_settings: [] }
    in revive_dt_core::driver::Handling metadata file
    in retester::Running driver with metadata_file_path: "/projects/era-compiler-tests/solidity/complex/array_one_element/test.json"

  2025-07-21T10:01:15.285027Z TRACE revive_dt_core::driver:   [post] 0x90f8bf6a479f320ead074411a4b0e7944ea8c9c1
    at crates/core/src/driver/mod.rs:394 on main ThreadId(1)
    in revive_dt_core::driver::Handling input with input_idx: 0
    in revive_dt_core::driver::Handling case with case_name: "first", case_idx: 0
    in revive_dt_core::driver::With solc mode with solc_mode: SolcMode { solc_version: None, solc_optimize: None, llvm_optimizer_settings: [] }
    in revive_dt_core::driver::Handling metadata file
    in retester::Running driver with metadata_file_path: "/projects/era-compiler-tests/solidity/complex/array_one_element/test.json"

  2025-07-21T10:01:15.285032Z TRACE revive_dt_core::driver:   [post]   balance: 999802135090878259
    at crates/core/src/driver/mod.rs:397 on main ThreadId(1)
    in revive_dt_core::driver::Handling input with input_idx: 0
    in revive_dt_core::driver::Handling case with case_name: "first", case_idx: 0
    in revive_dt_core::driver::With solc mode with solc_mode: SolcMode { solc_version: None, solc_optimize: None, llvm_optimizer_settings: [] }
    in revive_dt_core::driver::Handling metadata file
    in retester::Running driver with metadata_file_path: "/projects/era-compiler-tests/solidity/complex/array_one_element/test.json"

  2025-07-21T10:01:15.285036Z TRACE revive_dt_core::driver:   [post]   nonce: 3
    at crates/core/src/driver/mod.rs:400 on main ThreadId(1)
    in revive_dt_core::driver::Handling input with input_idx: 0
    in revive_dt_core::driver::Handling case with case_name: "first", case_idx: 0
    in revive_dt_core::driver::With solc mode with solc_mode: SolcMode { solc_version: None, solc_optimize: None, llvm_optimizer_settings: [] }
    in revive_dt_core::driver::Handling metadata file
    in retester::Running driver with metadata_file_path: "/projects/era-compiler-tests/solidity/complex/array_one_element/test.json"

  2025-07-21T10:01:15.285255Z  INFO retester: Execution completed, case_success_count: 2, case_failure_count: 0

[0xOmarA]

@activecoder10 Thanks for reporting this!

Would you mind creating a separate issue for it? Also, would you like to take on this task or is this more of a report of the issue?

[activecoder10]

@0xOmarA , I just wanted to show that the execution of Geth vs Geth is working as expected after we did all the required changes.

Looking at the logs, we see the next:

Leader node (Geth):

[pre]

0x23984cb9f04fe22529676bc4996ec5c6374ceb17
balance: 221946

0x90f8bf6a479f320ead074411a4b0e7944ea8c9c1
balance: 999818881375657910

nonce: 2

[post]

0x23984cb9f04fe22529676bc4996ec5c6374ceb17
balance: 246943

0x90f8bf6a479f320ead074411a4b0e7944ea8c9c1
balance: 999802135090878259

nonce: 3

Follower node (Geth):

[pre]

0x294f480d158349298149693c4e2c9e916b0782ec
balance: 221946

0x90f8bf6a479f320ead074411a4b0e7944ea8c9c1
balance: 999818881375657910

nonce: 2

[post]

0x294f480d158349298149693c4e2c9e916b0782ec
balance: 246943

0x90f8bf6a479f320ead074411a4b0e7944ea8c9c1
balance: 999802135090878259

nonce: 3

Looking at the 0x90f8bf6a479f320ead074411a4b0e7944ea8c9c1 address (the address from our geth geneisis.json), we can see that the balance pre/post are the same for the leader and for the follower nodes (Geth in this case), so the execution was successfully.

[0xOmarA]

Ah, gotcha! That's great to hear that we finally have the state changes from the leader and follower matching up!

One of the things we need to focus on now is ironing out the last couple of remaining bugs that we have in the codebase so that we no longer have failing tests.

The notion document that I shared is the best source of guidance on what works and what doesn't at the moment.

[0xOmarA]

I have just edited the original post with more items that we need to work on for Geth vs Geth