address comments

Author: bee344

src/controllers/transaction/TransactionMetadataBlobController.ts

@@ -18,32 +18,6 @@ import { TransactionMetadataBlobService } from '../../services';
 import { IMetadataBlobBody, IPostRequestHandler } from '../../types/requests';
 import AbstractController from '../AbstractController';
 
-/**
- * Parameters for generating metadata blob proof.
- */
-export interface MetadataBlobParams {
-	/**
-	 * Full encoded extrinsic. Use this OR the individual parts.
-	 */
-	tx?: string;
-	/**
-	 * Optional tx additional signed data.
-	 */
-	txAdditionalSigned?: string;
-	/**
-	 * Call data. Use with includedInExtrinsic and includedInSignedData.
-	 */
-	callData?: string;
-	/**
-	 * Signed Extension data included in the extrinsic.
-	 */
-	includedInExtrinsic?: string;
-	/**
-	 * Signed Extension data included in the signature.
-	 */
-	includedInSignedData?: string;
-}
-
 /**
  * POST metadata blob for a transaction.
  *

src/services/transaction/TransactionMetadataBlobService.ts

@@ -19,11 +19,15 @@ import { ApiDecoration } from '@polkadot/api/types';
 import type { BlockHash } from '@polkadot/types/interfaces';
 import { u8aToHex } from '@polkadot/util';
 import { BadRequest, InternalServerError } from 'http-errors';
+import { MetadataBlobParams } from 'src/types/requests';
 import { ITransactionMetadataBlob } from 'src/types/responses';
 
-import { MetadataBlobParams } from '../../controllers/transaction/TransactionMetadataBlobController';
 import { AbstractService } from '../AbstractService';
 
+const DEFAULT_DECIMALS = 10;
+const DEFAULT_SS58_PREFIX = 42;
+const DEFAULT_TOKEN_SYMBOL = 'DOT';
+
 // Dynamic import helper that TypeScript won't transform to require()
 // This is necessary because @polkadot-api/merkleize-metadata is an ESM-only package
 // eslint-disable-next-line @typescript-eslint/no-implied-eval
@@ -89,27 +93,27 @@ export class TransactionMetadataBlobService extends AbstractService {
 		const tokenSymbolRaw = properties.tokenSymbol.isSome ? properties.tokenSymbol.value : null;
 		const ss58Format = properties.ss58Format.isSome ? properties.ss58Format.value : null;
 
-		let decimals = 10;
+		let decimals = DEFAULT_DECIMALS;
 		if (tokenDecimalsRaw) {
 			const decimalsJson = tokenDecimalsRaw.toJSON();
 			if (Array.isArray(decimalsJson)) {
-				decimals = (decimalsJson[0] as number) ?? 10;
+				decimals = (decimalsJson[0] as number) ?? DEFAULT_DECIMALS;
 			} else if (typeof decimalsJson === 'number') {
 				decimals = decimalsJson;
 			}
 		}
 
-		let tokenSymbol = 'DOT';
+		let tokenSymbol = DEFAULT_TOKEN_SYMBOL;
 		if (tokenSymbolRaw) {
 			const symbolJson = tokenSymbolRaw.toJSON();
 			if (Array.isArray(symbolJson)) {
-				tokenSymbol = (symbolJson[0] as string) ?? 'DOT';
+				tokenSymbol = (symbolJson[0] as string) ?? DEFAULT_TOKEN_SYMBOL;
 			} else if (typeof symbolJson === 'string') {
 				tokenSymbol = symbolJson;
 			}
 		}
 
-		const base58Prefix = ss58Format?.toNumber() ?? 42;
+		const base58Prefix = ss58Format?.toNumber() ?? DEFAULT_SS58_PREFIX;
 
 		// Use dynamic import for ESM module compatibility
 		const merkleizeMetadata = await this.getMerkleizeMetadata();

src/types/requests.ts

@@ -60,6 +60,32 @@ export interface IMetadataBlobBody {
 	at?: string;
 }
 
+/**
+ * Parameters for generating metadata blob proof.
+ */
+export interface MetadataBlobParams {
+	/**
+	 * Full encoded extrinsic. Use this OR the individual parts.
+	 */
+	tx?: string;
+	/**
+	 * Optional tx additional signed data.
+	 */
+	txAdditionalSigned?: string;
+	/**
+	 * Call data. Use with includedInExtrinsic and includedInSignedData.
+	 */
+	callData?: string;
+	/**
+	 * Signed Extension data included in the extrinsic.
+	 */
+	includedInExtrinsic?: string;
+	/**
+	 * Signed Extension data included in the signature.
+	 */
+	includedInSignedData?: string;
+}
+
 /**
  * Body for the RequestHandlerContract. In other words, the body of the POST route that a message to a contract.
  */