fix: improve copytrack replay accuracy and add web account management

gonggz · claude · gonggz · commit 4b283216de1b · 2026-03-15T15:05:31.000-07:00
Copytrack:
- Add MERGE and SPLIT support to replay engine and stats
- Raise max_trades default from 10k to 100k across API, CLI, and web
- Update frontend button text and per-trade color coding for new types

Web:
- Add account create/delete/reset endpoints and Layout UI controls
- Add RequestValidationError handler for consistent 422 JSON envelope
- Fix client.ts error handling for non-JSON responses
- Add host: 0.0.0.0 to Vite dev server for LAN access

Co-Authored-By: Claude Opus 4.6 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/frontend/src/api/client.ts b/frontend/src/api/client.ts
@@ -17,9 +17,14 @@ function params(extra?: Record<string, string>): string {
 
 async function api<T>(url: string, init?: RequestInit): Promise<T> {
   const resp = await fetch(url, init)
-  const json: ApiResponse<T> = await resp.json()
+  let json: ApiResponse<T>
+  try {
+    json = await resp.json()
+  } catch {
+    throw new Error(`Server error (${resp.status})`)
+  }
   if (!json.ok) {
-    throw new Error(json.error || 'Unknown error')
+    throw new Error(json.error || `Request failed (${resp.status})`)
   }
   return json.data
 }
@@ -95,3 +100,17 @@ export const fetchCopytrackReplay = (replayId: number) =>
 // Accounts
 export const fetchAccounts = () => api<string[]>('/api/accounts')
 export const fetchAccountsCompare = () => api<(Stats & { account: string })[]>('/api/accounts/compare')
+export const createAccount = (name: string, balance: number) =>
+  api<unknown>('/api/accounts/create', {
+    method: 'POST',
+    headers: { 'Content-Type': 'application/json' },
+    body: JSON.stringify({ name, balance }),
+  })
+export const deleteAccount = (name: string) =>
+  api<unknown>(`/api/accounts/${encodeURIComponent(name)}`, { method: 'DELETE' })
+export const resetAccount = () =>
+  api<unknown>(`/api/accounts/reset?${params()}`, {
+    method: 'POST',
+    headers: { 'Content-Type': 'application/json' },
+    body: JSON.stringify({ confirm: true }),
+  })
diff --git a/frontend/src/components/Layout.tsx b/frontend/src/components/Layout.tsx
@@ -1,6 +1,6 @@
 import { NavLink, Outlet, useOutletContext } from 'react-router-dom'
 import { useCallback, useEffect, useRef, useState } from 'react'
-import { fetchAccounts, fetchBalance, setAccount, getAccount } from '../api/client'
+import { fetchAccounts, fetchBalance, setAccount, getAccount, resetAccount, createAccount, deleteAccount } from '../api/client'
 import type { Balance } from '../api/types'
 
 export default function Layout() {
@@ -9,11 +9,17 @@ export default function Layout() {
   const [balance, setBalance] = useState<Balance | null>(null)
   const [flash, setFlash] = useState(false)
   const prevCash = useRef<number | null>(null)
+  const [showCreate, setShowCreate] = useState(false)
+  const [newName, setNewName] = useState('')
+  const [newBalance, setNewBalance] = useState('10000')
+  const [creating, setCreating] = useState(false)
 
-  useEffect(() => {
+  const refreshAccounts = useCallback(() => {
     fetchAccounts().then(setAccounts).catch(() => {})
   }, [])
 
+  useEffect(() => { refreshAccounts() }, [refreshAccounts])
+
   const refreshBalance = useCallback(() => {
     fetchBalance().then(b => {
       if (prevCash.current !== null && b.cash !== prevCash.current) {
@@ -78,8 +84,98 @@ export default function Layout() {
           >
             {accounts.map(a => <option key={a} value={a}>{a}</option>)}
           </select>
+          <button
+            onClick={() => setShowCreate(!showCreate)}
+            title="Create account"
+            style={{
+              padding: '2px 8px', border: '1px solid #ccc', borderRadius: 4, background: '#f8f8f8',
+              cursor: 'pointer', fontSize: '0.9em', fontWeight: 600,
+            }}
+          >+</button>
+          {selected !== 'default' && (
+            <button
+              onClick={async () => {
+                if (!confirm(`Delete account "${selected}"? This cannot be undone.`)) return
+                try {
+                  await deleteAccount(selected)
+                  setSelected('default')
+                  refreshAccounts()
+                } catch { /* ignore */ }
+              }}
+              title="Delete account"
+              style={{
+                padding: '2px 8px', border: '1px solid #fca5a5', borderRadius: 4, background: '#fef2f2',
+                cursor: 'pointer', fontSize: '0.8em', color: '#dc2626',
+              }}
+            >Delete</button>
+          )}
+          <button
+            onClick={async () => {
+              if (!confirm(`Reset account "${selected}"? All trades and positions will be cleared.`)) return
+              try {
+                await resetAccount()
+                prevCash.current = null
+                refreshBalance()
+              } catch { /* ignore */ }
+            }}
+            title="Reset account"
+            style={{
+              padding: '2px 8px', border: '1px solid #ddd', borderRadius: 4, background: '#f8f8f8',
+              cursor: 'pointer', fontSize: '0.8em', color: '#888',
+            }}
+          >Reset</button>
         </div>
       </nav>
+
+      {showCreate && (
+        <div style={{
+          background: 'white', borderBottom: '1px solid #e5e7eb', padding: '12px 24px',
+          display: 'flex', gap: 12, alignItems: 'center',
+        }}>
+          <input
+            value={newName}
+            onChange={e => setNewName(e.target.value)}
+            placeholder="Account name"
+            style={{ padding: '6px 10px', borderRadius: 4, border: '1px solid #ccc', fontSize: '0.85em' }}
+          />
+          <input
+            type="number"
+            value={newBalance}
+            onChange={e => setNewBalance(e.target.value)}
+            placeholder="Balance"
+            style={{ padding: '6px 10px', borderRadius: 4, border: '1px solid #ccc', fontSize: '0.85em', width: 100 }}
+          />
+          <button
+            onClick={async () => {
+              if (!newName.trim()) return
+              setCreating(true)
+              try {
+                await createAccount(newName.trim(), parseFloat(newBalance) || 10000)
+                const name = newName.trim()
+                setNewName('')
+                setNewBalance('10000')
+                setShowCreate(false)
+                await refreshAccounts()
+                setSelected(name)
+              } catch { /* ignore */ }
+              setCreating(false)
+            }}
+            disabled={creating || !newName.trim()}
+            style={{
+              padding: '6px 16px', border: 'none', borderRadius: 4, background: '#4f46e5',
+              color: 'white', cursor: creating ? 'not-allowed' : 'pointer', fontSize: '0.85em',
+            }}
+          >{creating ? 'Creating...' : 'Create'}</button>
+          <button
+            onClick={() => setShowCreate(false)}
+            style={{
+              padding: '6px 12px', border: '1px solid #ccc', borderRadius: 4, background: 'white',
+              cursor: 'pointer', fontSize: '0.85em', color: '#888',
+            }}
+          >Cancel</button>
+        </div>
+      )}
+
       <main style={{ maxWidth: 1200, margin: '0 auto', padding: '20px 24px' }}>
         <Outlet context={{ refreshBalance }} />
       </main>
diff --git a/frontend/src/pages/Copytrack.tsx b/frontend/src/pages/Copytrack.tsx
@@ -159,7 +159,7 @@ export default function Copytrack() {
                     opacity: fetchingAddr === t.address ? 0.6 : 1,
                   }}
                 >
-                  {fetchingAddr === t.address ? 'Fetching...' : 'Fetch (last 10k)'}
+                  {fetchingAddr === t.address ? 'Fetching...' : 'Fetch All'}
                 </button>
                 <span style={{ fontSize: '0.75em', color: '#888' }}>Replay last</span>
                 <input
@@ -394,11 +394,11 @@ export default function Copytrack() {
                     }
                     const openSlugs = new Set(
                       Object.entries(slugSides)
-                        .filter(([, sides]) => sides.has('BUY') && !sides.has('SELL') && !sides.has('REDEEM'))
+                        .filter(([, sides]) => (sides.has('BUY') || sides.has('SPLIT')) && !sides.has('SELL') && !sides.has('REDEEM') && !sides.has('MERGE'))
                         .map(([slug]) => slug)
                     )
                     return perTrade.map((t, i) => {
-                      const sideColor = t.side === 'BUY' ? '#16a34a' : t.side === 'REDEEM' ? '#7c3aed' : '#dc2626'
+                      const sideColor = t.side === 'BUY' ? '#16a34a' : t.side === 'SELL' ? '#dc2626' : t.side === 'REDEEM' ? '#7c3aed' : t.side === 'SPLIT' ? '#0891b2' : t.side === 'MERGE' ? '#ea580c' : '#888'
                       const isOpen = openSlugs.has(t.market_slug)
                       return (
                         <tr key={i} style={{ borderBottom: '1px solid #f0f0f0', background: isOpen ? '#fffbeb' : 'transparent' }}>
diff --git a/frontend/vite.config.ts b/frontend/vite.config.ts
@@ -5,6 +5,7 @@ export default defineConfig({
   plugins: [react()],
   server: {
     port: 5173,
+    host: '0.0.0.0',
     proxy: {
       '/api': {
         target: 'http://127.0.0.1:8000',
diff --git a/pm_trader/cli.py b/pm_trader/cli.py
@@ -916,7 +916,7 @@ def copytrack_trades(identifier: str, limit: int) -> None:
 
 @copytrack.command("fetch")
 @click.argument("identifier")
-@click.option("--max-trades", type=int, default=10_000, help="Max trades to fetch.")
+@click.option("--max-trades", type=int, default=100_000, help="Max trades to fetch.")
 @click.pass_context
 def copytrack_fetch_cmd(ctx: click.Context, identifier: str, max_trades: int) -> None:
     """Fetch a target's trade history and store locally."""
diff --git a/pm_trader/copytrack.py b/pm_trader/copytrack.py
@@ -35,14 +35,19 @@ def compute_original_stats(trades: list[dict]) -> dict:
     buys = [t for t in trades if t.get("side") == "BUY"]
     sells = [t for t in trades if t.get("side") == "SELL"]
     redeems = [t for t in trades if t.get("type") == "REDEEM"]
-    total_invested = sum(t.get("usdcSize", 0.0) for t in buys)
+    splits = [t for t in trades if t.get("side") == "SPLIT"]
+    merges = [t for t in trades if t.get("side") == "MERGE"]
+    # SPLIT spends $1 per share → outflow; MERGE returns $1 per share → inflow
+    total_invested = (sum(t.get("usdcSize", 0.0) for t in buys)
+                      + sum(t.get("usdcSize", 0.0) for t in splits))
     total_returned = (sum(t.get("usdcSize", 0.0) for t in sells)
-                      + sum(t.get("usdcSize", 0.0) for t in redeems))
+                      + sum(t.get("usdcSize", 0.0) for t in redeems)
+                      + sum(t.get("usdcSize", 0.0) for t in merges))
 
     pnl = total_returned - total_invested
     roi_pct = (pnl / total_invested * 100) if total_invested > 0 else 0.0
     return {"total_trades": len(trades), "buy_count": len(buys), "sell_count": len(sells),
-            "redeem_count": len(redeems),
+            "redeem_count": len(redeems), "split_count": len(splits), "merge_count": len(merges),
             "total_invested": total_invested, "total_returned": total_returned,
             "pnl": pnl, "roi_pct": roi_pct}
 
@@ -52,7 +57,7 @@ def fetch(
     db: "Database",
     data_client: "PolymarketDataClient",
     *,
-    max_trades: int = 10_000,
+    max_trades: int = 100_000,
 ) -> dict:
     """Fetch a user's trades and redeems from API and store in DB.
 
@@ -253,6 +258,77 @@ def replay(
             engine.db.update_cash(account.cash + replay_usd_sell)
             replayed.append(trade)
             replay_usd_final = replay_usd_sell
+
+        elif side == "SPLIT":
+            # SPLIT: spend $1 per share → get 1 YES + 1 NO share each
+            split_cost = compute_replay_amount(original_usd, target.sizing)
+            account = engine.get_account()
+            if account.cash < split_cost:
+                skipped.append({**orig, "reason": f"Insufficient balance for SPLIT: need ${split_cost:.2f}, have ${account.cash:.2f}"})
+                continue
+            split_shares = split_cost  # $1 per share pair
+
+            for split_outcome in ("yes", "no"):
+                existing = engine.db.get_position(condition_id, split_outcome)
+                if existing and existing.shares > 0:
+                    total_shares = existing.shares + split_shares
+                    total_cost = existing.total_cost + split_cost
+                    new_avg = total_cost / total_shares
+                else:
+                    total_shares = split_shares
+                    total_cost = split_cost
+                    new_avg = 1.0
+                engine.db.upsert_position(
+                    market_condition_id=condition_id, market_slug=slug,
+                    market_question=title, outcome=split_outcome,
+                    shares=total_shares, avg_entry_price=new_avg, total_cost=total_cost)
+
+            engine.db.update_cash(account.cash - split_cost)
+            trade = engine.db.insert_trade(
+                market_condition_id=condition_id, market_slug=slug,
+                market_question=title, event_slug=event_slug,
+                outcome="split", side="buy", order_type="fok",
+                avg_price=1.0, amount_usd=split_cost,
+                shares=split_shares, fee_rate_bps=0, fee=0.0,
+                slippage=0.0, levels_filled=1, is_partial=False)
+            replayed.append(trade)
+            replay_usd_final = split_cost
+
+        elif side == "MERGE":
+            # MERGE: burn 1 YES + 1 NO share → get $1 back
+            yes_pos = engine.db.get_position(condition_id, "yes")
+            no_pos = engine.db.get_position(condition_id, "no")
+            if not yes_pos or yes_pos.shares <= 0 or not no_pos or no_pos.shares <= 0:
+                skipped.append({**orig, "reason": "Need both YES and NO positions to merge"})
+                continue
+
+            merge_shares = min(original_shares, yes_pos.shares, no_pos.shares)
+            merge_usd = merge_shares  # $1 per merged pair
+
+            for merge_outcome, pos in (("yes", yes_pos), ("no", no_pos)):
+                remaining_shares = pos.shares - merge_shares
+                cost_of_merged = merge_shares * pos.avg_entry_price
+                remaining_cost = pos.total_cost - cost_of_merged
+                realized = (merge_usd / 2) - cost_of_merged  # each side gets half the $1
+                engine.db.upsert_position(
+                    market_condition_id=condition_id, market_slug=slug,
+                    market_question=title, outcome=merge_outcome,
+                    shares=remaining_shares, avg_entry_price=pos.avg_entry_price,
+                    total_cost=max(remaining_cost, 0.0),
+                    realized_pnl=pos.realized_pnl + realized)
+
+            account = engine.get_account()
+            engine.db.update_cash(account.cash + merge_usd)
+            trade = engine.db.insert_trade(
+                market_condition_id=condition_id, market_slug=slug,
+                market_question=title, event_slug=event_slug,
+                outcome="merge", side="sell", order_type="fok",
+                avg_price=1.0, amount_usd=merge_usd,
+                shares=merge_shares, fee_rate_bps=0, fee=0.0,
+                slippage=0.0, levels_filled=1, is_partial=False)
+            replayed.append(trade)
+            replay_usd_final = merge_usd
+
         else:
             skipped.append({**orig, "reason": f"Unknown side: {side}"})
             continue
diff --git a/pm_trader/data_api.py b/pm_trader/data_api.py
@@ -68,7 +68,7 @@ def get_all_trades(
         *,
         start: int | None = None,
         end: int | None = None,
-        max_trades: int = 10_000,
+        max_trades: int = 100_000,
         type: str = "TRADE",
     ) -> list[dict]:
         """Fetch complete activity history with auto-pagination."""
diff --git a/pm_trader/web/app.py b/pm_trader/web/app.py
@@ -1,6 +1,7 @@
 from __future__ import annotations
 
 from fastapi import FastAPI, Request
+from fastapi.exceptions import RequestValidationError
 from fastapi.middleware.cors import CORSMiddleware
 from fastapi.responses import JSONResponse
 
@@ -16,6 +17,15 @@ def create_app() -> FastAPI:
         allow_headers=["*"],
     )
 
+    @app.exception_handler(RequestValidationError)
+    async def validation_error_handler(request: Request, exc: RequestValidationError) -> JSONResponse:
+        errors = exc.errors()
+        msg = "; ".join(f"{e['loc'][-1]}: {e['msg']}" for e in errors) if errors else "Validation error"
+        return JSONResponse(
+            status_code=422,
+            content={"ok": False, "error": msg, "code": "VALIDATION_ERROR"},
+        )
+
     @app.exception_handler(SimError)
     async def sim_error_handler(request: Request, exc: SimError) -> JSONResponse:
         return JSONResponse(
diff --git a/pm_trader/web/routes/accounts.py b/pm_trader/web/routes/accounts.py
diff --git a/pm_trader/web/routes/copytrack.py b/pm_trader/web/routes/copytrack.py
