fix: move cache default constants to Configuration.Builder for public access

Author: evtimDev

parse/src/main/java/com/parse/Parse.java

@@ -602,6 +602,10 @@ private Configuration(Builder builder) {
 
         /** Allows for simple constructing of a {@code Configuration} object. */
         public static final class Builder {
+            public static final int DEFAULT_MAX_KEY_VALUE_CACHE_BYTES =
+                ParseKeyValueCache.DEFAULT_MAX_KEY_VALUE_CACHE_BYTES;
+            public static final int DEFAULT_MAX_KEY_VALUE_CACHE_FILES =
+                ParseKeyValueCache.DEFAULT_MAX_KEY_VALUE_CACHE_FILES;
             private final Context context;
             private String applicationId;
             private String clientKey;
@@ -610,8 +614,8 @@ public static final class Builder {
             private boolean allowCustomObjectId;
             private OkHttpClient.Builder clientBuilder;
             private int maxRetries = DEFAULT_MAX_RETRIES;
-            private int maxKeyValueCacheBytes = ParseKeyValueCache.DEFAULT_MAX_KEY_VALUE_CACHE_BYTES;
-            private int maxKeyValueCacheFiles = ParseKeyValueCache.DEFAULT_MAX_KEY_VALUE_CACHE_FILES;
+            private int maxKeyValueCacheBytes = DEFAULT_MAX_KEY_VALUE_CACHE_BYTES;
+            private int maxKeyValueCacheFiles = DEFAULT_MAX_KEY_VALUE_CACHE_FILES;
 
             /**
              * Initialize a bulider with a given context.
@@ -717,7 +721,7 @@ public Builder maxRetries(int maxRetries) {
 
             /**
              * Set the maximum amount of bytes to use for the Parse cache on disk.
-             * Defaults to {@link ParseKeyValueCache#DEFAULT_MAX_KEY_VALUE_CACHE_BYTES}.
+             * Defaults to {@link Builder#DEFAULT_MAX_KEY_VALUE_CACHE_BYTES}.
              *
              * @param maxKeyValueCacheBytes The maximum number of bytes to use for the cache.
              * @return The same builder, for easy chaining.
@@ -729,7 +733,7 @@ public Builder maxKeyValueCacheBytes(int maxKeyValueCacheBytes) {
 
             /**
              * Set the maximum number of files to store in the Parse cache on disk.
-             * Defaults to {@link ParseKeyValueCache#DEFAULT_MAX_KEY_VALUE_CACHE_FILES}.
+             * Defaults to {@link Builder#DEFAULT_MAX_KEY_VALUE_CACHE_FILES}.
              *
              * @param maxKeyValueCacheFiles The maximum number of files to store in the cache.
              * @return The same builder, for easy chaining.

parse/src/main/java/com/parse/ParseKeyValueCache.java

@@ -22,10 +22,10 @@ class ParseKeyValueCache {
 
     // We limit the cache to 2MB because that's about what the default browser
     // uses.
-    public static final int DEFAULT_MAX_KEY_VALUE_CACHE_BYTES = 2 * 1024 * 1024;
+    /* package */ static final int DEFAULT_MAX_KEY_VALUE_CACHE_BYTES = 2 * 1024 * 1024;
     // We limit to 1000 cache files to avoid taking too long while scanning the
     // cache
-    public static final int DEFAULT_MAX_KEY_VALUE_CACHE_FILES = 1000;
+    /* package */ static final int DEFAULT_MAX_KEY_VALUE_CACHE_FILES = 1000;
     private static final String TAG = "ParseKeyValueCache";
     private static final String DIR_NAME = "ParseKeyValueCache";
     /** Prevent multiple threads from modifying the cache at the same time. */

parse/src/test/java/com/parse/ParseKeyValueCacheTest.java

@@ -100,6 +100,10 @@ public void testDefaultCacheConfiguration() {
             ParseKeyValueCache.maxKeyValueCacheBytes);
         assertEquals(ParseKeyValueCache.DEFAULT_MAX_KEY_VALUE_CACHE_FILES,
             ParseKeyValueCache.maxKeyValueCacheFiles);
+        assertEquals(ParseKeyValueCache.DEFAULT_MAX_KEY_VALUE_CACHE_BYTES,
+            Parse.Configuration.Builder.DEFAULT_MAX_KEY_VALUE_CACHE_BYTES);
+        assertEquals(ParseKeyValueCache.DEFAULT_MAX_KEY_VALUE_CACHE_FILES,
+            Parse.Configuration.Builder.DEFAULT_MAX_KEY_VALUE_CACHE_FILES);
     }
 
     @Test