Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions packages/dart/lib/src/objects/parse_user.dart
Original file line number Diff line number Diff line change
Expand Up @@ -493,8 +493,10 @@ class ParseUser extends ParseObject implements ParseCloneable {
if (objectId == null) {
return await signUp();
} else {
final String? tokenBefore = sessionToken;
final ParseResponse response = await super.save();
if (response.success) {
_adoptResponseSessionTokenIfChanged(tokenBefore);
await _onResponseSuccess();
}
return response;
Expand All @@ -506,14 +508,29 @@ class ParseUser extends ParseObject implements ParseCloneable {
if (objectId == null) {
return await signUp();
} else {
final String? tokenBefore = sessionToken;
final ParseResponse response = await super.update();
if (response.success) {
_adoptResponseSessionTokenIfChanged(tokenBefore);
await _onResponseSuccess();
}
return response;
}
}

/// Adopt a new sessionToken from a save/update response. Parse Server
/// mints a fresh session when `password` is set on an existing _User
/// (revokeSessionOnPasswordReset, current default in 9.x); the prior
/// session is destroyed server-side, so the global session must be
/// updated or subsequent requests will fail with invalidSessionToken.
/// Mirrors iOS PFUser's _mergeFromServerWithResult.
void _adoptResponseSessionTokenIfChanged(String? tokenBefore) {
final String? tokenAfter = sessionToken;
if (tokenAfter == null || tokenAfter.isEmpty) return;
if (tokenAfter == tokenBefore) return;
ParseCoreData().setSessionId(tokenAfter);
}

Future<void> _onResponseSuccess() async {
await saveInStorage(keyParseStoreUser);
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,145 @@
import 'dart:convert';

import 'package:mockito/mockito.dart';
import 'package:parse_server_sdk/parse_server_sdk.dart';
import 'package:test/test.dart';

import '../../../parse_query_test.mocks.dart';
import '../../../test_utils.dart';

void main() {
setUpAll(() async {
await initializeParse();
});

group('ParseUser save()/update() — sessionToken adoption from response', () {
late MockParseClient client;

const String userObjectId = 'sess123';
final String putPath = Uri.parse(
'$serverUrl$keyEndPointClasses$keyClassUser/$userObjectId',
).toString();

setUp(() {
client = MockParseClient();
});

test(
'when a save() response carries a sessionToken different from the '
'one sent, the SDK installs it as the global session token. Parse '
'Server mints a fresh session when password is set on an existing '
'_User; the prior session is destroyed server-side, so the global '
'session must be updated or subsequent requests fail with '
'invalidSessionToken',
() async {
ParseCoreData().setSessionId('r:priorSession');

final ParseUser user = ParseUser(null, null, null, client: client);
user.fromJson(<String, dynamic>{
keyVarObjectId: userObjectId,
keyVarSessionToken: 'r:priorSession',
keyVarUsername: 'alice@example.com',
});

when(
client.put(
putPath,
options: anyNamed('options'),
data: anyNamed('data'),
),
).thenAnswer(
(_) async => ParseNetworkResponse(
statusCode: 200,
data: jsonEncode(<String, dynamic>{
keyVarUpdatedAt: '2026-04-28T12:00:01.000Z',
keyVarSessionToken: 'r:freshSession',
}),
),
);

user.password = 'hunter2';

final ParseResponse response = await user.save();

expect(response.success, isTrue);
expect(ParseCoreData().sessionId, equals('r:freshSession'));
},
);

test(
'when a save() response does NOT carry a sessionToken, the global '
'session is left untouched. the previously-cached local sessionToken '
'on the user object must not be re-promoted to global state',
() async {
ParseCoreData().setSessionId('r:stableSession');

final ParseUser user = ParseUser(null, null, null, client: client);
user.fromJson(<String, dynamic>{
keyVarObjectId: userObjectId,
keyVarSessionToken: 'r:stableSession',
keyVarUsername: 'alice@example.com',
});

when(
client.put(
putPath,
options: anyNamed('options'),
data: anyNamed('data'),
),
).thenAnswer(
(_) async => ParseNetworkResponse(
statusCode: 200,
data: jsonEncode(<String, dynamic>{
keyVarUpdatedAt: '2026-04-28T12:00:01.000Z',
}),
),
);

user.set<String>('localeIdentifier', 'en-US');

await user.save();

expect(ParseCoreData().sessionId, equals('r:stableSession'));
},
);

test(
'update() adopts a new sessionToken from the response. save() and '
'update() are independent entry points, both need to install the '
'token to keep the active session in sync with the server',
() async {
ParseCoreData().setSessionId('r:priorSession');

final ParseUser user = ParseUser(null, null, null, client: client);
user.fromJson(<String, dynamic>{
keyVarObjectId: userObjectId,
keyVarSessionToken: 'r:priorSession',
keyVarUsername: 'alice@example.com',
});

when(
client.put(
putPath,
options: anyNamed('options'),
data: anyNamed('data'),
),
).thenAnswer(
(_) async => ParseNetworkResponse(
statusCode: 200,
data: jsonEncode(<String, dynamic>{
keyVarUpdatedAt: '2026-04-28T12:00:01.000Z',
keyVarSessionToken: 'r:freshSession',
}),
),
);

user.password = 'hunter2';

final ParseResponse response = await user.update();

expect(response.success, isTrue);
expect(ParseCoreData().sessionId, equals('r:freshSession'));
},
);
});
}
Loading