Add support for tracer particles#102
Conversation
filled in values for s_i
small edits in the par_reduce in the computation of the correlations
fixed a bug in computing the correlations
mfournier01
left a comment
There was a problem hiding this comment.
Left a few comments for clarifications of what the code is doing but I haven't found any typo. The documentation is pretty clear.
| // First order operator split tracer advection | ||
| if (stage == integrator->nstages && tracers_pkg->Param<bool>("enabled")) { | ||
| const std::string swarm_name = "tracers"; | ||
| TaskRegion &sync_region_tr = tc.AddRegion(1); |
There was a problem hiding this comment.
Not yet clear to me: why do we need only one tacklist per region in that case?
There was a problem hiding this comment.
I'm actually not sure if this is 100% required, but as long as we're running with a single host thread this should not make any difference.
BenWibking
left a comment
There was a problem hiding this comment.
Minor comments inline.
Also, I added a plotting script in scripts/ based on the example you provided in the docs. I also uploaded an input file that included a <tracers> block, since it looked like none of the existing problems had one.
| tracers_variables = id, x, y, z, rho | ||
| ``` | ||
|
|
||
| Tracers can be read/processed by the `phdf` package shipped with the Parthenon submodule. |
There was a problem hiding this comment.
Are particles included in the XDMF output? If not, I think it would be helpful to be explicit that this is the case.
There was a problem hiding this comment.
They're currently not. I added the info.
There was a problem hiding this comment.
Actually, I take that back. They can be written to xdmf but it has to be manually activated.
I now extended the example input file and doc.
|
Looks nice! tracers.mp4 |

Alright, I'm done with the cleanup,i.e., I
It'd be great if you, @BenWibking and @mfournier01 could review from the "all the basic bases are covered" point of view.
There's some stuff left I/we may want to address (in the near future) but I think it's cleaner to address those in separate smaller PRs.
I'm particularly interested in @mfournier01 feedback from the "documentation" and "is it clear what's going on" point of view as you're a new developer that will have to modify the code very soon.
So I'd be happy to provide more info in the code/docs already in this PR to make things clearer where required.
Future cleanup items:
Python analysis/plotting example:
results in

with lookback times available in
from parameters in an output block like
and tracers enabled by an additional block as