Extend the eligibility for the "Forever" product (#1377)

The condition for showing .complete was "no purchased products". Make it
"any purchases but complete, core/essentials, and appletv", so that it
excludes some very old legacy products.

Author: keeshux

Packages/App/Sources/CommonIAP/Domain/AppProduct+Features.swift

@@ -104,6 +104,17 @@ extension AppProduct {
         }
     }
 
+    public var isEssentials: Bool {
+        switch self {
+        case .Essentials.iOS,
+                .Essentials.macOS,
+                .Essentials.iOS_macOS:
+            return true
+        default:
+            return false
+        }
+    }
+
     public var isRecurring: Bool {
         switch self {
         case .Complete.Recurring.monthly, .Complete.Recurring.yearly:

Packages/App/Sources/CommonLibrary/IAP/IAPManager+Suggestions.swift

@@ -102,9 +102,7 @@ extension IAPManager {
             }
         }
 
-        // TODO: ###, this condition may be improved by excluding very old products
-        let isEligibleForComplete = purchasedProducts.isEmpty
-        if filter != .excludingComplete && isEligibleForComplete {
+        if filter != .excludingComplete && purchasedProducts.isEligibleForComplete {
             suggested.insert(.Complete.Recurring.yearly)
             suggested.insert(.Complete.Recurring.monthly)
             suggested.insert(.Complete.OneTime.lifetime)
@@ -113,3 +111,11 @@ extension IAPManager {
         return suggested
     }
 }
+
+private extension Collection where Element == AppProduct {
+    var isEligibleForComplete: Bool {
+        !contains {
+            $0.isComplete || $0.isEssentials || $0 == .Features.appleTV
+        }
+    }
+}

Packages/App/Tests/CommonLibraryTests/Business/IAPManagerTests.swift

@@ -361,8 +361,26 @@ extension IAPManagerTests {
         ])
     }
 
-    func test_givenNonFree_whenWithComplete_thenSuggestsEssentials() async {
+    func test_givenOldProducts_whenWithComplete_thenSuggestsEssentialsAndComplete() async {
         let sut = await IAPManager(products: [.Features.trustedNetworks])
+        XCTAssertEqual(sut.suggestedProducts(for: .iOS, filter: .includingComplete), [
+            .Essentials.iOS_macOS,
+            .Essentials.iOS,
+            .Complete.OneTime.lifetime,
+            .Complete.Recurring.monthly,
+            .Complete.Recurring.yearly
+        ])
+        XCTAssertEqual(sut.suggestedProducts(for: .macOS, filter: .includingComplete), [
+            .Essentials.iOS_macOS,
+            .Essentials.macOS,
+            .Complete.OneTime.lifetime,
+            .Complete.Recurring.monthly,
+            .Complete.Recurring.yearly
+        ])
+    }
+
+    func test_givenNewProducts_whenWithComplete_thenSuggestsEssentials() async {
+        let sut = await IAPManager(products: [.Features.appleTV])
         XCTAssertEqual(sut.suggestedProducts(for: .iOS, filter: .includingComplete), [
             .Essentials.iOS_macOS,
             .Essentials.iOS