style: fix ruff linting errors (imports, comparisons)

Author: parvenuprompting

alembic/env.py

@@ -1,6 +1,7 @@
 """Alembic environment configuration for async SQLAlchemy."""
 import asyncio
 from logging.config import fileConfig
+from typing import Any
 
 from sqlalchemy import pool
 from sqlalchemy.ext.asyncio import async_engine_from_config
@@ -39,9 +40,6 @@ def run_migrations_offline() -> None:
         context.run_migrations()
 
 
-from typing import Any
-
-
 def do_run_migrations(connection: Any) -> None:
     """Run migrations with connection."""
     context.configure(connection=connection, target_metadata=target_metadata)

tests/integration/test_init_db.py

@@ -28,7 +28,7 @@ async def test_create_initial_admin(test_session: AsyncSession) -> None:
         result = await test_session.execute(select(User).where(User.email == "admin@example.com"))
         admin = result.scalars().first()
         assert admin is not None
-        assert admin.is_superuser == True
+        assert admin.is_superuser == True  # noqa: E712
         assert admin.email == "admin@example.com"
 
         # Run again (idempotency)

tests/unit/test_content_service_extended.py

@@ -1,12 +1,12 @@
-import pytest
-from unittest.mock import AsyncMock, patch, MagicMock
+from unittest.mock import AsyncMock, MagicMock, patch
 from uuid import uuid4
+
+import pytest
 from fastapi import HTTPException
 
 from app.models.client import Client
+from app.models.guide import ComplexityLevel, Guide
 from app.models.topic import Topic
-from app.models.guide import Guide, ComplexityLevel
-from app.schemas.topic import TopicCreate
 from app.schemas.guide import GuideCreate
 from app.services.content import content_service
 
@@ -46,15 +46,17 @@ async def test_create_guide_success() -> None:
     )
 
     # We need to mock get_topic to succeed (it checks access)
-    with patch.object(content_service, "get_topic", return_value=topic) as mock_get_topic:
-        with patch("app.services.content.guide_repo.get_by_slug", return_value=None):
-            mock_session.add = MagicMock()
+    with (
+        patch.object(content_service, "get_topic", return_value=topic) as mock_get_topic,
+        patch("app.services.content.guide_repo.get_by_slug", return_value=None),
+    ):
+        mock_session.add = MagicMock()
 
-            result = await content_service.create_guide(mock_session, client, guide_in)
+        result = await content_service.create_guide(mock_session, client, guide_in)
 
-            assert result.title == "Guide 1"
-            assert result.client_id == client.id
-            mock_get_topic.assert_awaited_once_with(mock_session, client, topic.id)
+        assert result.title == "Guide 1"
+        assert result.client_id == client.id
+        mock_get_topic.assert_awaited_once_with(mock_session, client, topic.id)
 
 
 @pytest.mark.asyncio()
@@ -73,12 +75,13 @@ async def test_create_guide_slug_collision() -> None:
         complexity_level=ComplexityLevel.BEGINNER,
     )
 
-    with patch.object(content_service, "get_topic", return_value=topic):
-        # Return an existing object to trigger collision
-        with patch("app.services.content.guide_repo.get_by_slug", return_value=Guide()):
-            with pytest.raises(HTTPException) as exc:
-                await content_service.create_guide(mock_session, client, guide_in)
-            assert exc.value.status_code == 400
+    with (
+        patch.object(content_service, "get_topic", return_value=topic),
+        patch("app.services.content.guide_repo.get_by_slug", return_value=Guide()),
+    ):
+        with pytest.raises(HTTPException) as exc:
+            await content_service.create_guide(mock_session, client, guide_in)
+        assert exc.value.status_code == 400
 
 
 @pytest.mark.asyncio()

tests/unit/test_crud_base.py

@@ -1,5 +1,5 @@
 """Unit tests for CRUDBase generic repository."""
-from uuid import uuid4, UUID
+from uuid import uuid4
 
 import pytest
 from pydantic import BaseModel, EmailStr
@@ -48,8 +48,8 @@ async def test_create_user(self, test_session: AsyncSession) -> None:
         # Assert
         assert created_user.id is not None
         assert created_user.email == "newuser@example.com"
-        assert created_user.is_active == True
-        assert created_user.is_superuser == False
+        assert created_user.is_active == True  # noqa: E712
+        assert created_user.is_superuser == False  # noqa: E712
 
     async def test_get_user(self, test_session: AsyncSession, test_user: User) -> None:
         """Test retrieving a user by ID."""
@@ -119,7 +119,7 @@ async def test_update_user(self, test_session: AsyncSession, test_user: User) ->
         # Assert
         assert updated_user.id == test_user.id
         assert updated_user.email == "updated@example.com"
-        assert updated_user.is_active == False
+        assert updated_user.is_active == False  # noqa: E712
 
     async def test_update_user_with_dict(self, test_session: AsyncSession, test_user: User) -> None:
         """Test updating a user with a dictionary."""
@@ -130,7 +130,7 @@ async def test_update_user_with_dict(self, test_session: AsyncSession, test_user
         updated_user = await user_crud.update(test_session, db_obj=test_user, obj_in=update_data)
 
         # Assert
-        assert updated_user.is_superuser == True
+        assert updated_user.is_superuser == True  # noqa: E712
         assert updated_user.email == test_user.email  # Unchanged
 
     async def test_partial_update(self, test_session: AsyncSession, test_user: User) -> None:
@@ -144,7 +144,7 @@ async def test_partial_update(self, test_session: AsyncSession, test_user: User)
 
         # Assert
         assert updated_user.email == original_email  # Unchanged
-        assert updated_user.is_active == False  # Changed
+        assert updated_user.is_active == False  # noqa: E712
 
     async def test_delete_user(self, test_session: AsyncSession, test_user: User) -> None:
         """Test deleting a user."""