fix lint

Author: nqmgaming

app/src/main/AndroidManifest.xml

@@ -64,10 +64,10 @@
                 <category android:name="android.intent.category.LAUNCHER" />
             </intent-filter>
 
-            <!-- Splits -->
+            <!-- Splits + single APK by file extension -->
             <intent-filter>
                 <action android:name="android.intent.action.VIEW" />
-
+                <action android:name="android.intent.action.INSTALL_PACKAGE" />
                 <category android:name="android.intent.category.DEFAULT" />
                 <category android:name="android.intent.category.BROWSABLE" />
 
@@ -76,6 +76,17 @@
                 <data android:host="*" />
                 <data android:mimeType="*/*" />
 
+                <data android:pathPattern=".*\\.apk" />
+                <data android:pathPattern=".*\\..*\\.apk" />
+                <data android:pathPattern=".*\\..*\\..*\\.apk" />
+                <data android:pathPattern=".*\\..*\\..*\\..*\\.apk" />
+                <data android:pathPattern=".*\\..*\\..*\\..*\\..*\\.apk" />
+                <data android:pathPattern=".*\\..*\\..*\\..*\\..*\\..*\\.apk" />
+                <data android:pathPattern=".*\\..*\\..*\\..*\\..*\\..*\\..*\\.apk" />
+                <data android:pathPattern=".*\\..*\\..*\\..*\\..*\\..*\\..*\\..*\\.apk" />
+                <data android:pathPattern=".*\\..*\\..*\\..*\\..*\\..*\\..*\\..*\\..*\\.apk" />
+                <data android:pathPattern=".*\\..*\\..*\\..*\\..*\\..*\\..*\\..*\\..*\\..*\\.apk" />
+
                 <data android:pathPattern=".*\\.apks" />
                 <data android:pathPattern=".*\\..*\\.apks" />
                 <data android:pathPattern=".*\\..*\\..*\\.apks" />

app/src/main/java/app/pwhs/universalinstaller/data/remote/PackageDownloadService.kt

@@ -8,8 +8,6 @@ import io.ktor.http.HttpHeaders
 import io.ktor.http.contentLength
 import io.ktor.http.isSuccess
 import io.ktor.utils.io.ByteReadChannel
-import io.ktor.utils.io.core.isEmpty
-import io.ktor.utils.io.core.readBytes
 import io.ktor.utils.io.readRemaining
 import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.withContext

app/src/main/java/app/pwhs/universalinstaller/data/remote/VirusTotalService.kt

@@ -230,8 +230,7 @@ class VirusTotalService(
 
     private fun parseAnalysisResponse(body: String, analysisId: String): VtResult = try {
         val attributes = JSONObject(body).getJSONObject("data").getJSONObject("attributes")
-        val apiStatus = attributes.optString("status", "queued")
-        when (apiStatus) {
+        when (val apiStatus = attributes.optString("status", "queued")) {
             "queued" -> VtResult(status = VtStatus.QUEUED, analysisId = analysisId)
             "in-progress" -> VtResult(status = VtStatus.ANALYZING, analysisId = analysisId)
             "completed" -> {

app/src/main/java/app/pwhs/universalinstaller/presentation/composable/AppScaffold.kt

@@ -45,11 +45,11 @@ import java.io.File
 
 @Composable
 fun SessionCard(
+    modifier: Modifier = Modifier,
     sessionData: SessionData,
     sessionProgress: SessionProgress?,
     onCancel: () -> Unit,
     onRetry: () -> Unit = {},
-    modifier: Modifier = Modifier,
 ) {
     val context = LocalContext.current
     val errorText = sessionData.error.resolve(context)

app/src/main/java/app/pwhs/universalinstaller/presentation/composable/SessionCard.kt

@@ -50,6 +50,7 @@ import androidx.compose.ui.Alignment
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.input.nestedscroll.nestedScroll
 import androidx.compose.ui.platform.LocalContext
+import androidx.compose.ui.platform.LocalResources
 import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.text.style.TextOverflow
 import androidx.compose.ui.unit.dp
@@ -76,6 +77,7 @@ fun DownloadHistoryScreen(
     viewModel: DownloadHistoryViewModel = koinViewModel(),
 ) {
     val context = LocalContext.current
+    val resource = LocalResources.current
     val items by viewModel.items.collectAsState()
     val scrollBehavior = TopAppBarDefaults.exitUntilCollapsedScrollBehavior()
     var showClearDialog by remember { mutableStateOf(false) }
@@ -165,7 +167,7 @@ fun DownloadHistoryScreen(
                             if (!file.exists()) {
                                 Toast.makeText(
                                     context,
-                                    context.getString(R.string.download_history_file_missing),
+                                    resource.getString(R.string.download_history_file_missing),
                                     Toast.LENGTH_SHORT,
                                 ).show()
                                 return@DownloadRow
@@ -184,7 +186,7 @@ fun DownloadHistoryScreen(
                             cb?.setPrimaryClip(ClipData.newPlainText("url", entry.url))
                             Toast.makeText(
                                 context,
-                                context.getString(R.string.download_history_url_copied),
+                                resource.getString(R.string.download_history_url_copied),
                                 Toast.LENGTH_SHORT,
                             ).show()
                         },

app/src/main/java/app/pwhs/universalinstaller/presentation/download/DownloadHistoryScreen.kt

@@ -9,10 +9,10 @@ import android.provider.Settings
 import androidx.core.content.ContextCompat
 import androidx.core.net.toUri
 import kotlinx.coroutines.Dispatchers
+import kotlinx.coroutines.currentCoroutineContext
 import kotlinx.coroutines.ensureActive
 import kotlinx.coroutines.withContext
 import java.io.File
-import kotlin.coroutines.coroutineContext
 
 data class FoundPackageFile(
     val path: String,
@@ -66,12 +66,12 @@ object ApkScanner {
         depth: Int,
         maxDepth: Int,
     ) {
-        coroutineContext.ensureActive()
+        currentCoroutineContext().ensureActive()
         if (depth > maxDepth) return
         if (!dir.exists() || !dir.canRead()) return
         val children = runCatching { dir.listFiles() }.getOrNull() ?: return
         for (child in children) {
-            coroutineContext.ensureActive()
+            currentCoroutineContext().ensureActive()
             if (child.isDirectory) {
                 val name = child.name
                 // Skip dotfiles, app-scoped dirs (restricted even with MANAGE access), and thumbnails.

app/src/main/java/app/pwhs/universalinstaller/presentation/install/ApkScanner.kt

@@ -42,7 +42,6 @@ import androidx.compose.material3.ModalBottomSheet
 import androidx.compose.material3.OutlinedButton
 import androidx.compose.material3.Surface
 import androidx.compose.material3.Text
-import androidx.compose.material3.TextButton
 import androidx.compose.material3.rememberModalBottomSheetState
 import androidx.compose.runtime.Composable
 import androidx.compose.ui.Alignment
@@ -357,7 +356,7 @@ private fun EntryRow(
                 )
                 Text(
                     text = when {
-                        failed -> entry.parseError.orEmpty()
+                        failed -> entry.parseError
                         warning -> "${entry.conflictLabel} · ${entry.apkInfo.packageName}"
                         else -> entry.apkInfo.packageName
                     },

app/src/main/java/app/pwhs/universalinstaller/presentation/install/BatchInstallSheet.kt

@@ -45,7 +45,7 @@ class DownloadNotifier(private val context: Context) {
         val nm = nm ?: return
         val now = android.os.SystemClock.elapsedRealtime()
         // Always let the first (0 B) and last (complete) updates through; throttle the middle.
-        val isEdge = bytesRead == 0L || (totalBytes > 0 && bytesRead >= totalBytes)
+        val isEdge = bytesRead == 0L || (totalBytes in 1..bytesRead)
         if (!isEdge && now - lastProgressMs < 500L) return
         lastProgressMs = now
         val indeterminate = totalBytes <= 0L

app/src/main/java/app/pwhs/universalinstaller/presentation/install/DownloadNotifier.kt

@@ -267,8 +267,7 @@ class InstallViewModel(
         _obbCopyState.value = ObbCopyState.Running(appName, packageName, 0L, combinedTotal)
         pendingObbCopyJob = ObbCopyJob(sourceUri, entries, attached, packageName, appName)
 
-        val strategy = selectObbStrategy(packageName)
-        when (strategy) {
+        when (val strategy = selectObbStrategy(packageName)) {
             ObbStrategy.Direct -> enqueueObbWorker(
                 ObbCopyWorker.STRATEGY_DIRECT, null, sourceUri, entries, attached, packageName, appName,
             )
@@ -462,7 +461,7 @@ class InstallViewModel(
                     } else 0L
                 } ?: 0L
         } catch (_: Exception) { 0L }
-        _attachedObbFiles.value = _attachedObbFiles.value + AttachedObb(uri, displayName, size)
+        _attachedObbFiles.value += AttachedObb(uri, displayName, size)
     }
 
     fun removeAttachedObb(uri: Uri) {
@@ -685,7 +684,7 @@ class InstallViewModel(
     private fun uniqueFileName(dir: File, desired: String): String {
         if (!File(dir, desired).exists()) return desired
         val dot = desired.lastIndexOf('.')
-        val stem = if (dot > 0) desired.substring(0, dot) else desired
+        val stem = if (dot > 0) desired.take(dot) else desired
         val ext = if (dot > 0) desired.substring(dot) else ""
         var i = 1
         while (File(dir, "$stem ($i)$ext").exists()) i++