fix(install): point the staged parse at the staged copies

Staging the APKs was not enough: the install kept reading the source anyway.

confirmInstall takes its URIs from apkInfo.splitEntries whenever there are
any, and only falls back to pendingApkUris otherwise. Stashing put the staged
copies in pendingApkUris but handed back an apkInfo whose splitEntries still
pointed at the file the other app gave us — and every package has at least
one split entry, including a plain single APK. So the staged copies were
never touched and the install read the source URI exactly as before.

Whether that fails depends on who the source is, which is why it looked
fixed. A MediaStore URI stays readable through our media access, so opening
from the system file list worked. A URI from another app's FileProvider —
ZArchiver's, in the report — carries a one-shot grant that dies with the
activity, and the install hit "Permission Denial: opening provider
ru.zdevs.zarchiver.provider.FileProvider ... not exported". Same code path,
opposite outcome, so testing through MediaStore proved nothing.

The stashed parse is now rewritten to reference the copies. Every split is
staged rather than only the selected ones: opening the dialog from the
notification can change the selection afterwards, and an unselected split
still pointing at the dead source would fail the moment it was ticked.

Not yet verified on device — the phone dropped off adb before this build
could be installed, and it needs testing from ZArchiver specifically, not
from a MediaStore URI.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Author: nqmgaming

app/src/main/java/app/pwhs/universalinstaller/presentation/install/InstallViewModel.kt

@@ -563,19 +563,37 @@ class InstallViewModel(
      */
     suspend fun stashPendingInstall(): PendingInstallStore.Entry? {
         val apkInfo = _pendingApkInfo.value ?: return null
-        val uris = if (apkInfo.splitEntries.isNotEmpty()) {
-            apkInfo.splitEntries.filter { it.selected }.map { it.uri }
-        } else {
-            pendingApkUris
-        }
-        if (uris.isNullOrEmpty()) return null
+        val splits = apkInfo.splitEntries
         val fileName = pendingFileName ?: return null
 
-        // Copy now, while the grant is still alive. What the parse leaves in pendingApkUris is
-        // the caller's own URI for a plain APK (only archives get extracted into our cache), and
-        // that URI dies with this activity — installing from it later fails with
-        // "Permission Denial: opening provider <their>.FileProvider ... not exported".
-        val installableUris = copyForLaterInstall(uris) ?: return null
+        // Copy now, while the grant is still alive. What the parse leaves behind is the caller's
+        // own URI for a plain APK (only archives get extracted into our cache), and that URI dies
+        // with this activity — installing from it later fails with "Permission Denial: opening
+        // provider <their>.FileProvider ... not exported".
+        //
+        // Every split is staged, not just the selected ones, because opening the dialog from the
+        // notification lets the selection change afterwards; an unselected split left pointing at
+        // the dead source would fail the moment it was ticked.
+        val sourceUris = if (splits.isNotEmpty()) splits.map { it.uri } else pendingApkUris
+        if (sourceUris.isNullOrEmpty()) return null
+        val stagedUris = copyForLaterInstall(sourceUris) ?: return null
+
+        // Rewrite the parse to point at the copies. [confirmInstall] reads the URIs off
+        // apkInfo.splitEntries whenever there are any, and only falls back to pendingApkUris
+        // otherwise — so staging without this rewrite installs from the dead source anyway.
+        val stagedInfo = if (splits.isNotEmpty()) {
+            apkInfo.copy(
+                splitEntries = splits.mapIndexed { index, entry -> entry.copy(uri = stagedUris[index]) },
+            )
+        } else {
+            apkInfo
+        }
+        val installableUris = if (splits.isNotEmpty()) {
+            stagedInfo.splitEntries.filter { it.selected }.map { it.uri }
+        } else {
+            stagedUris
+        }
+        if (installableUris.isEmpty()) return null
 
         val entry = PendingInstallStore.put(
             apkUris = installableUris,
@@ -587,7 +605,7 @@ class InstallViewModel(
             obbEntries = pendingObbEntries,
             attachedObbs = _attachedObbFiles.value,
             isDowngrade = isDowngrade(apkInfo),
-            apkInfo = apkInfo,
+            apkInfo = stagedInfo,
         )
 
         _pendingApkInfo.value = null