fix(virustotal): say what the scan found

A finished scan showed nothing. Three separate causes:

The verdict line was hidden whenever a verdict existed — the condition read
`vtDesc != null && !hasResult`, on the assumption the breakdown bar conveyed
it. The bar is a bare 8dp Canvas with no words in it, so CLEAN, MALICIOUS
and SUSPICIOUS all rendered silent.

The bar was grey for every clean file. It coloured only malicious,
suspicious and harmless, but for files VirusTotal reports engines that found
nothing under `undetected` and leaves `harmless` at 0 — so a clean APK got
three zero-width segments and a full-width grey remainder. Grey now means
"no data" and nothing else.

Per-engine results were parsed and thrown away. `engineResults` had no
reader anywhere in the UI, and the only route to any detail was clicking the
whole card to open a browser, which nothing signposted. There is now a
detection ratio, an expandable engine list with flagged engines first, and
an explicit "View on VirusTotal" button in place of the invisible card tap.

The compact sheet has the same gap: the VirusTotal card lives inside the
`isExpanded` branch, so the sheet a user actually confirms from showed no
trace of a completed scan. Adds a status chip to the chip row, covering
verdicts, in-progress states, and the no-verdict states (missing key, spent
quota, file too large). It only appears once a scan has run — vtResult stays
null until then, so nothing is claimed about an unscanned package.

Cards on the detail screen move from ElevatedCard to a flat outline. Nested
in the sheet, shadow plus a lighter fill stacked surface on surface on
surface and read as muddy floating boxes on a dark background. A malicious
verdict keeps its filled container — that one is meant to shout.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Author: nqmgaming

app/src/main/java/app/pwhs/universalinstaller/presentation/install/ApkInfoContent.kt

@@ -2,6 +2,7 @@ package app.pwhs.universalinstaller.presentation.install
 
 import android.text.format.Formatter
 import androidx.compose.animation.animateContentSize
+import androidx.compose.foundation.BorderStroke
 import androidx.compose.foundation.Canvas
 import androidx.compose.foundation.Image
 import androidx.compose.foundation.background
@@ -34,6 +35,7 @@ import androidx.compose.material.icons.rounded.Delete
 import androidx.compose.material.icons.rounded.DeleteSweep
 import androidx.compose.material.icons.rounded.ExpandLess
 import androidx.compose.material.icons.rounded.ExpandMore
+import androidx.compose.material.icons.rounded.GppGood
 import androidx.compose.material.icons.rounded.InstallMobile
 import androidx.compose.material.icons.rounded.Memory
 import androidx.compose.material.icons.rounded.Menu
@@ -48,7 +50,7 @@ import androidx.compose.material3.CardDefaults
 import androidx.compose.material3.Checkbox
 import androidx.compose.material3.CircularProgressIndicator
 import androidx.compose.material3.DropdownMenuItem
-import androidx.compose.material3.ElevatedCard
+import androidx.compose.material3.OutlinedCard
 import androidx.compose.material3.ExperimentalMaterial3Api
 import androidx.compose.material3.ExposedDropdownMenuAnchorType
 import androidx.compose.material3.ExposedDropdownMenuBox
@@ -277,6 +279,9 @@ internal fun ApkInfoContent(
                     contentColor = MaterialTheme.colorScheme.onErrorContainer,
                 )
             }
+            // Scan state belongs in the compact sheet too — this is the row the user confirms from,
+            // and the verdict used to be visible only after opening App Details.
+            apkInfo.vtResult?.let { vt -> VtStatusChip(vt) }
             if (isExpanded) {
                 if (apkInfo.versionName.isNotBlank()) {
                     InfoChip(label = stringResource(R.string.apk_info_version_chip, apkInfo.versionName))
@@ -630,22 +635,76 @@ private fun VirusTotalCard(
         VtStatus.ANALYZING -> stringResource(R.string.apk_info_vt_analyzing)
         null -> null
     }
-    ElevatedCard(onClick = onOpenLink, modifier = Modifier.fillMaxWidth(), shape = MaterialTheme.shapes.extraLarge, colors = CardDefaults.elevatedCardColors(containerColor = if (status == VtStatus.MALICIOUS) MaterialTheme.colorScheme.errorContainer else MaterialTheme.colorScheme.surfaceContainerLow)) {
-        Column(modifier = Modifier.padding(16.dp)) {
+    // A malicious verdict keeps a filled container — that one is meant to shout. Everything else
+    // uses the flat outlined shell the other sections use.
+    val isAlarming = status == VtStatus.MALICIOUS
+    OutlinedCard(
+        modifier = Modifier.fillMaxWidth(),
+        shape = MaterialTheme.shapes.extraLarge,
+        colors = CardDefaults.outlinedCardColors(
+            containerColor = if (isAlarming) MaterialTheme.colorScheme.errorContainer else Color.Transparent,
+        ),
+        border = if (isAlarming) {
+            BorderStroke(1.dp, MaterialTheme.colorScheme.error)
+        } else {
+            sectionCardBorder()
+        },
+    ) {
+        Column(modifier = Modifier.padding(16.dp).animateContentSize()) {
             Row(verticalAlignment = Alignment.CenterVertically) {
                 Icon(Icons.Rounded.Security, null, tint = vtColor, modifier = Modifier.size(20.dp))
                 Spacer(Modifier.width(8.dp))
                 Text(stringResource(R.string.apk_info_vt_scan_title), style = MaterialTheme.typography.labelLarge, color = vtColor)
                 if (inProgress) { Spacer(Modifier.width(8.dp)); CircularProgressIndicator(modifier = Modifier.size(16.dp), strokeWidth = 2.dp, color = vtColor) }
             }
-            // Don't duplicate the count line when the breakdown bar already conveys it.
-            if (vtDesc != null && !hasResult) {
+            // Always state the verdict. This used to be hidden whenever there was a result, on the
+            // assumption the breakdown bar conveyed it — but the bar carries no words, and a clean
+            // file colours none of its segments, so a finished scan rendered a silent grey card.
+            if (vtDesc != null) {
                 Spacer(Modifier.height(8.dp))
                 Text(vtDesc, style = MaterialTheme.typography.bodySmall, color = vtColor)
             }
             if (hasResult && vt != null) {
+                val total = vt.malicious + vt.suspicious + vt.harmless + vt.undetected
                 Spacer(Modifier.height(12.dp))
-                VtBreakdownSection(vt = vt, warningColor = extendedColors.warning)
+                VtBreakdownSection(vt = vt, warningColor = extendedColors.warning, cleanColor = extendedColors.success)
+                if (total > 0) {
+                    Spacer(Modifier.height(8.dp))
+                    Text(
+                        text = stringResource(
+                            R.string.apk_info_vt_tally,
+                            vt.malicious + vt.suspicious,
+                            total,
+                        ),
+                        style = MaterialTheme.typography.bodySmall,
+                        color = MaterialTheme.colorScheme.onSurfaceVariant,
+                    )
+                }
+                // The per-engine results were already being parsed and thrown away; the only way to
+                // see any detail was the card's own click opening a browser, which nothing signposted.
+                if (vt.engineResults.isNotEmpty()) {
+                    VtEngineList(
+                        engines = vt.engineResults,
+                        warningColor = extendedColors.warning,
+                    )
+                }
+                if (sha256.isNotBlank()) {
+                    TextButton(
+                        onClick = onOpenLink,
+                        contentPadding = PaddingValues(horizontal = 12.dp, vertical = 6.dp),
+                    ) {
+                        Text(
+                            stringResource(R.string.apk_info_vt_open_web),
+                            style = MaterialTheme.typography.labelMedium,
+                        )
+                        Spacer(Modifier.width(6.dp))
+                        Icon(
+                            Icons.AutoMirrored.Rounded.OpenInNew,
+                            contentDescription = null,
+                            modifier = Modifier.size(14.dp),
+                        )
+                    }
+                }
             }
             // Telling someone their key is missing is only half an answer — the fix is two
             // screens away and they are mid-install. Offer both steps here.
@@ -677,26 +736,92 @@ private fun VirusTotalCard(
     }
 }
 
+/**
+ * The malicious / suspicious / clean split as a single bar.
+ *
+ * `undetected` counts as clean: for files VirusTotal reports engines that found nothing under
+ * `undetected` and leaves `harmless` at 0, so colouring only `harmless` left every clean scan
+ * showing a fully grey bar.
+ */
 @Composable
-private fun VtBreakdownSection(vt: VtResult, warningColor: Color) {
+private fun VtBreakdownSection(vt: VtResult, warningColor: Color, cleanColor: Color) {
     val total = (vt.malicious + vt.suspicious + vt.harmless + vt.undetected).coerceAtLeast(1)
     val malFraction = vt.malicious.toFloat() / total
     val susFraction = vt.suspicious.toFloat() / total
-    val harmFraction = vt.harmless.toFloat() / total
+    val cleanFraction = (vt.harmless + vt.undetected).toFloat() / total
+    val errorColor = MaterialTheme.colorScheme.error
     Canvas(modifier = Modifier.fillMaxWidth().height(8.dp).clip(MaterialTheme.shapes.small)) {
         val w = size.width
         val h = size.height
         var x = 0f
         val malW = w * malFraction
-        if (malW > 0f) { drawRect(color = Color.Red, topLeft = Offset(x, 0f), size = Size(malW, h)); x += malW }
+        if (malW > 0f) { drawRect(color = errorColor, topLeft = Offset(x, 0f), size = Size(malW, h)); x += malW }
         val susW = w * susFraction
         if (susW > 0f) { drawRect(color = warningColor, topLeft = Offset(x, 0f), size = Size(susW, h)); x += susW }
-        val harmW = w * harmFraction
-        if (harmW > 0f) { drawRect(color = Color.Green, topLeft = Offset(x, 0f), size = Size(harmW, h)); x += harmW }
+        val cleanW = w * cleanFraction
+        if (cleanW > 0f) { drawRect(color = cleanColor, topLeft = Offset(x, 0f), size = Size(cleanW, h)); x += cleanW }
+        // Only reached when the stats add up to nothing — grey means "no data", not "clean".
         drawRect(color = Color.Gray.copy(alpha = 0.3f), topLeft = Offset(x, 0f), size = Size(w - x, h))
     }
 }
 
+/**
+ * Per-engine verdicts, collapsed to just the engines that flagged the file.
+ *
+ * Expanding shows all engines VirusTotal returned — for a clean file the collapsed list is empty,
+ * so the toggle is the only thing on screen until it is opened.
+ */
+@Composable
+private fun VtEngineList(engines: List<VtEngineResult>, warningColor: Color) {
+    var expanded by remember { mutableStateOf(false) }
+    val flagged = engines.filter { it.category == "malicious" || it.category == "suspicious" }
+    val visible = if (expanded) engines else flagged
+    Column(modifier = Modifier.fillMaxWidth()) {
+        if (visible.isNotEmpty()) Spacer(Modifier.height(8.dp))
+        visible.forEach { engine ->
+            Row(
+                modifier = Modifier.fillMaxWidth().padding(vertical = 3.dp),
+                verticalAlignment = Alignment.CenterVertically,
+            ) {
+                Text(
+                    text = engine.engineName,
+                    style = MaterialTheme.typography.bodySmall,
+                    modifier = Modifier.weight(1f),
+                    maxLines = 1,
+                    overflow = TextOverflow.Ellipsis,
+                )
+                Spacer(Modifier.width(8.dp))
+                Text(
+                    text = engine.result ?: engine.category,
+                    style = MaterialTheme.typography.bodySmall,
+                    color = when (engine.category) {
+                        "malicious" -> MaterialTheme.colorScheme.error
+                        "suspicious" -> warningColor
+                        else -> MaterialTheme.colorScheme.onSurfaceVariant
+                    },
+                    maxLines = 1,
+                    overflow = TextOverflow.Ellipsis,
+                )
+            }
+        }
+        TextButton(
+            onClick = { expanded = !expanded },
+            contentPadding = PaddingValues(horizontal = 12.dp, vertical = 6.dp),
+        ) {
+            Text(
+                // Deliberately uncounted: this list includes engines that could not scan the file
+                // at all, so its size contradicts the "n of m flagged" ratio just above it.
+                text = if (expanded) {
+                    stringResource(R.string.apk_info_vt_engines_hide)
+                } else {
+                    stringResource(R.string.apk_info_vt_engines_show)
+                },
+                style = MaterialTheme.typography.labelMedium,
+            )
+        }
+    }
+}
+
 @Composable
 private fun PermissionsCard(permissions: List<String>) {
     var expanded by remember { mutableStateOf(false) }
@@ -741,10 +866,25 @@ private fun SplitsCard(splits: List<SplitEntry>, onToggle: (Int) -> Unit) {
     }
 }
 
+/**
+ * The one border every install-detail section shares.
+ *
+ * These used to be [androidx.compose.material3.ElevatedCard]s: inside the detail sheet the shadow
+ * plus a lighter fill stacked surface on surface on surface, which read as muddy floating boxes on
+ * a dark background. Flat outlines keep the grouping without the layering.
+ */
+@Composable
+private fun sectionCardBorder() = BorderStroke(1.dp, MaterialTheme.colorScheme.outlineVariant)
+
 @Composable
 private fun SectionCard(icon: androidx.compose.ui.graphics.vector.ImageVector, title: String, summary: String? = null, badge: String? = null, defaultExpanded: Boolean = true, content: @Composable () -> Unit) {
     var expanded by remember { mutableStateOf(defaultExpanded) }
-    ElevatedCard(modifier = Modifier.fillMaxWidth(), shape = MaterialTheme.shapes.extraLarge, colors = CardDefaults.elevatedCardColors(containerColor = MaterialTheme.colorScheme.surfaceContainerLow)) {
+    OutlinedCard(
+        modifier = Modifier.fillMaxWidth(),
+        shape = MaterialTheme.shapes.extraLarge,
+        colors = CardDefaults.outlinedCardColors(containerColor = Color.Transparent),
+        border = sectionCardBorder(),
+    ) {
         Column(modifier = Modifier.animateContentSize()) {
             Row(modifier = Modifier.fillMaxWidth().clickable { expanded = !expanded }.padding(16.dp), verticalAlignment = Alignment.CenterVertically) {
                 Icon(icon, null, tint = MaterialTheme.colorScheme.primary, modifier = Modifier.size(20.dp))
@@ -761,6 +901,61 @@ private fun SectionCard(icon: androidx.compose.ui.graphics.vector.ImageVector, t
     }
 }
 
+/**
+ * One-chip VirusTotal state for the chip row, shown collapsed and expanded alike.
+ *
+ * [ApkInfo.vtResult] stays null until a scan is asked for, so this never claims anything about a
+ * package nobody scanned.
+ */
+@Composable
+private fun VtStatusChip(vt: VtResult) {
+    val extendedColors = LocalExtendedColors.current
+    when (vt.status) {
+        VtStatus.CLEAN -> InfoChip(
+            label = stringResource(R.string.apk_info_vt_chip_clean),
+            leadingIcon = {
+                Icon(Icons.Rounded.GppGood, null, modifier = Modifier.size(16.dp), tint = extendedColors.success)
+            },
+            contentColor = extendedColors.success,
+        )
+        VtStatus.MALICIOUS, VtStatus.SUSPICIOUS -> {
+            val alarming = vt.status == VtStatus.MALICIOUS
+            InfoChip(
+                label = stringResource(R.string.apk_info_vt_chip_flagged, vt.malicious + vt.suspicious),
+                leadingIcon = {
+                    Icon(
+                        Icons.Rounded.Warning,
+                        null,
+                        modifier = Modifier.size(16.dp),
+                        tint = if (alarming) MaterialTheme.colorScheme.onErrorContainer else extendedColors.warning,
+                    )
+                },
+                containerColor = if (alarming) MaterialTheme.colorScheme.errorContainer else extendedColors.warningContainer,
+                contentColor = if (alarming) MaterialTheme.colorScheme.onErrorContainer else extendedColors.warning,
+            )
+        }
+        VtStatus.SCANNING, VtStatus.UPLOADING, VtStatus.QUEUED, VtStatus.ANALYZING -> InfoChip(
+            label = stringResource(R.string.apk_info_vt_chip_scanning),
+            leadingIcon = {
+                CircularProgressIndicator(
+                    modifier = Modifier.size(12.dp),
+                    strokeWidth = 1.5.dp,
+                    color = MaterialTheme.colorScheme.onSurfaceVariant,
+                )
+            },
+        )
+        // Every remaining state is a scan that produced no verdict — missing key, bad key, quota
+        // spent, file too big, unknown to VirusTotal. Say so rather than showing nothing.
+        else -> InfoChip(
+            label = stringResource(R.string.apk_info_vt_chip_no_result),
+            leadingIcon = {
+                Icon(Icons.Rounded.Security, null, modifier = Modifier.size(16.dp), tint = extendedColors.warning)
+            },
+            contentColor = extendedColors.warning,
+        )
+    }
+}
+
 @Composable
 internal fun InfoChip(label: String, leadingIcon: @Composable (() -> Unit)? = null, containerColor: Color = MaterialTheme.colorScheme.surfaceContainerHigh, contentColor: Color = MaterialTheme.colorScheme.onSurfaceVariant) {
     Surface(shape = MaterialTheme.shapes.small, color = containerColor, contentColor = contentColor) {
@@ -785,7 +980,12 @@ internal fun sdkToAndroid(sdk: Int): String = when {
 
 @Composable
 private fun ObbAttachCard(attached: List<AttachedObb>, onAttach: () -> Unit, onRemove: (AttachedObb) -> Unit) {
-    ElevatedCard(modifier = Modifier.fillMaxWidth(), shape = MaterialTheme.shapes.extraLarge, colors = CardDefaults.elevatedCardColors(containerColor = MaterialTheme.colorScheme.surfaceContainerLow)) {
+    OutlinedCard(
+        modifier = Modifier.fillMaxWidth(),
+        shape = MaterialTheme.shapes.extraLarge,
+        colors = CardDefaults.outlinedCardColors(containerColor = Color.Transparent),
+        border = sectionCardBorder(),
+    ) {
         Column(modifier = Modifier.padding(16.dp)) {
             Text(stringResource(R.string.apk_info_obb_attach_title), style = MaterialTheme.typography.titleSmall)
             attached.forEach { obb ->

app/src/main/res/values-vi/strings.xml

@@ -177,6 +177,14 @@
     <string name="apk_info_vt_uploading">Đang tải lên VirusTotal… %d%%</string>
     <string name="apk_info_vt_add_key">Thêm API key</string>
     <string name="apk_info_vt_get_key">Lấy key miễn phí</string>
+    <string name="apk_info_vt_tally">%1$d trên %2$d engine đánh dấu file này</string>
+    <string name="apk_info_vt_engines_show">Kết quả từng engine</string>
+    <string name="apk_info_vt_engines_hide">Ẩn kết quả từng engine</string>
+    <string name="apk_info_vt_open_web">Xem trên VirusTotal</string>
+    <string name="apk_info_vt_chip_clean">VirusTotal: sạch</string>
+    <string name="apk_info_vt_chip_flagged">VirusTotal: %1$d engine đánh dấu</string>
+    <string name="apk_info_vt_chip_scanning">VirusTotal: đang quét…</string>
+    <string name="apk_info_vt_chip_no_result">VirusTotal: chưa có kết quả</string>
     <string name="apk_info_vt_check_button">Kiểm tra với VirusTotal</string>
     <string name="apk_info_vt_rescan_button">Quét lại</string>
     <string name="vt_notif_channel_name">Quét VirusTotal</string>

app/src/main/res/values-zh/strings.xml

@@ -174,6 +174,14 @@
     <string name="apk_info_vt_uploading">正在上传至 VirusTotal… %d%%</string>
     <string name="apk_info_vt_add_key">添加 API 密钥</string>
     <string name="apk_info_vt_get_key">获取免费密钥</string>
+    <string name="apk_info_vt_tally">%2$d 个引擎中有 %1$d 个标记了此文件</string>
+    <string name="apk_info_vt_engines_show">各引擎结果</string>
+    <string name="apk_info_vt_engines_hide">隐藏各引擎结果</string>
+    <string name="apk_info_vt_open_web">在 VirusTotal 中查看</string>
+    <string name="apk_info_vt_chip_clean">VirusTotal：安全</string>
+    <string name="apk_info_vt_chip_flagged">VirusTotal：%1$d 个引擎标记</string>
+    <string name="apk_info_vt_chip_scanning">VirusTotal：扫描中…</string>
+    <string name="apk_info_vt_chip_no_result">VirusTotal：暂无结果</string>
     <string name="apk_info_vt_check_button">使用 VirusTotal 检查</string>
     <string name="apk_info_vt_rescan_button">重新扫描</string>
     <string name="vt_notif_channel_name">VirusTotal 扫描</string>

app/src/main/res/values/strings.xml

@@ -253,6 +253,14 @@
     <string name="apk_info_vt_too_large">File too large for VirusTotal (%s)</string>
     <string name="apk_info_vt_add_key">Add API key</string>
     <string name="apk_info_vt_get_key">Get a free key</string>
+    <string name="apk_info_vt_tally">%1$d of %2$d engines flagged this file</string>
+    <string name="apk_info_vt_engines_show">Engine results</string>
+    <string name="apk_info_vt_engines_hide">Hide engine results</string>
+    <string name="apk_info_vt_open_web">View on VirusTotal</string>
+    <string name="apk_info_vt_chip_clean">VirusTotal: clean</string>
+    <string name="apk_info_vt_chip_flagged">VirusTotal: %1$d flagged</string>
+    <string name="apk_info_vt_chip_scanning">VirusTotal: scanning…</string>
+    <string name="apk_info_vt_chip_no_result">VirusTotal: no result</string>
     <string name="apk_info_vt_check_button">Check with VirusTotal</string>
     <string name="apk_info_vt_rescan_button">Scan again</string>
     <string name="vt_notif_channel_name">VirusTotal scans</string>