fix(install): tell read failures, parse failures and missing permission apart

Chasing the first gap against InstallerX Revived, which has separate states
for "could not read the file" and "could not parse the package" where this
app had one. It turned out to have less than one.

An unreadable URI crashed the app outright. getDisplayName queries the
sending app's provider from composition, on the main thread, with no guard —
so the moment that grant lapsed it threw SecurityException and took the
process down:

  FATAL EXCEPTION: main
  java.lang.SecurityException: Permission Denial: opening provider
    ru.zdevs.zarchiver.provider.FileProvider ... not exported from UID 10373
      at ContentResolverKt.getDisplayName(ContentResolver.kt:12)
      at DialogInstallActivity.onCreate$lambda$2(DialogInstallActivity.kt:468)

It is best-effort now: no name is not a reason to lose the install.

Parse failures did not crash but were barely better — a toast saying
"unsupported file" and the dialog vanishing, regardless of whether the file
was unreadable or genuinely not a package. Both are dialog states now:
ReadFailed says the sending app no longer allows access and to open it again
from there; ParseFailed says the bytes arrived but are not an installable
package. The underlying exception is shown as detail rather than as the whole
message. Which one you get is decided by the throwable — SecurityException,
FileNotFoundException and IOException mean the bytes never arrived.

Third state, the second gap: PermissionRequired. Install-from-unknown-sources
is now checked when Install is tapped, so a missing permission asks for it
instead of starting an install that fails inside the system installer and
gets reported as if the package were at fault.

The crash fix is verified by the stack trace above. The three states compile
but are not yet seen on device — the phone dropped off adb before this build
could be installed.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Author: nqmgaming

app/src/main/java/app/pwhs/universalinstaller/presentation/install/DialogInstallActivity.kt

@@ -8,6 +8,7 @@ import android.content.pm.PackageManager
 import android.net.Uri
 import android.os.Build
 import android.os.Bundle
+import android.provider.Settings
 import android.widget.Toast
 import androidx.core.content.ContextCompat
 import androidx.activity.ComponentActivity
@@ -85,6 +86,7 @@ import app.pwhs.universalinstaller.domain.model.InstallUiStyle
 import app.pwhs.universalinstaller.presentation.setting.PreferencesKeys
 import app.pwhs.universalinstaller.presentation.setting.SecurityLevel
 import app.pwhs.core.data.local.dataStore
+import app.pwhs.core.util.PermissionMonitor
 import app.pwhs.universalinstaller.presentation.install.dialog.DialogFailedContent
 import app.pwhs.universalinstaller.presentation.install.dialog.DialogInstallingContent
 import app.pwhs.universalinstaller.presentation.install.dialog.DialogMenuContent
@@ -108,6 +110,8 @@ import ru.solrudev.ackpine.splits.ApkSplits.validate
 import ru.solrudev.ackpine.splits.SplitPackage.Companion.toSplitPackage
 import ru.solrudev.ackpine.splits.ZippedApkSplits
 import timber.log.Timber
+import java.io.FileNotFoundException
+import java.io.IOException
 import app.pwhs.core.domain.ThemeMode
 import app.pwhs.core.domain.AppThemePreset
 import androidx.datastore.preferences.core.booleanPreferencesKey
@@ -165,8 +169,8 @@ class DialogInstallActivity : ComponentActivity() {
          */
         private const val LOG = "NotifInstall"
 
-        /** Rounded at the top only — the bottom edge runs off the screen. */
-        private val SHEET_SHAPE = RoundedCornerShape(topStart = 28.dp, topEnd = 28.dp)
+        /** All four corners: the sheet floats inside the window rather than meeting its edge. */
+        private val FLOATING_SHEET_SHAPE = RoundedCornerShape(28.dp)
     }
 
     // POST_NOTIFICATIONS gates the background-install notification on Android 13+. We ask
@@ -187,6 +191,36 @@ class DialogInstallActivity : ComponentActivity() {
     /** Track whether system took us to a confirmation activity. */
     private var wentToSystemConfirm = false
 
+    /**
+     * Decide which of the two failures the user is looking at.
+     *
+     * A SecurityException or a missing file means the bytes never arrived — the sending app's
+     * grant expired, or the file moved. Anything else got past reading and fell over on the
+     * package itself. Blaming the package for the first case is what the old single message did.
+     */
+    private fun reportParseProblem(cause: Throwable) {
+        val unreadable = cause is SecurityException ||
+            cause is FileNotFoundException ||
+            cause is IOException
+        val detail = cause.message.orEmpty()
+        if (unreadable) viewModel.dialogReadFailed(detail) else viewModel.dialogParseFailed(detail)
+    }
+
+    /** Whether Android will let us install at all. False means the install would fail instantly. */
+    private fun canInstallPackages(): Boolean =
+        Build.VERSION.SDK_INT < Build.VERSION_CODES.O ||
+            packageManager.canRequestPackageInstalls()
+
+    private fun openInstallPermissionSettings() {
+        PermissionMonitor.start(this) { packageManager.canRequestPackageInstalls() }
+        startActivity(
+            Intent(
+                Settings.ACTION_MANAGE_UNKNOWN_APP_SOURCES,
+                Uri.parse("package:$packageName"),
+            )
+        )
+    }
+
     /**
      * The parts that make a sheet a sheet rather than a lowered dialog: a drag handle to grab, and
      * content kept clear of the gesture bar so the action row is not sitting on the system inset.
@@ -204,7 +238,6 @@ class DialogInstallActivity : ComponentActivity() {
         Column(
             modifier = Modifier
                 .fillMaxWidth()
-                .navigationBarsPadding()
                 .padding(bottom = 8.dp),
             horizontalAlignment = Alignment.CenterHorizontally,
         ) {
@@ -449,12 +482,10 @@ class DialogInstallActivity : ComponentActivity() {
                 if (skipInitialParse) return@LaunchedEffect
                 runCatching { parseAndPush(context, incomingUri) }.onFailure { e ->
                     Timber.e(e, "Parse failed for $incomingUri")
-                    Toast.makeText(
-                        context,
-                        resource.getString(R.string.install_unsupported_file),
-                        Toast.LENGTH_LONG,
-                    ).show()
-                    finish()
+                    // Was a toast and finish(): the dialog vanished and the user was told
+                    // "unsupported file" even when the real problem was that we never got to
+                    // read it. Show which of the two it was, and stay on screen to say so.
+                    reportParseProblem(e)
                 }
             }
 
@@ -515,10 +546,13 @@ class DialogInstallActivity : ComponentActivity() {
             val handleInstallTap = {
                 val info = uiState.pendingApkInfo
                 val risks = if (info != null) detectInstallRisks(info, strictVirusTotalCheck) else emptyList()
-                if (risks.isNotEmpty()) {
-                    pendingRisks = risks
-                } else {
-                    proceedInstall()
+                when {
+                    // Checked before anything else: without this the install starts, fails
+                    // somewhere inside the system installer, and the failure gets reported as if
+                    // the package were at fault.
+                    !canInstallPackages() -> viewModel.dialogPermissionRequired()
+                    risks.isNotEmpty() -> pendingRisks = risks
+                    else -> proceedInstall()
                 }
             }
 
@@ -635,8 +669,14 @@ class DialogInstallActivity : ComponentActivity() {
                   SheetEntryAnimation(enabled = isSheet) {
                     Surface(
                         modifier = (if (isSheet) {
+                            // Floating rather than flush: inset from the edges and rounded on all
+                            // four corners, the way InstallerX Revived's miuix sheet sits. A sheet
+                            // glued to the bottom edge leaves two square corners against the
+                            // gesture bar, which is what prompted this.
                             Modifier
                                 .fillMaxWidth()
+                                .navigationBarsPadding()
+                                .padding(horizontal = 12.dp, vertical = 12.dp)
                                 .heightIn(max = screenHeight * 0.9f)
                         } else {
                             Modifier
@@ -650,7 +690,7 @@ class DialogInstallActivity : ComponentActivity() {
                         // A sheet is attached to the edge, not floating over the screen: it takes
                         // the sheet container colour and no drop shadow. Lowering a dialog card to
                         // the bottom without this still reads as a dialog.
-                        shape = if (isSheet) BottomSheetDefaults.ExpandedShape else AlertDialogDefaults.shape,
+                        shape = if (isSheet) FLOATING_SHEET_SHAPE else AlertDialogDefaults.shape,
                         color = if (isSheet) BottomSheetDefaults.ContainerColor else AlertDialogDefaults.containerColor,
                         tonalElevation = if (isSheet) BottomSheetDefaults.Elevation else AlertDialogDefaults.TonalElevation,
                         shadowElevation = if (isSheet) 0.dp else 12.dp,
@@ -671,6 +711,7 @@ class DialogInstallActivity : ComponentActivity() {
                             onMenu = viewModel::dialogShowMenu,
                             onUnblock = viewModel::unblockPackage,
                             onMenuBack = viewModel::dialogBackToPrepare,
+                            onGrantInstallPermission = { openInstallPermissionSettings() },
                             onCheckVirusTotal = {
                                 viewModel.scanVirusTotal(this@DialogInstallActivity)
                             },
@@ -769,11 +810,7 @@ class DialogInstallActivity : ComponentActivity() {
         lifecycleScope.launch {
             runCatching { parseAndPush(context, uri) }.onFailure { e ->
                 Timber.e(e, "Parse failed for new intent $uri")
-                Toast.makeText(
-                    context,
-                    getString(R.string.install_unsupported_file),
-                    Toast.LENGTH_LONG,
-                ).show()
+                reportParseProblem(e)
             }
         }
     }

app/src/main/java/app/pwhs/universalinstaller/presentation/install/InstallUiState.kt

@@ -29,6 +29,25 @@ sealed interface DialogStage {
     /** Install failed — show error + retry/close buttons. */
     data class Failed(val errorMessage: String = "") : DialogStage
 
+    /**
+     * The file could not be read at all: the grant died, it was moved, or the source app's
+     * provider refused us. Distinct from [ParseFailed] because the fix is different — nothing
+     * about the package is wrong, we just never got its bytes.
+     */
+    data class ReadFailed(val reason: String = "") : DialogStage
+
+    /**
+     * The bytes arrived but are not an installable package — wrong format, truncated download,
+     * an archive with no APK inside.
+     */
+    data class ParseFailed(val reason: String = "") : DialogStage
+
+    /**
+     * Installing from unknown sources is not granted, so the install would fail the moment it
+     * started. Asks for the permission instead of failing and blaming the package.
+     */
+    data object PermissionRequired : DialogStage
+
     /** No dialog should be shown. */
     data object None : DialogStage
 }

app/src/main/java/app/pwhs/universalinstaller/presentation/install/InstallViewModel.kt

@@ -300,6 +300,15 @@ class InstallViewModel(
     /** Install failed. */
     fun dialogInstallFailed(error: String) { _dialogStage.value = DialogStage.Failed(error) }
 
+    /** The source could not be read — see [DialogStage.ReadFailed]. */
+    fun dialogReadFailed(reason: String) { _dialogStage.value = DialogStage.ReadFailed(reason) }
+
+    /** The source is not an installable package — see [DialogStage.ParseFailed]. */
+    fun dialogParseFailed(reason: String) { _dialogStage.value = DialogStage.ParseFailed(reason) }
+
+    /** Install-from-unknown-sources is missing — see [DialogStage.PermissionRequired]. */
+    fun dialogPermissionRequired() { _dialogStage.value = DialogStage.PermissionRequired }
+
     /** Close dialog entirely. */
     fun dialogClose() { _dialogStage.value = DialogStage.None }
 

app/src/main/java/app/pwhs/universalinstaller/presentation/install/dialog/DialogGenerator.kt

@@ -27,6 +27,8 @@ import androidx.compose.ui.unit.dp
 import androidx.core.graphics.drawable.toBitmap
 import androidx.compose.ui.res.stringResource
 import app.pwhs.universalinstaller.R
+import androidx.compose.material.icons.rounded.ErrorOutline
+import androidx.compose.material.icons.rounded.Security
 import app.pwhs.universalinstaller.presentation.install.AttachedObb
 import app.pwhs.universalinstaller.presentation.install.DialogStage
 import app.pwhs.universalinstaller.presentation.install.DialogTarget
@@ -54,6 +56,7 @@ fun generateDialogParams(
     onSelectUserId: (Int?) -> Unit,
     onSkipParse: (() -> Unit)? = null,
     onFallbackInstall: (() -> Unit)? = null,
+    onGrantInstallPermission: () -> Unit = {},
 ): DialogParams {
     return when (val stage = uiState.dialogStage) {
         DialogStage.Loading -> {
@@ -227,6 +230,43 @@ fun generateDialogParams(
             }
         }
 
+        is DialogStage.ReadFailed -> DialogParams(
+            content = DialogInnerParams("read_failed") {
+                DialogProblemContent(
+                    icon = Icons.Rounded.ErrorOutline,
+                    title = stringResource(R.string.dialog_read_failed_title),
+                    explanation = stringResource(R.string.dialog_read_failed_text),
+                    detail = stage.reason,
+                    onClose = onCloseAfterResult,
+                )
+            }
+        )
+
+        is DialogStage.ParseFailed -> DialogParams(
+            content = DialogInnerParams("parse_failed") {
+                DialogProblemContent(
+                    icon = Icons.Rounded.ErrorOutline,
+                    title = stringResource(R.string.dialog_parse_failed_title),
+                    explanation = stringResource(R.string.dialog_parse_failed_text),
+                    detail = stage.reason,
+                    onClose = onCloseAfterResult,
+                )
+            }
+        )
+
+        DialogStage.PermissionRequired -> DialogParams(
+            content = DialogInnerParams("permission_required") {
+                DialogProblemContent(
+                    icon = Icons.Rounded.Security,
+                    title = stringResource(R.string.dialog_permission_title),
+                    explanation = stringResource(R.string.dialog_permission_text),
+                    actionLabel = stringResource(R.string.dialog_permission_grant),
+                    onAction = onGrantInstallPermission,
+                    onClose = onCancel,
+                )
+            }
+        )
+
         DialogStage.None -> DialogParams()
     }
 }

app/src/main/java/app/pwhs/universalinstaller/presentation/install/dialog/DialogInstallStages.kt

@@ -389,3 +389,92 @@ fun DialogFailedContent(
         }
     }
 }
+
+/**
+ * A problem that stopped the install before it started: the file could not be read, it is not a
+ * package, or the permission to install is missing.
+ *
+ * Separate from [DialogFailedContent], which reports an install session that ran and failed. The
+ * distinction matters to the person reading it — "we never got your file" and "Android refused
+ * the install" call for different actions, and the old code collapsed both into one message (or,
+ * for read and parse errors, into a toast and a vanished dialog).
+ */
+@Composable
+fun DialogProblemContent(
+    icon: androidx.compose.ui.graphics.vector.ImageVector,
+    title: String,
+    explanation: String,
+    detail: String? = null,
+    actionLabel: String? = null,
+    onAction: (() -> Unit)? = null,
+    onClose: () -> Unit,
+) {
+    Column(
+        modifier = Modifier
+            .fillMaxWidth()
+            .padding(24.dp),
+        horizontalAlignment = Alignment.CenterHorizontally,
+    ) {
+        Icon(
+            imageVector = icon,
+            contentDescription = null,
+            tint = MaterialTheme.colorScheme.error,
+            modifier = Modifier.size(56.dp),
+        )
+
+        Spacer(modifier = Modifier.height(16.dp))
+
+        Text(
+            text = title,
+            style = MaterialTheme.typography.titleLarge.copy(fontWeight = FontWeight.SemiBold),
+            textAlign = TextAlign.Center,
+        )
+
+        Spacer(modifier = Modifier.height(8.dp))
+
+        Text(
+            text = explanation,
+            style = MaterialTheme.typography.bodyMedium,
+            color = MaterialTheme.colorScheme.onSurfaceVariant,
+            textAlign = TextAlign.Center,
+        )
+
+        // The raw cause, kept out of the main sentence: useful when reporting a bug, noise
+        // otherwise. Scrollable because provider exceptions run long.
+        if (!detail.isNullOrBlank()) {
+            Spacer(modifier = Modifier.height(12.dp))
+            Column(
+                modifier = Modifier
+                    .fillMaxWidth()
+                    .heightIn(max = 120.dp)
+                    .verticalScroll(rememberScrollState()),
+            ) {
+                Text(
+                    text = detail,
+                    style = MaterialTheme.typography.bodySmall,
+                    color = MaterialTheme.colorScheme.onSurfaceVariant,
+                    textAlign = TextAlign.Center,
+                )
+            }
+        }
+
+        Spacer(modifier = Modifier.height(20.dp))
+
+        if (onAction != null && actionLabel != null) {
+            Button(onClick = onAction, modifier = Modifier.fillMaxWidth()) {
+                Text(actionLabel)
+            }
+            Spacer(modifier = Modifier.height(8.dp))
+            androidx.compose.material3.OutlinedButton(
+                onClick = onClose,
+                modifier = Modifier.fillMaxWidth(),
+            ) {
+                Text(stringResource(R.string.dialog_failed_close))
+            }
+        } else {
+            Button(onClick = onClose, modifier = Modifier.fillMaxWidth()) {
+                Text(stringResource(R.string.dialog_failed_close))
+            }
+        }
+    }
+}

app/src/main/java/app/pwhs/universalinstaller/util/extension/ContentResolver.kt

@@ -5,14 +5,18 @@ import android.net.Uri
 import android.provider.OpenableColumns
 import androidx.core.net.toFile
 
-fun ContentResolver.getDisplayName(uri: Uri): String {
+/**
+ * Best-effort display name for [uri], or "" when it cannot be read.
+ *
+ * Querying another app's provider throws SecurityException the moment its grant lapses, and this
+ * runs on the main thread from composition — an unreadable URI used to take the whole app down
+ * with it rather than surface as an error the user could read.
+ */
+fun ContentResolver.getDisplayName(uri: Uri): String = runCatching {
     if (uri.scheme == ContentResolver.SCHEME_FILE) {
-        return uri.toFile().name
+        return@runCatching uri.toFile().name
     }
     query(uri, arrayOf(OpenableColumns.DISPLAY_NAME), null, null, null).use { cursor ->
-        if (cursor == null || !cursor.moveToFirst()) {
-            return ""
-        }
-        return cursor.getString(0)
+        if (cursor == null || !cursor.moveToFirst()) "" else cursor.getString(0).orEmpty()
     }
-}
+}.getOrDefault("")

app/src/main/res/values/strings.xml

@@ -97,6 +97,14 @@
     <string name="fab_install">Install Package</string>
     <string name="uninstall">Uninstall</string>
     <!-- Install mode / confirm-from-notification -->
+    <!-- Problems that stop an install before it starts -->
+    <string name="dialog_read_failed_title">Couldn\'t read the file</string>
+    <string name="dialog_read_failed_text">The app that sent this package no longer allows access to it. Open the file again from that app.</string>
+    <string name="dialog_parse_failed_title">Not an installable package</string>
+    <string name="dialog_parse_failed_text">The file was read, but it isn\'t a valid APK, APKS, XAPK or APKM — it may be incomplete or a different kind of archive.</string>
+    <string name="dialog_permission_title">Installation not allowed yet</string>
+    <string name="dialog_permission_text">Android needs your permission for this app to install packages. Nothing has been installed yet.</string>
+    <string name="dialog_permission_grant">Grant permission</string>
     <string name="install_prompt_channel_name">Install confirmation</string>
     <string name="install_prompt_channel_desc">Asks whether to install a package you opened, without covering the app you opened it from.</string>
     <string name="install_prompt_notif_text">Ready to install. Tap to review, or install straight away.</string>