Commit ff28990
fix(install): check the prompt can post before committing to it
Once the headless path finishes the activity there is no window left, so a
prompt that fails to post would leave the install with nothing on screen.
The check now happens before the parse is stashed, and a failure falls back
to the dialog with the parse restored intact.
No change to how the prompt is posted. An earlier attempt deferred the post
until after the activity finished, on the theory that a heads-up is
suppressed for the app currently in front. That theory was wrong — see the
commit message below for what it actually is — and the delay only added a
window in which the process could die with the prompt never posted.
The reason the prompt does not pop up like a message on this device is not
in this code at all: Samsung replaces heads-up cards with the edge glow
whenever Edge lighting is on. A notification posted by the shell itself gets
the same treatment, logged as "no Heads up : edgelighting enabled app", and
turning edge_lighting off makes the refusal disappear. InstallerX Revived
uses the same IMPORTANCE_HIGH channel with no extra API, so it behaves
identically here.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>1 parent 0752dc2 commit ff28990
2 files changed
Lines changed: 20 additions & 13 deletions
File tree
- app/src/main/java/app/pwhs/universalinstaller/presentation/install
Lines changed: 7 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
291 | 291 | | |
292 | 292 | | |
293 | 293 | | |
294 | | - | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
295 | 297 | | |
296 | | - | |
297 | | - | |
298 | | - | |
299 | | - | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
300 | 302 | | |
301 | 303 | | |
302 | 304 | | |
| |||
Lines changed: 13 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
94 | 94 | | |
95 | 95 | | |
96 | 96 | | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
97 | 109 | | |
98 | 110 | | |
99 | 111 | | |
| |||
138 | 150 | | |
139 | 151 | | |
140 | 152 | | |
141 | | - | |
142 | | - | |
143 | | - | |
144 | | - | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
149 | 153 | | |
150 | 154 | | |
151 | 155 | | |
| |||
167 | 171 | | |
168 | 172 | | |
169 | 173 | | |
| 174 | + | |
170 | 175 | | |
171 | 176 | | |
0 commit comments