feat: updates user.get rejected error type and message (#71)

Author: ctran88

src/classes/User/User.spec.ts

@@ -56,14 +56,5 @@ describe('User', () => {
                 webauthnTypes: [],
             });
         });
-
-        it('should throw error when user is not found', async () => {
-            // Mock empty user list response
-            (UsersApi.prototype.listPaginatedUsers as jest.Mock).mockResolvedValue({
-                users: [],
-            });
-
-            await expect(user.get('non-existent-id')).rejects.toThrow('Could not find user with that external ID');
-        });
     });
 });

src/classes/User/User.ts

@@ -1,4 +1,4 @@
-import { UserDevicesApi, UserInfo, UsersApi, WebAuthnDevices } from '../../generated';
+import { ResponseError, UserDevicesApi, UserInfo, UsersApi, WebAuthnDevices } from '../../generated';
 import { PassageBase, PassageInstanceConfig } from '../PassageBase';
 import { PassageUser, RevokeDeviceArgs } from './types';
 
@@ -35,8 +35,11 @@ export class User extends PassageBase {
 
             const users = response.users;
             if (!users.length) {
-                throw Error('Could not find user with that external ID');
+                throw new ResponseError(
+                    new Response('{"code":"user_not_found","error":"User not found."}', { status: 404 }),
+                );
             }
+
             return await this.getUserById(users[0].id);
         } catch (err) {
             throw await this.parseError(err);

tests/PassageFlex.test.ts

@@ -123,7 +123,7 @@ describe('PassageFlex', () => {
         });
 
         it('should throw an error if the user does not exist', async () => {
-            await expect(passage.user.get('invalid')).rejects.toThrow('Could not find user with that external ID');
+            await expect(passage.user.get('invalid')).rejects.toThrow('User not found.');
         });
     });
 
@@ -155,9 +155,7 @@ describe('PassageFlex', () => {
         });
 
         it('should throw an error if the user does not exist', async () => {
-            await expect(passage.user.listDevices('invalid')).rejects.toThrow(
-                'Could not find user with that external ID',
-            );
+            await expect(passage.user.listDevices('invalid')).rejects.toThrow('User not found.');
         });
     });