refact: ensure all payload keys are camelised.

And shift that camelising logic borrowed from awrence into a helper
class.

Author: pat

lib/render_api/camelise.rb

@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+module RenderAPI
+  # Borrowed from awrence:
+  # https://github.com/technicalpanda/awrence/blob/main/lib/awrence/methods.rb
+  class Camelise
+    def self.call(...)
+      new.call(...)
+    end
+
+    def call(string, first_upper: false)
+      if first_upper
+        string = gsubbed(string, /(?:^|_)([^_\s]+)/)
+        gsubbed(string, %r{/([^/]*)}, "::")
+      else
+        parts = string.split("_", 2)
+        parts[0] << call(parts[1], first_upper: true) if parts.size > 1
+        parts[0] || ""
+      end
+    end
+
+    private
+
+    def gsubbed(string, pattern, extra = "")
+      string.gsub(pattern) { extra + Regexp.last_match(1).capitalize }
+    end
+  end
+end

lib/render_api/clients/deploys.rb

@@ -7,7 +7,7 @@ module Clients
     class Deploys < Base
       def create(service_id, clear_cache: nil)
         body = nil
-        body = { clearCache: clear_cache } unless clear_cache.nil?
+        body = { clear_cache: clear_cache } unless clear_cache.nil?
 
         endpoint.post(
           "/services/#{service_id}/deploys", body: body

lib/render_api/clients/jobs.rb

@@ -7,7 +7,7 @@ module Clients
     class Jobs < Base
       def create(service_id, start_command:, plan_id: nil)
         body = { startCommand: start_command }
-        body[:planId] = plan_id unless plan_id.nil?
+        body[:plan_id] = plan_id unless plan_id.nil?
 
         endpoint.post(
           "/services/#{service_id}/jobs", body: body

lib/render_api/data_object.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require_relative "./camelise"
+
 module RenderAPI
   class DataObject
     TIME_PATTERN = /\A\d\d\d\d-\d\d-\d\dT\d\d:\d\d:\d\d.\d+Z\z/.freeze
@@ -23,34 +25,15 @@ def to_h
 
     attr_reader :data
 
-    # Borrowed from awrence:
-    # https://github.com/technicalpanda/awrence/blob/main/lib/awrence/methods.rb
-    def camelize(string, first_upper: false)
-      if first_upper
-        string = gsubbed(string, /(?:^|_)([^_\s]+)/)
-        gsubbed(string, %r{/([^/]*)}, "::")
-      else
-        parts = string.split("_", 2)
-        parts[0] << camelize(parts[1], first_upper: true) if parts.size > 1
-        parts[0] || ""
-      end
-    end
-
-    # Borrowed and simplified from awrence:
-    # https://github.com/technicalpanda/awrence/blob/main/lib/awrence/methods.rb
-    def gsubbed(str, pattern, extra = "")
-      str.gsub(pattern) { extra + Regexp.last_match(1).capitalize }
-    end
-
     def method_missing(name, *args, **kwargs, &block)
       return super unless respond_to_missing?(name, false)
       raise ArgumentError if args.any? || kwargs.any? || block
 
-      translate(data[camelize(name.to_s)])
+      translate(data[Camelise.call(name.to_s)])
     end
 
     def respond_to_missing?(name, _include_all)
-      data.key?(camelize(name.to_s))
+      data.key?(Camelise.call(name.to_s))
     end
 
     def translate(object)

lib/render_api/endpoint.rb

@@ -2,6 +2,7 @@
 
 require "http"
 
+require_relative "./camelise"
 require_relative "./response"
 
 module RenderAPI
@@ -18,7 +19,7 @@ def get(path, params: nil)
     end
 
     def post(path, body: nil)
-      request(:post, path, body: body)
+      request(:post, path, body: camelise(body))
     end
 
     def delete(path)
@@ -29,6 +30,19 @@ def delete(path)
 
     attr_reader :api_key
 
+    def camelise(object)
+      case object
+      when Hash
+        object
+          .transform_keys { |key| Camelise.call(key.to_s) }
+          .transform_values { |value| camelise(value) }
+      when Array
+        object.collect { |item| camelise(item) }
+      else
+        object
+      end
+    end
+
     def handle_error(response)
       raise RequestError, response.body.to_s
     end

spec/features/deploys_spec.rb

@@ -26,6 +26,28 @@
       )
     end
 
+    it "sends no payload by default" do
+      subject.create(service_id)
+
+      expect(
+        a_request(
+          :post, "https://api.render.com/v1/services/#{service_id}/deploys"
+        ).with { |request| request.body == "" }
+      ).to have_been_made
+    end
+
+    it "sends a payload if clearing the cache" do
+      subject.create(service_id, clear_cache: "clear")
+
+      expect(
+        a_request(
+          :post, "https://api.render.com/v1/services/#{service_id}/deploys"
+        ).with_json_body do |json|
+          json == { "clearCache" => "clear" }
+        end
+      ).to have_been_made
+    end
+
     it "returns the new deploy details" do
       response = subject.create(service_id)
 

spec/features/jobs_spec.rb

@@ -24,6 +24,30 @@
       )
     end
 
+    it "sends the provided payload" do
+      subject.create(service_id, start_command: "whoami")
+
+      expect(
+        a_request(
+          :post, "https://api.render.com/v1/services/#{service_id}/jobs"
+        ).with_json_body do |json|
+          json == { "startCommand" => "whoami" }
+        end
+      ).to have_been_made
+    end
+
+    it "includes the plan id if provided" do
+      subject.create(service_id, start_command: "whoami", plan_id: "a-plan")
+
+      expect(
+        a_request(
+          :post, "https://api.render.com/v1/services/#{service_id}/jobs"
+        ).with_json_body do |json|
+          json == { "startCommand" => "whoami", "planId" => "a-plan" }
+        end
+      ).to have_been_made
+    end
+
     it "returns the new job details" do
       response = subject.create(service_id, start_command: "whoami")