Rails 7.2 support?

[sandifx68]

We are currently trying to upgrade to Rails 7.2, but we are currently getting errors related to thinking sphinx:

/Users/sandifx68/.rbenv/versions/3.2.4/gemsets/harmonics/gems/thinking-sphinx-5.6.0/lib/thinking_sphinx/active_record/filter_reflection.rb:16:in `call': undefined method `new' for nil:NilClass (NoMethodError)

    ReflectionGenerator.new(reflection, name, class_name).call
                       ^^^^
        from /Users/sandifx68/.rbenv/versions/3.2.4/gemsets/harmonics/gems/thinking-sphinx-5.6.0/lib/thinking_sphinx/active_record/polymorpher.rb:31:in `clone_with'
        from /Users/sandifx68/.rbenv/versions/3.2.4/gemsets/harmonics/gems/thinking-sphinx-5.6.0/lib/thinking_sphinx/active_record/polymorpher.rb:21:in `block in append_reflections'
        from /Users/sandifx68/.rbenv/versions/3.2.4/gemsets/harmonics/gems/thinking-sphinx-5.6.0/lib/thinking_sphinx/active_record/polymorpher.rb:18:in `each'
        from /Users/sandifx68/.rbenv/versions/3.2.4/gemsets/harmonics/gems/thinking-sphinx-5.6.0/lib/thinking_sphinx/active_record/polymorpher.rb:18:in `append_reflections'
        from /Users/sandifx68/.rbenv/versions/3.2.4/gemsets/harmonics/gems/thinking-sphinx-5.6.0/lib/thinking_sphinx/active_record/polymorpher.rb:9:in `morph!'
        from /Users/sandifx68/.rbenv/versions/3.2.4/gemsets/harmonics/gems/thinking-sphinx-5.6.0/lib/thinking_sphinx/active_record/sql_source.rb:160:in `each'
        from /Users/sandifx68/.rbenv/versions/3.2.4/gemsets/harmonics/gems/thinking-sphinx-5.6.0/lib/thinking_sphinx/active_record/sql_source.rb:160:in `prepare_for_render'
        from /Users/sandifx68/.rbenv/versions/3.2.4/gemsets/harmonics/gems/thinking-sphinx-5.6.0/lib/thinking_sphinx/active_record/sql_source.rb:83:in `render'
        from /Users/sandifx68/.rbenv/versions/3.2.4/gemsets/harmonics/gems/riddle-2.4.3/lib/riddle/configuration/index.rb:30:in `block in render'
        from /Users/sandifx68/.rbenv/versions/3.2.4/gemsets/harmonics/gems/riddle-2.4.3/lib/riddle/configuration/index.rb:30:in `collect'
        from /Users/sandifx68/.rbenv/versions/3.2.4/gemsets/harmonics/gems/riddle-2.4.3/lib/riddle/configuration/index.rb:30:in `render'
        from /Users/sandifx68/.rbenv/versions/3.2.4/gemsets/harmonics/gems/thinking-sphinx-5.6.0/lib/thinking_sphinx/core/index.rb:74:in `render'
        from /Users/sandifx68/.rbenv/versions/3.2.4/gemsets/harmonics/gems/riddle-2.4.3/lib/riddle/configuration.rb:45:in `block in render'
        from /Users/sandifx68/.rbenv/versions/3.2.4/gemsets/harmonics/gems/riddle-2.4.3/lib/riddle/configuration.rb:45:in `collect'
        from /Users/sandifx68/.rbenv/versions/3.2.4/gemsets/harmonics/gems/riddle-2.4.3/lib/riddle/configuration.rb:45:in `render'
        from /Users/sandifx68/.rbenv/versions/3.2.4/gemsets/harmonics/gems/thinking-sphinx-5.6.0/lib/thinking_sphinx/configuration.rb:111:in `render'
        ... 85 levels...

I am strongly suspecting this is an easy fix with just modifying lib/thinking_sphinx/active_record/filter_reflection.rb. I have not succeeded with running the repo locally in order to modify it myself and submit a proper PR. Is anybody else able to look into this? Thanks

[pat]

@sandifx68 thanks for reporting this - surprised I've missed that update for so long!

I've released TS v6.0.0 with the fix - the only breaking changes are dropping support for old versions of Ruby (prior to v3.0) and Rails (prior to v6.1). In both cases, I think you're fine :)