fix: only count update as successful when post_update passes

Author: DjodyKort

src/mcpm/commands/update.py

@@ -312,16 +312,19 @@ def _run_update(
             continue
 
         console.print(f"  git pull [green]✓[/] ({status.commits_behind} new commit{'s' if status.commits_behind != 1 else ''})")
-        sources.mark_updated(name)
 
         # Post-update command
+        post_ok = True
         if source.post_update:
-            post_success = _run_post_update(source.post_update, repo_path)
-            if not post_success:
+            post_ok = _run_post_update(source.post_update, repo_path)
+            if not post_ok:
                 console.print(f"  [dim]Run manually: cd {source.path} && {source.post_update}[/]")
 
+        if post_ok:
+            sources.mark_updated(name)
+            success_count += 1
+
         console.print()
-        success_count += 1
 
     console.print(f"[bold green]Done.[/] {success_count} server(s) updated.")
 

tests/test_update.py

@@ -421,7 +421,7 @@ def test_apply_with_post_update_success(self, monkeypatch, tmp_path):
         assert "1 server(s) updated" in result.output
 
     def test_apply_with_post_update_failure(self, monkeypatch, tmp_path):
-        """Test that post_update failure is reported but pull still counted."""
+        """Test that post_update failure prevents counting as successful update."""
         sources_path = tmp_path / "sources.json"
         repo_dir = tmp_path / "repo"
         repo_dir.mkdir()
@@ -448,8 +448,8 @@ def test_apply_with_post_update_failure(self, monkeypatch, tmp_path):
 
         runner = CliRunner()
         result = runner.invoke(update, ["--force"])
-        # Post-update failed, but git pull succeeded — still counts as updated
-        assert "1 server(s) updated" in result.output
+        # Post-update failed — not counted as successful update
+        assert "0 server(s) updated" in result.output
 
     def test_apply_pull_fails(self, monkeypatch, tmp_path):
         """Test that a failed pull is reported and not counted."""