wip

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>

Author: patrickelectric

core/services/service_manager/service_manager/server.py

@@ -1,5 +1,5 @@
 """REST server using FastAPI framework."""
-# pylint: disable=global-statement,too-many-statements
+# pylint: disable=global-statement,too-many-statements,too-many-locals
 
 import logging
 import sys
@@ -9,7 +9,6 @@
 from pydantic import BaseModel
 from service_manager import __version__
 from service_manager.cgroup import CgroupController
-from service_manager.config import ResourceLimits
 from service_manager.metrics import MetricsSampler
 from service_manager.output import OutputCapture
 from service_manager.registry import ServiceRegistry
@@ -96,7 +95,9 @@ def get_registry() -> ServiceRegistry:
 def get_supervisor() -> ProcessSupervisor:
     """Get the process supervisor, raising HTTPException if not available."""
     if _supervisor is None:
-        raise HTTPException(status_code=503, detail="Process supervisor not initialized")
+        raise HTTPException(
+            status_code=503, detail="Process supervisor not initialized"
+        )
     return _supervisor
 
 
@@ -153,7 +154,9 @@ async def health() -> HealthResponse:
         reg = get_registry()
         running = len(reg.running_services())
         total = len(reg.all())
-        return HealthResponse(status="healthy", services_running=running, services_total=total)
+        return HealthResponse(
+            status="healthy", services_running=running, services_total=total
+        )
 
     @app.get("/version", response_model=VersionResponse, tags=["Health"])
     async def version() -> VersionResponse:
@@ -178,7 +181,9 @@ async def get_service(name: str) -> dict[str, Any]:
             raise HTTPException(status_code=404, detail=f"Service not found: {name}")
         return state.to_dict()
 
-    @app.post("/services/{name}/start", response_model=MessageResponse, tags=["Services"])
+    @app.post(
+        "/services/{name}/start", response_model=MessageResponse, tags=["Services"]
+    )
     async def start_service(name: str) -> MessageResponse:
         """Start a stopped service."""
         reg = get_registry()
@@ -195,8 +200,12 @@ async def start_service(name: str) -> MessageResponse:
             return MessageResponse(message=f"Service {name} started")
         raise HTTPException(status_code=500, detail=f"Failed to start service: {name}")
 
-    @app.post("/services/{name}/stop", response_model=MessageResponse, tags=["Services"])
-    async def stop_service(name: str, body: Optional[StopServiceBody] = None) -> MessageResponse:
+    @app.post(
+        "/services/{name}/stop", response_model=MessageResponse, tags=["Services"]
+    )
+    async def stop_service(
+        name: str, body: Optional[StopServiceBody] = None
+    ) -> MessageResponse:
         """Stop a running service."""
         reg = get_registry()
         sup = get_supervisor()
@@ -213,7 +222,9 @@ async def stop_service(name: str, body: Optional[StopServiceBody] = None) -> Mes
             return MessageResponse(message=f"Service {name} stopped")
         raise HTTPException(status_code=500, detail=f"Failed to stop service: {name}")
 
-    @app.post("/services/{name}/restart", response_model=MessageResponse, tags=["Services"])
+    @app.post(
+        "/services/{name}/restart", response_model=MessageResponse, tags=["Services"]
+    )
     async def restart_service(name: str) -> MessageResponse:
         """Restart a service (stop then start)."""
         reg = get_registry()
@@ -228,10 +239,16 @@ async def restart_service(name: str) -> MessageResponse:
         success = await sup.start_service(name)
         if success:
             return MessageResponse(message=f"Service {name} restarted")
-        raise HTTPException(status_code=500, detail=f"Failed to restart service: {name}")
+        raise HTTPException(
+            status_code=500, detail=f"Failed to restart service: {name}"
+        )
 
-    @app.patch("/services/{name}/config", response_model=MessageResponse, tags=["Services"])
-    async def update_service_config(name: str, body: UpdateConfigBody) -> MessageResponse:
+    @app.patch(
+        "/services/{name}/config", response_model=MessageResponse, tags=["Services"]
+    )
+    async def update_service_config(
+        name: str, body: UpdateConfigBody
+    ) -> MessageResponse:
         """Update service configuration (limits, restart settings)."""
         reg = get_registry()
         cg = get_cgroup()
@@ -259,15 +276,21 @@ async def update_service_config(name: str, body: UpdateConfigBody) -> MessageRes
         if body.limits:
             limits = spec.limits
             if body.limits.cpu_cores is not None:
-                limits.cpu_cores = body.limits.cpu_cores if body.limits.cpu_cores > 0 else None
+                limits.cpu_cores = (
+                    body.limits.cpu_cores if body.limits.cpu_cores > 0 else None
+                )
                 updated_fields.append("cpu_cores")
 
             if body.limits.memory_mb is not None:
-                limits.memory_mb = body.limits.memory_mb if body.limits.memory_mb > 0 else None
+                limits.memory_mb = (
+                    body.limits.memory_mb if body.limits.memory_mb > 0 else None
+                )
                 updated_fields.append("memory_mb")
 
             if body.limits.max_pids is not None:
-                limits.max_pids = body.limits.max_pids if body.limits.max_pids > 0 else None
+                limits.max_pids = (
+                    body.limits.max_pids if body.limits.max_pids > 0 else None
+                )
                 updated_fields.append("max_pids")
 
             # Apply limits to running service's cgroup if applicable
@@ -284,8 +307,12 @@ async def update_service_config(name: str, body: UpdateConfigBody) -> MessageRes
     @app.get("/services/{name}/logs", tags=["Logs"])
     async def get_service_logs(
         name: str,
-        tail: Optional[int] = Query(default=100, description="Number of lines to return"),
-        stream: Optional[str] = Query(default=None, description="Filter by stream (stdout/stderr)"),
+        tail: Optional[int] = Query(
+            default=100, description="Number of lines to return"
+        ),
+        stream: Optional[str] = Query(
+            default=None, description="Filter by stream (stdout/stderr)"
+        ),
     ) -> dict[str, Any]:
         """Get logs for a specific service."""
         reg = get_registry()
@@ -298,7 +325,11 @@ async def get_service_logs(
         if not service_output:
             return {"service": name, "lines": [], "count": 0}
         lines = service_output.get_lines(tail=tail, stream=stream)
-        return {"service": name, "lines": [line.to_dict() for line in lines], "count": len(lines)}
+        return {
+            "service": name,
+            "lines": [line.to_dict() for line in lines],
+            "count": len(lines),
+        }
 
     # ----- Metrics Endpoints -----
 
@@ -307,7 +338,10 @@ async def get_all_metrics() -> dict[str, Any]:
         """Get metrics for all services."""
         samp = get_sampler()
         metrics = samp.get_all()
-        return {"metrics": {name: m.to_dict() for name, m in metrics.items()}, "count": len(metrics)}
+        return {
+            "metrics": {name: m.to_dict() for name, m in metrics.items()},
+            "count": len(metrics),
+        }
 
     @app.get("/metrics/{name}", tags=["Metrics"])
     async def get_service_metrics(name: str) -> dict[str, Any]: