core: commonwealth: DHCPServerManager: Try to start DHCP server 3 times

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>

Author: patrickelectric

core/libs/commonwealth/commonwealth/utils/DHCPServerManager.py

@@ -101,16 +101,23 @@ def command_list(self) -> List[Union[str, pathlib.Path]]:
         ]
 
     def start(self) -> None:
-        try:
-            # pylint: disable=consider-using-with
-            self._subprocess = subprocess.Popen(self.command_list(), shell=False, encoding="utf-8", errors="ignore")
-            time.sleep(3)
-            if not self.is_running():
-                exit_code = self._subprocess.returncode
-                raise RuntimeError(f"Failed to initialize Dnsmasq ({exit_code}).")
-            logger.info("DHCP Server started.")
-        except Exception as error:
-            raise RuntimeError("Unable to start DHCP Server.") from error
+        attempts = 3
+        for attempt in range(attempts):
+            try:
+                # pylint: disable=consider-using-with
+                self._subprocess = subprocess.Popen(self.command_list(), shell=False, encoding="utf-8", errors="ignore")
+                time.sleep(3)
+                if self.is_running():
+                    logger.info("DHCP Server started.")
+                    return
+                else:
+                    exit_code = self._subprocess.returncode
+                    logger.error(f"Attempt {attempt + 1} failed to initialize Dnsmasq ({exit_code}).")
+            except Exception as error:
+                logger.error(f"Attempt {attempt + 1} encountered an error: {error}")
+                time.sleep(1)  # Wait a bit before retrying
+
+        raise RuntimeError("Unable to start DHCP Server")
 
     def stop(self) -> None:
         if self.is_running():