[Scout] Failing test tags a11y checks

Author: paulinashakirova

x-pack/platform/plugins/shared/saved_objects_tagging/test/scout/ui/fixtures/page_objects/tag_assign_flyout.ts

@@ -26,9 +26,8 @@ export class TagAssignFlyout {
   }
 
   async waitForResultsLoaded() {
-    await this.resultList.waitFor({ state: 'visible' });
-    await this.page.waitForFunction(
-      () => document.querySelectorAll('[data-is-loading="true"]').length === 0
-    );
+    await this.resultList.locator('.euiLoadingSpinner').waitFor({ state: 'hidden' });
+    // EUI icons are briefly role="img" with no alt text while loading — wait for them to settle.
+    await this.resultList.locator('[data-is-loading="true"]').waitFor({ state: 'hidden' });
   }
 }

x-pack/platform/plugins/shared/saved_objects_tagging/test/scout/ui/fixtures/page_objects/tags_table.ts

@@ -100,8 +100,9 @@ export class TagsTable {
     return this.bulkActionsButton.isVisible();
   }
 
-  // portal: action rendered in EUI portal (collapsed menu); inline: rendered on the row.
-  async clickRowAction(tagName: string, action: string, location: 'portal' | 'inline' = 'inline') {
+  // assign/delete live in the EUI portal after the `...` menu is opened; edit
+  // (isPrimary) is always inline on the row.
+  async clickRowAction(tagName: string, action: string, location: 'portal' | 'inline') {
     const testSubj = `tagsTableAction-${action}`;
     const actionLocator =
       location === 'portal'
@@ -112,6 +113,9 @@ export class TagsTable {
     await actionLocator.click();
   }
 
+  // The `...` button appears slightly after the table-is-ready signal fires
+  // (the edit/assign/delete actions are non-primary and collapse when >2 exist),
+  // so waitFor is used instead of an instant isVisible check.
   async clickCollapsedRowAction(tagName: string, action: string) {
     const row = this.rowByName(tagName);
     const collapseBtn = row.locator('[data-test-subj="euiCollapsedItemActionsButton"]');

x-pack/platform/plugins/shared/saved_objects_tagging/test/scout/ui/tests/tags_a11y.spec.ts

@@ -56,7 +56,7 @@ test.describe('Tags management — accessibility', { tag: tags.stateful.classic
     });
 
     await test.step('edit tag panel', async () => {
-      await tagsTable.clickRowAction('a11yTag', 'edit');
+      await tagsTable.clickRowAction('a11yTag', 'edit', 'inline');
       await tagModal.form.waitFor({ state: 'visible' });
       const { violations } = await page.checkA11y({ include: A11Y_SELECTORS });
       expect(violations).toStrictEqual([]);