Skip to content

Commit 5e03058

Browse files
jonwalstedtpaulinashakirova
authored andcommitted
test(timeline): fix flaky timeline test by wating for detail-panel to… (elastic#269814)
## Summary Fixes flaky cypress test: `x-pack/solutions/security/test/security_solution_cypress/cypress/e2e/investigations/timelines/timelines_table.cy.ts` Closes: elastic#269981 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ...
1 parent 476de2b commit 5e03058

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

  • x-pack/solutions/security/test/security_solution_cypress/cypress/tasks

x-pack/solutions/security/test/security_solution_cypress/cypress/tasks/timeline.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -372,8 +372,10 @@ export const saveTimeline = () => {
372372

373373
export const markAsFavorite = () => {
374374
cy.intercept('PATCH', 'api/timeline/_favorite').as('markedAsFavourite');
375+
cy.intercept('GET', '/api/timelines*').as('timelinesRefreshed');
375376
cy.get(TIMELINE_PANEL).within(() => cy.get(STAR_ICON).click());
376377
cy.wait('@markedAsFavourite');
378+
cy.wait('@timelinesRefreshed');
377379
};
378380

379381
export const openTimelineDiscoverAddField = () => {

0 commit comments

Comments
 (0)