[Scout] Failing test tags a11y checks

Author: paulinashakirova

x-pack/platform/plugins/shared/saved_objects_tagging/test/scout/ui/fixtures/page_objects/tag_assign_flyout.ts

@@ -27,5 +27,7 @@ export class TagAssignFlyout {
 
   async waitForResultsLoaded() {
     await this.resultList.locator('.euiLoadingSpinner').waitFor({ state: 'hidden' });
+    // EUI icons are briefly role="img" with no alt text while loading — wait for them to settle.
+    await this.resultList.locator('[data-is-loading="true"]').waitFor({ state: 'hidden' });
   }
 }

x-pack/platform/plugins/shared/saved_objects_tagging/test/scout/ui/fixtures/page_objects/tags_table.ts

@@ -100,21 +100,28 @@ export class TagsTable {
     return this.bulkActionsButton.isVisible();
   }
 
-  async openCollapsedRowMenu(tagName: string) {
+  // assign/delete live in the EUI portal after the `...` menu is opened; edit
+  // (isPrimary) is always inline on the row.
+  async clickRowAction(tagName: string, action: string, location: 'portal' | 'inline') {
+    const testSubj = `tagsTableAction-${action}`;
+    const actionLocator =
+      location === 'portal'
+        ? this.page.locator('[data-euiportal="true"]').locator(`[data-test-subj="${testSubj}"]`)
+        : this.rowByName(tagName).locator(`[data-test-subj="${testSubj}"]`);
+
+    await actionLocator.waitFor({ state: 'visible' });
+    await actionLocator.click();
+  }
+
+  // The `...` button appears slightly after the table-is-ready signal fires
+  // (the edit/assign/delete actions are non-primary and collapse when >2 exist),
+  // so waitFor is used instead of an instant isVisible check.
+  async clickCollapsedRowAction(tagName: string, action: string) {
     const row = this.rowByName(tagName);
     const collapseBtn = row.locator('[data-test-subj="euiCollapsedItemActionsButton"]');
     await collapseBtn.waitFor({ state: 'visible' });
     await collapseBtn.click();
-  }
-
-  // The action is scoped to the EUI portal where the collapsed-menu items render, to avoid
-  // matching the always-present inline row buttons that share the same
-  // data-test-subj.
-  async clickRowAction(action: string) {
-    await this.page
-      .locator('[data-euiportal="true"]')
-      .locator(`[data-test-subj="tagsTableAction-${action}"]`)
-      .click();
+    await this.clickRowAction(tagName, action, 'portal');
   }
 
   rowByName(tagName: string): Locator {

x-pack/platform/plugins/shared/saved_objects_tagging/test/scout/ui/tests/tags_a11y.spec.ts

@@ -13,8 +13,7 @@ import { test } from '../fixtures';
 // Modals, flyouts, and context menus render in EUI portals outside .kbnAppWrapper.
 const A11Y_SELECTORS = ['.kbnAppWrapper', '[data-euiportal="true"]'];
 
-// Failing: See https://github.com/elastic/kibana/issues/267280
-test.describe.skip('Tags management — accessibility', { tag: tags.stateful.classic }, () => {
+test.describe('Tags management — accessibility', { tag: tags.stateful.classic }, () => {
   test.afterAll(async ({ kbnClient }) => {
     await kbnClient.savedObjects.cleanStandardList();
   });
@@ -45,16 +44,9 @@ test.describe.skip('Tags management — accessibility', { tag: tags.stateful.cla
       expect(violations).toStrictEqual([]);
     });
 
-    await test.step('tag actions panel', async () => {
-      await tagsTable.openCollapsedRowMenu('a11yTag');
-      const { violations } = await page.checkA11y({ include: A11Y_SELECTORS });
-      expect(violations).toStrictEqual([]);
-      await page.keyboard.press('Escape');
-    });
-
     await test.step('tag assignment flyout and listing', async () => {
-      await tagsTable.openCollapsedRowMenu('a11yTag');
-      await tagsTable.clickRowAction('assign');
+      await tagsTable.clickCollapsedRowAction('a11yTag', 'assign');
+      await assignFlyout.waitForResultsLoaded();
       const { violations: flyoutViolations } = await page.checkA11y({ include: A11Y_SELECTORS });
       expect(flyoutViolations).toStrictEqual([]);
       await assignFlyout.closeButton.click();
@@ -64,8 +56,7 @@ test.describe.skip('Tags management — accessibility', { tag: tags.stateful.cla
     });
 
     await test.step('edit tag panel', async () => {
-      await tagsTable.openCollapsedRowMenu('a11yTag');
-      await tagsTable.clickRowAction('edit');
+      await tagsTable.clickRowAction('a11yTag', 'edit', 'inline');
       await tagModal.form.waitFor({ state: 'visible' });
       const { violations } = await page.checkA11y({ include: A11Y_SELECTORS });
       expect(violations).toStrictEqual([]);